Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tokens] Colors #124

Closed
5 tasks done
pylapp opened this issue Sep 23, 2024 · 2 comments · Fixed by #198
Closed
5 tasks done

[Tokens] Colors #124

pylapp opened this issue Sep 23, 2024 · 2 comments · Fixed by #198
Assignees
@pylapp
Labels
🆕 feature Related to features 📀 token Related to tokens (raws, semantics or components)

Comments

@pylapp
Copy link
Member

pylapp commented Sep 23, 2024 •
edited
Loading

Details

See the Figjam

Definiton of Done

  • Remove alias tokens
  • Remove any optional objects in colors
  • Update tokens (remove old ones, add/rename others)
  • Update unit tests
  • Throw errors if hard-coded values / missing tokens / missing values

Internal reference

Jira reference: OUDS-104
@pylapp pylapp added the 📀 token Related to tokens (raws, semantics or components) label Sep 23, 2024
@pylapp pylapp moved this from Triage to Todo in [OUDS] Project Sep 23, 2024
@pylapp pylapp assigned pylapp and unassigned pylapp Sep 23, 2024
@pylapp pylapp added the 🆕 feature Related to features label Sep 23, 2024
@pylapp pylapp self-assigned this Sep 25, 2024
@pylapp pylapp moved this from Todo to In Progress in [OUDS] Project Sep 25, 2024
@pylapp
Copy link
Member Author

pylapp commented Sep 25, 2024 •
edited
Loading

Don't know if something should be done or if tokens should be updated compared to what we have today.
On hold until next workshops about this topic.

@pylapp pylapp added the ⚠️ on hold Not blocked but should not be processed yet label Sep 25, 2024
@pylapp pylapp changed the title Tokens: Colors [Tokens] Colors Oct 2, 2024
pylapp added a commit that referenced this issue Oct 3, 2024
@pylapp
refactor: update colors raw and semantic tokens (#124) (#153)
7407979 
Update some raw tokens and semantic tokens values for colors.
Add also plenty of semantic tokens for color, even if some of them are not added yet (but TODO have been written).

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp pylapp removed the ⚠️ on hold Not blocked but should not be processed yet label Oct 15, 2024
@pylapp pylapp linked a pull request Oct 16, 2024 that will close this issue
[#124] Update color semantic tokens #198
Merged
pylapp added a commit that referenced this issue Oct 16, 2024
@pylapp
feat: add color semantic tokens (#124) (#198)
1ebf090 
- Refactor all color semantic tokens with new values available in Figjam
- Update associated unit tests
- Improve documentation

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to Done in [OUDS] Project Oct 16, 2024
pylapp added a commit that referenced this issue Oct 17, 2024
@pylapp
docs: update documentation in DocC catalogs and sources about colors (#…
7514175 
…124)

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp pylapp mentioned this issue Oct 18, 2024
Merged
pylapp added a commit that referenced this issue Oct 18, 2024
@pylapp @ludovic35 @Tayebsed93
Release 0.4.0 (#206)
c8da6ec 
Release of version 0.4.0
See below the full CHANGELOG details.

Added

- [DemoApp] Update opacity screen with new design ([#200](#200))
- [DemoApp] Add color tokens screen in demo app ([#152](#152))
- [Library] Add semantic tokens `spacePaddingInlineTallest`, `spacePaddingBlockTallest`, `spaceColumnGapTaller`, `spaceColumnGapWithArrowShortest`, `spaceRowGapShortest` (Figjam final synchronization of October 16th)
- [Library] Add semantic color tokens ([#124](#124))
- [DemoApp] Fix some design issues and mutualize some UI elements ([#189](#189))
- [DemoApp] Add sizing tokens screen in demo app ([#150](#150))
- [DemoApp] Add spacing tokens screen in demo app ([#149](#149))
- [Library] Add color semantic tokens `colorContentTransparentDefault`, `colorBorderTransparentDefault` and `colorBackgroundTransparentDefault` (October 8th) ([#177](#177))
- [DemoApp] On opacity screen, add a border around the view showing the opacity ([#157](#157))

Changed

- [Library] Update of semantic typography tokens (Figjam final synchronization of October 16th)
- [Library] Update of semantic grid tokens `gridExtraCompactColumnCount`, `gridCompactColumnGap`, `gridRegularColumnGap` (Figjam final synchronization of October 16th)
- [Library] Update of semantic elevation token `elevationStickyNavigationScrolled` (Figjam final synchronization of October 16th)
- [Library] Update of semantic color tokens, semantic sizing tokens (Figjam final synchronization of October 16th)
- [Library/DemoApp] Updates SwiftLint rules, fix linter warnings ([#143](#143))
- [Tool] Update the templates for GitHub issues
- [Tool] Improve script for documentation generation ([#168](#168))
- [Library] Rename raw brand-specific color tokens in Orange theme (no use of "brand" word) ([#179](#179))
- [Library] `fontLetterSpacingMobile*` and `fontLetterSpacingTablet*` merged in `MultipleFontLetterSpacingTokens` objects
- [Library] `fontLineHeightMobile*` and `fontLineHeightTablet*` merged in `MultipleFontLineHeightTokens` objects
- [Library] `fontSizeMobile*` and `fontSizeTablet*` merged in `MultipleFontSizeTokens` objects 
- [Library] Update semantic and raw tokens for fonts ([#155](#155))
- [Library] Update semantic tokens for fonts (October 7th) ([#172](#172))
- [Library] Update raw tokens for fonts (October 7th) ([#170](#170))
- [Library] Any semantic token of sizing `TypeXXX` has been replaced by `TypeSizeXXX` (update of October 7th)
- [Library] Any semantic tokens of sizing `WithTypeXXX` has been replaced by `TypzeXXX` (update of October 7th)
- [Library] Update semantic tokens for sizing (October 7th) ([#173](#173))
- [Library] Any semantic tokens of spacing `isIcon` and `isArrow` are now `withIcon` and `withArrow` (update of October 7th)
- [Library] Update semantic tokens for spacing (October 4th) ([#174](#174))
- [Library] Update semantic tokens for spacing (October 4th) ([#156](#156))
- [Library] Update raw tokens for dimensions (October 7th) ([#169](#169))

Removed

- [Library] Raw typography token `fontSize100` (Figjam final synchronization of October 16th)
- [Library] Semantic token `spaceColumnGapWithArrowTaller` (Figjam final synchronization of October 16th)
- [Library] Remove all color alias semantic tokens and any optional color tokens type uses
- [Library] `SoshTheme` ([#180](#180))
- [Library] `fontSizeMobile*`, `fontSizeTablet*`, `fontLineHeightMobile*`, `fontLineHeightTablet*`, `fontLetterSpacingMobile*`, `fontLetterSpacingTablet*` removed (update of October 4th)
- [Library] `spaceRowGapWithIconTaller`, `spaceColumnGapWithIconTaller` removed (update of October 7th)

Fixed

- [Library] `typeBodyDefaultLarge` font weight ([#191](#191))

Co-authored-by: Pierre-Yves Lapersonne <[email protected]>
Co-authored-by: Ludovic Pinel <[email protected]>
Co-authored-by: Tayeb Sedraia <[email protected]>
@pylapp
Copy link
Member Author

pylapp commented Oct 18, 2024

ℹ️ Released with version v0.4.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pylapp pylapp

Labels
🆕 feature Related to features 📀 token Related to tokens (raws, semantics or components)
Projects
[OUDS] Project
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#124] Update color semantic tokens Orange-OpenSource/ouds-ios
1 participant
@pylapp