[PHP-Lumen] Lumen 5.6 support #114

Lv-Yi · 2018-05-20T16:47:35Z

PR checklist

Read the contribution guidelines.
Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
Filed the PR against the correct branch: Default: master.
Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

To support Lumen 5.6.
Fix of #7530(swagger-api/swagger-codegen#7530) and #6963 (swagger-api/swagger-codegen#6963).

Note (as stated in modules/openapi-generator/src/main/resources/lumen/readme.md ): Excute 'composer update' for the first run, which will generate vendor/autoload.php and import necessary dependencies. Otherwise there would be errors during http service or model migration.

* update php samples with oas2 before enabling ci test * deleted unused php files

* update erlang server samples with petstore oas2 * fix compilation in erlang server

* test erlang client, server petstore * rename tests, replace tab * install rebar3 in shippable ci

* update c# petstore with oas2 * add csharp tests

* update ts angular 4 from codegen2x * update ts angular v4 with petstore oas2 * restore ts agnular 4.3 from codegen2x * update ts angular 4.3 with petstore oas2

* update ts fetch (default) with oas2 * update ts fetech npm with petstore oas2 * update ts fetch interface (petstore oas2) * update ts fetch es6 (petstore oas2)

* update ts inversify with petstore oas2 * update typescript-aurelia petstore with oas2 * update ts jquery with oas2

* ArraySchema should not be included in aliases * Update php sample (OAS2)

* add scripts for ts oas3 petstore * remove json files * update ts jquery with oas3 petstore * update ts inversify, fix file mapping * update ts fetch wtih oas3 (no diff), fix script

* update php symfony with oas2 petstore * update php symfony with oas3 petstore

* update php silex with oas2 petstore * update php silex with oas3 petstore

* update php slim server petstore with oas2 * update php slim petstore with oas3 (no diff)

* update php ze-ph samples with oas2 * update zeph samples with oas3

Use vendor extension in Operation to set the body parameter name

wing328 · 2018-05-21T13:57:01Z

@Lv-Yi Please ignore the CircleCI errors for the time being. It occasionally passes.

ackintosh · 2018-05-22T12:13:05Z

modules/openapi-generator/src/main/resources/lumen/composer.mustache

@@ -4,7 +4,7 @@
    "version": "{{artifactVersion}}",
    {{/artifactVersion}}
    "description": "{{description}}",
-    "keywords": [
+    "keywords": ["framework", "laravel", "lumen",


I think it is better to align the keywords vertical like below:

"keywords": [ "framework", "laravel", "lumen", "openapi",

updated. thanks!

ackintosh · 2018-05-22T12:17:37Z

@Lv-Yi Would you please update the sample with bin/lumen-petstore-server.sh ?

Lv-Yi · 2018-05-23T03:21:10Z

@ackintosh would you mind share more details on what needed in the sample with bin/lumen-petstore-server.sh ?

ackintosh · 2018-05-24T02:31:32Z

@Lv-Yi I'm sorry I didn't explain it enough. 💦
The checkbox(Ran the shell script under ./bin/....) has marked as done, but the example folder (samples/server/petstore/lumen/) is not seems updated. 👀

jmini · 2018-05-24T04:54:09Z

@ackintosh If you are interested, I am about to add an automatic check with Shippable CI that ensure that the samples/ folder is up to date. (see issue #80). If you think that the PHP scripts should be in the list of checked scripts, please let a comment.

Lv-Yi · 2018-05-26T14:39:12Z

@ackintosh Yes I did run the script and seems no issues. Should the changes in sample dir also be commited?

wing328 · 2018-05-26T15:00:07Z

Yes please commit those changes in the sample.

…

On Sat, May 26, 2018, 10:39 PM Yi ***@***.***> wrote: @ackintosh <https://github.com/ackintosh> Yes I did run the script and seems no issues. Should the changes in sample dir also be commited? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#114 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA5BdCoLsJ53tETsKxQ0LFRgc56cp0dsks5t2WkQgaJpZM4UGI4x> .

Lv-Yi · 2018-05-26T19:32:10Z

@ackintosh @wing328 FYI. The petstore sample results updated.....looks something weird when I tried to update author email as per https://help.github.com/articles/changing-author-info/.

...
seems ok now.

ackintosh · 2018-05-29T10:07:04Z

@Lv-Yi #159 renames the sample folder (lumen -> php-lumen) so it has made the conflicts in this PR. (related issue: #138)
Please resolve the conflicts 🙏

Lv-Yi · 2018-05-30T05:40:13Z

Reset to commit 30688 (Update composer.mustache), the last commit before updating samples.
Merge from latest origin/master.
And then retry the sample scripts.

…ator into lumenUpgrade

Lv-Yi · 2018-05-30T05:46:09Z

$ ./bin/php-lumen-petstore-server.sh

START SCRIPT: ./bin/php-lumen-petstore-server.sh

Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256M; support was removed in 8.0
Exception in thread "main" io.airlift.airline.ParseArgumentsUnexpectedException: Found unexpected parameters: [-g, php-lumen]
at io.airlift.airline.Cli.validate(Cli.java:148)
at io.airlift.airline.Cli.parse(Cli.java:116)
at io.airlift.airline.Cli.parse(Cli.java:97)
at org.openapitools.codegen.OpenAPIGenerator.main(OpenAPIGenerator.java:52)

Lv-Yi · 2018-05-30T06:11:13Z

@ackintosh Please help review the script changes. The test results are based on updated scripts.
Please let me know if the samples need to be updated again.

wing328 · 2018-05-30T06:32:20Z

Looks like the rebase on latest master failed and result in a lot of commits that should not be part of this PR.

I'll see if I can help fix that by cherry-picking the commits authored by @Lv-Yi

Lv-Yi · 2018-05-30T07:33:47Z

@wing328 There were twisted commits on different branches during thest days. Thanks for help! Let me know if anything I can do if necessary.

wing328 · 2018-06-03T17:15:10Z

@Lv-Yi I've cherry-pick your commits and filed #212 instead. Closing this one.

…-4.x chore(deps): update dependency @types/lodash to v4.14.165

wing328 and others added 30 commits April 26, 2018 13:17

Update PHP samples with OAS2 before enabling CI test (#230)

5d1c157

* update php samples with oas2 before enabling ci test * deleted unused php files

Update Erlang server samples with Petstore OAS2 (#150)

b421ee9

* update erlang server samples with petstore oas2 * fix compilation in erlang server

fix erlang client compilation error (#228)

f55f0ac

Regenerate all jaxrs examples (#234)

a6c1459

Rework url handling (#236)

d76ff26

Generate java-msf4j (#225)

b36e145

update erlang server with oas3, no diff (#238)

2c099e2

Test erlang client, server petstore (#235)

4b6f70a

* test erlang client, server petstore * rename tests, replace tab * install rebar3 in shippable ci

update ts node with oas2 (#239)

d9e0282

Update C# API client with Petstore OAS2 (#240)

0d68607

* update c# petstore with oas2 * add csharp tests

Update TS Angular v4, v4.3 with Petstore OAS2 (#241)

3e030d5

* update ts angular 4 from codegen2x * update ts angular v4 with petstore oas2 * restore ts agnular 4.3 from codegen2x * update ts angular 4.3 with petstore oas2

update C# property change client (oas2) (#242)

cba7810

Update TypeScript Fetch client with Petstore OAS2 (#244)

99bb386

* update ts fetch (default) with oas2 * update ts fetech npm with petstore oas2 * update ts fetch interface (petstore oas2) * update ts fetch es6 (petstore oas2)

Generate vertx OAS2 (#226)

f740d79

update ts angularjs petstore (oas2), fix model prefix (#245)

ed4fbc5

update c# netstandard petstore (oas2) (#247)

5092d1f

Update TypeScript jQuery, Aurelia, Inversify with Petstore OAS2 (#248)

0a1c66d

* update ts inversify with petstore oas2 * update typescript-aurelia petstore with oas2 * update ts jquery with oas2

update ts angular2 petstore oas2 (#249)

5630139

Fix missing models (#250)

cd407f4

* ArraySchema should not be included in aliases * Update php sample (OAS2)

Update TypeScript Petstore samples with OAS3 (#253)

046a039

* add scripts for ts oas3 petstore * remove json files * update ts jquery with oas3 petstore * update ts inversify, fix file mapping * update ts fetch wtih oas3 (no diff), fix script

Update PHP Symfony server petstore with OAS2, OAS3 (#255)

2601add

* update php symfony with oas2 petstore * update php symfony with oas3 petstore

Update PHP Silex server petstore with OAS2, OAS3 (#254)

71a1474

* update php silex with oas2 petstore * update php silex with oas3 petstore

Update PHP Slim server samples with OAS2, OAS3 (#258)

28ffb13

* update php slim server petstore with oas2 * update php slim petstore with oas3 (no diff)

Update PHP ZE-PH server samples with OAS2, OAS3 (#259)

831b2a6

* update php ze-ph samples with oas2 * update zeph samples with oas3

restore go client from codgen2x

9b9ae72

fix parameter naming in go

6ee05fa

various fix for go petstore

7c470ba

update go test files

671d5eb

add postProcessParamter for body, form parameter (#263)

b6780a7

use vendor extension in operation to set the body parameter name (#264)

b6601be

Use vendor extension in Operation to set the body parameter name

ackintosh reviewed May 22, 2018

View reviewed changes

Update composer.mustache

30688dc

Lv-Yi and others added 2 commits May 30, 2018 13:32

eliminate conflict from origin master

ca832d0

eliminate conflict from origin/master

b90913f

Lv-Yi added 2 commits May 30, 2018 13:42

Merge remote-tracking branch 'origin1/master' into lumenUpgrade

1d7b43a

Merge branch 'lumenUpgrade' of https://github.com/Lv-Yi/openapi-gener…

de1bbf5

…ator into lumenUpgrade

Lv-Yi added 2 commits May 30, 2018 14:06

sample scripts failed to recognize php-lumen

bbc3bf0

update petstore sample tests with new scripts.

be520d1

wing328 modified the milestones: 3.0.0, 3.0.1 Jun 1, 2018

wing328 mentioned this pull request Jun 3, 2018

[PHP-Lumen] Lumen 5.6 support #212

Merged

4 tasks

wing328 closed this Jun 3, 2018

Lv-Yi deleted the lumenUpgrade branch June 4, 2018 13:57

wing328 removed this from the 3.0.1 milestone Jun 11, 2018

nilskuhn pushed a commit to nilskuhn/openapi-generator that referenced this pull request Apr 6, 2023

Merge pull request OpenAPITools#114 from OpenAPITools/renovate/lodash…

6153ff4

…-4.x chore(deps): update dependency @types/lodash to v4.14.165

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PHP-Lumen] Lumen 5.6 support #114

[PHP-Lumen] Lumen 5.6 support #114

Lv-Yi commented May 20, 2018

wing328 commented May 21, 2018

ackintosh May 22, 2018

Lv-Yi May 23, 2018

ackintosh commented May 22, 2018

Lv-Yi commented May 23, 2018

ackintosh commented May 24, 2018

jmini commented May 24, 2018

Lv-Yi commented May 26, 2018

wing328 commented May 26, 2018 via email

Lv-Yi commented May 26, 2018 •

edited

Loading

ackintosh commented May 29, 2018

Lv-Yi commented May 30, 2018 •

edited

Loading

Lv-Yi commented May 30, 2018

Lv-Yi commented May 30, 2018 •

edited

Loading

wing328 commented May 30, 2018

Lv-Yi commented May 30, 2018

wing328 commented Jun 3, 2018

[PHP-Lumen] Lumen 5.6 support #114

[PHP-Lumen] Lumen 5.6 support #114

Conversation

Lv-Yi commented May 20, 2018

PR checklist

Description of the PR

wing328 commented May 21, 2018

ackintosh May 22, 2018

Choose a reason for hiding this comment

Lv-Yi May 23, 2018

Choose a reason for hiding this comment

ackintosh commented May 22, 2018

Lv-Yi commented May 23, 2018

ackintosh commented May 24, 2018

jmini commented May 24, 2018

Lv-Yi commented May 26, 2018

wing328 commented May 26, 2018 via email

Lv-Yi commented May 26, 2018 • edited Loading

ackintosh commented May 29, 2018

Lv-Yi commented May 30, 2018 • edited Loading

Lv-Yi commented May 30, 2018

START SCRIPT: ./bin/php-lumen-petstore-server.sh

Lv-Yi commented May 30, 2018 • edited Loading

wing328 commented May 30, 2018

Lv-Yi commented May 30, 2018

wing328 commented Jun 3, 2018

Lv-Yi commented May 26, 2018 •

edited

Loading

Lv-Yi commented May 30, 2018 •

edited

Loading

Lv-Yi commented May 30, 2018 •

edited

Loading