Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP] Adjust the names (script, sample folder, generator) to lang option #159

Merged
merged 6 commits into from
May 28, 2018
Merged

[PHP] Adjust the names (script, sample folder, generator) to lang option #159

merged 6 commits into from
May 28, 2018

Conversation

ackintosh
Copy link
Contributor

@ackintosh ackintosh commented May 27, 2018 •
edited
Loading

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Related issue: #138

@ackintosh
Copy link
Contributor Author

@jebentier @dkarlovi @mandrean @jfastnacht

wing328
wing328 approved these changes May 28, 2018
View reviewed changes
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'll file another one to update the Windows batch file.

@wing328 wing328 merged commit 37df59d into OpenAPITools:master May 28, 2018
@wing328 wing328 added this to the 3.0.0 milestone May 28, 2018
@wing328
Copy link
Member

wing328 commented May 28, 2018

UPDATE: added Windows batch files for PHP server generator via #165

@ackintosh
Copy link
Contributor Author

Thanks! ✨

@ackintosh ackintosh deleted the issue-138 branch May 28, 2018 15:19
@ackintosh ackintosh mentioned this pull request May 29, 2018
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wing328 wing328 wing328 approved these changes

Assignees
No one assigned
Labels
Enhancement: CI/Test
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ackintosh @wing328