Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spring] Fix spring controller validation #225

Merged
merged 1 commit into from
Jun 12, 2018

Conversation

cbornet
Copy link
Member

@cbornet cbornet commented Jun 5, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

@bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01)

Description of the PR

The @Validated annotation is useless on models. At the same time, it must be set on the controllers to enable method parameters validation.

@wing328 wing328 added this to the 3.0.1 milestone Jun 7, 2018
@macjohnny
Copy link
Member

macjohnny commented Jun 11, 2018

@cbornet great, I have always wondered why the parameter value constraints had no effect...

@wing328 wing328 modified the milestones: 3.0.1, 3.0.2 Jun 11, 2018
@wing328 wing328 added this to the 3.0.2 milestone Jun 12, 2018
@wing328 wing328 merged commit d2016d8 into OpenAPITools:master Jun 12, 2018
@cbornet cbornet deleted the spring-validation branch June 12, 2018 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants