Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue in swagger migration guide #150

Closed
delenius opened this issue May 25, 2018 · 6 comments
Closed

Issue in swagger migration guide #150

delenius opened this issue May 25, 2018 · 6 comments
Milestone

Comments

@delenius
Copy link
Contributor

In the swagger-codegen migration guide, there is this confusing section. I'm actually not sure what it's supposed to say, or I would submit a PR:

Renamed Mustache Template Variables
The template variable {{datatype}} was renamed to {{dataType}} for consistency reason. Corresponding java code: CodegenProperty.datatype is renamed to CodegenProperty.datatype.
@wing328
Copy link
Member

wing328 commented May 25, 2018

@delenius thanks for the feedback.

That section aims to keep our users up-to-date regarding some mustache variable renaming. If you're not using customized templates, you do not need to worry about that.

I'll add a line to explain that's for using customized templates only.

@delenius
Copy link
Contributor Author

delenius commented May 25, 2018 via email

@delenius
Copy link
Contributor Author

Oh, I see the lower vs uppercase "t" now, but only in the first case. It still says CodegenProperty.datatype twice.

@wing328
Copy link
Member

wing328 commented May 25, 2018

Good catch. I'll fix that.

@wing328
Copy link
Member

wing328 commented May 25, 2018

UPDATE: I've filed #152 to fix it.

@wing328
Copy link
Member

wing328 commented May 26, 2018

Closed via #152. Thanks again for the feedback.

@wing328 wing328 added this to the 3.0.0 milestone May 26, 2018
@wing328 wing328 closed this as completed May 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants