Skip to content

chore(OMN-10171/OMN-9906/OMN-10511): OCC contracts + evidence for omnibase_core PRs - #972

Merged
jonahgabriel merged 3 commits into
mainfrom
jonah/core-evidence-10171-9906-10511
May 13, 2026
Merged

jonahgabriel merged 3 commits into
mainfrom
jonah/core-evidence-10171-9906-10511

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented May 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Adds central OCC ticket contracts + DoD receipts for three omnibase_core PRs whose verify / verify (receipt-gate, OMN-10419) is blocked on a resolvable Evidence-Source:

Each contract carries a dod-001 evidence item bound to the downstream PR plus a dod-occ-pr-<N> self-binding receipt for this OCC PR.

Receipts land in a follow-up commit once this PR number is assigned (needed for the self-binding receipt's pr_number).

Evidence-Source: OCC#972
Evidence-Ticket: OMN-10171

OMN-10171 OMN-9906 OMN-10511

Summary by CodeRabbit

  • Chores
    • Added validation contracts for three tickets: a skill-backing-node liveness validator, runtime/CLI validation checks, and a work-tree guard enhancement.
    • Included evidence/receipt records documenting successful automated and manual verification runs for each contract (test runs and grep-based validation checks).

Review Change Stack

…ore evidence binding

Adds central ticket contracts so receipt-gate on omnibase_core PRs #1069, #1068,
#1067 can resolve Evidence-Source. Receipts added in a follow-up commit once the
OCC PR number is known (needed for the self-binding dod-occ-pr-N receipts).
@coderabbitai

coderabbitai Bot commented May 13, 2026 •

Copy link
Copy Markdown

Warning

Rate limit exceeded

@jonahgabriel has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 5 minutes and 48 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 433c7b9b-480d-4339-9fe2-af48e31707dc

📥 Commits

Reviewing files that changed from the base of the PR and between 3ab075b and dbf50ef.

📒 Files selected for processing (3)
  • contracts/OMN-10171.yaml
  • drift/dod_receipts/OMN-10171/dod-001/command.yaml
  • drift/dod_receipts/OMN-10171/dod-occ-pr-972/command.yaml
📝 Walkthrough

Walkthrough

Adds three new contract YAMLs (OMN-10171, OMN-10511, OMN-9906) and associated drift/dod_receipts command YAMLs recording PASS evidence and grep-based validations linking contracts to PR receipts.

Changes

Contract Declarations and Receipts

Layer / File(s) Summary
OMN-10171: skill-backing-node liveness validator
contracts/OMN-10171.yaml, drift/dod_receipts/OMN-10171/*
Contract for relocating the skill-backing-node liveness validator with evidence requirements (unit tests, mypy-strict disabled emergency_bypass) and DOD entries; includes PASS receipt command YAMLs recording test execution and PR linkage.
OMN-10511: run-node topic-resolution behavior
contracts/OMN-10511.yaml, drift/dod_receipts/OMN-10511/*
Contract declaring CLI unit-suite and manual runtime evidence requirements, disabled emergency_bypass, and DOD entries; includes PASS receipt command YAMLs capturing pytest runs and receipt-grep validations referencing PRs.
OMN-9906: EnumHookBit WORKTREE_GUARD addition
contracts/OMN-9906.yaml, drift/dod_receipts/OMN-9906/*
Contract adding WORKTREE_GUARD bit to EnumHookBit (bit 59) with unit-test evidence requirement and DOD entries; includes PASS receipt command YAMLs recording validation and PR receipt checks.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 New contracts tucked in a row,
YAML leaves where proofs can grow,
Tests passed loud, receipts attest,
Bits and validators take their rest,
Hops of evidence — tidy show!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: adding OCC contracts and evidence receipts for three specific tickets (OMN-10171, OMN-9906, OMN-10511) related to omnibase_core PRs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/core-evidence-10171-9906-10511

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@contracts/OMN-10171.yaml`:
- Around line 31-39: The DoD receipt still uses the placeholder OCCPRNUM; update
the id "dod-occ-pr-OCCPRNUM", the description text, the directory name in the
receipt path (drift/dod_receipts/OMN-10171/dod-occ-pr-OCCPRNUM/command.yaml) and
the pr_number check in the command grep to use the actual OCC PR number 972
(i.e., change occurrences of OCCPRNUM → 972 and ensure the grep for '^pr_number:
972$' matches the file).
- Around line 14-16: The YAML evidence item claims "validator unit tests pass
and the new module is mypy-strict clean" but the command field only runs pytest;
update the evidence by either adding a mypy check to the command (e.g., run mypy
with the strict config for the module) or change the description to only
reference tests; modify the description and/or the command fields in the YAML so
the description and the command are consistent (adjust the "description" value
or append a mypy invocation to the "command" value).

In `@contracts/OMN-10511.yaml`:
- Around line 36-44: The DoD entry still contains the placeholder OCCPRNUM;
update all occurrences of OCCPRNUM to the real OCC PR number 972 (e.g., change
the id "dod-occ-pr-OCCPRNUM" to "dod-occ-pr-972", update the description text,
the directory path
"drift/dod_receipts/OMN-10511/dod-occ-pr-OCCPRNUM/command.yaml", and the grep
expectations inside check_value to use pr_number: 972 and any quoted references
to "OCCPRNUM" to "972") so the self-binding checks point to the actual receipt
and values.

In `@contracts/OMN-9906.yaml`:
- Around line 30-38: The entry using the templated id dod-occ-pr-OCCPRNUM must
have the OCC PR number substituted everywhere before merging: update the id
value, the receipt directory path inside the command check
(drift/dod_receipts/OMN-9906/dod-occ-pr-OCCPRNUM), and the pr_number assertion
(grep -q '^pr_number: OCCPRNUM$') so they all use the actual PR number; ensure
the three grep patterns (status, ticket_id, pr_number) still match the real
command.yaml produced by the OCC PR receipt.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cb9a4c5c-9781-4fef-8816-468ee6b616fe

📥 Commits

Reviewing files that changed from the base of the PR and between dce81d6 and b439cc8.

📒 Files selected for processing (3)
  • contracts/OMN-10171.yaml
  • contracts/OMN-10511.yaml
  • contracts/OMN-9906.yaml

Comment thread contracts/OMN-10171.yaml Outdated
Comment thread contracts/OMN-10171.yaml Outdated
Comment thread contracts/OMN-10511.yaml Outdated
Comment thread contracts/OMN-9906.yaml Outdated
Replaces OCCPRNUM placeholder with this PR number (#972) and adds:
- dod-001 PASS receipts bound to omnibase_core PRs #1069, #1068, #1067 (unit
  suites verified locally against each PR head)
- dod-occ-pr-972 self-binding receipts for this OCC PR

Lets receipt-gate (OMN-10419) on the three omnibase_core PRs resolve
Evidence-Source: OCC#972.
…resh receipt hashes

Addresses CodeRabbit on OCC PR #972: OMN-10171 evidence_requirements command now
runs mypy --strict on the validator module in addition to pytest, matching the
'mypy-strict clean' description. Receipt contract_sha256 values updated to the
new contract hash.
@jonahgabriel
jonahgabriel merged commit c14919c into main May 13, 2026
28 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/core-evidence-10171-9906-10511 branch May 13, 2026 11:43
andywu42 pushed a commit to andywu42/onex_change_control that referenced this pull request Jun 10, 2026
…from core (OmniNode-ai#520)

* feat(OMN-10251): update OCC to import ModelWorkerEvidenceRequirement from core

Replaces the inline ModelEvidenceRequirement class in overseer/model_worker_contract.py
with re-exports from omnibase_core.models.overseer. Keeps ModelEvidenceRequirement
as a backward-compat alias pointing to ModelWorkerEvidenceRequirement.
Bumps omnibase_core pin to 532d62ae (the OMN-10251 migration commit).

* test(OMN-10251): expect core worker contract error

* chore(OMN-10251): add ticket contract and DoD receipts for overseer models migration

Adds contracts/OMN-10251.yaml and four dod_receipts entries proving:
- overseer namespace __init__.py present in omnibase_core
- 23 TDD unit tests pass
- mypy --strict clean on overseer models
- pre-commit all hooks pass

Required by the receipt gate on omnibase_core PR OmniNode-ai#972.

* docs(OMN-10251): update overseer runtime dependency note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant