[jonahgabriel]

Summary

• Removes the inline ModelEvidenceRequirement class from overseer/model_worker_contract.py (176 lines removed)
• Replaces with re-exports from omnibase_core.models.overseer (migrated in omnibase_core#972)
• Keeps ModelEvidenceRequirement = ModelWorkerEvidenceRequirement alias for backward compatibility
• Bumps omnibase_core pin to 532d62ae (the OMN-10251 migration commit on omnibase_core)

Sibling PR

omnibase_core#972 — must merge first (OCC pin points to that branch commit)

Verification

• 575/575 unit tests pass
• mypy clean (push hook confirmed)
• pre-commit all hooks pass

Ticket

OMN-10251

dod_evidence

{
  "type": "test_run",
  "result": "575/575 passed",
  "artifacts": ["tests/unit/"]
}

Summary by CodeRabbit

• Dependencies

  • Updated core library dependency source to a new pinned revision.

• Refactor

  • Consolidated model definitions to use authoritative core library implementations.
  • Updated exported types and aliases for improved API consistency.

• Tests

  • Adjusted unit test expectations to assert the updated error type and message.

[coderabbitai]

Warning

Rate limit exceeded

@jonahgabriel has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 5 minutes and 29 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f0c52175-bd3c-488e-b912-bcf3b5b69b9b

📥 Commits

Reviewing files that changed from the base of the PR and between 5178491 and 225862d.

📒 Files selected for processing (6)

• contracts/OMN-10251.yaml
• drift/dod_receipts/OMN-10251/dod-001/command.yaml
• drift/dod_receipts/OMN-10251/dod-002/command.yaml
• drift/dod_receipts/OMN-10251/dod-003/command.yaml
• drift/dod_receipts/OMN-10251/dod-004/command.yaml
• src/onex_change_control/overseer/__init__.py

📝 Walkthrough

Walkthrough

Imports and exports for overseer model types were consolidated to use authoritative implementations from omnibase_core; the omnibase-core Git source pin in pyproject.toml was updated, and the package initializer now re-exports ModelWorkerEvidenceRequirement.

Changes

Cohort / File(s)	Summary
Dependency Update pyproject.toml	Bumped tool.uv.sources pin for omnibase-core from commit 2ddc09710d95... to 532d62aedd9e....
Model Consolidation & Exports src/onex_change_control/overseer/model_worker_contract.py, src/onex_change_control/overseer/__init__.py	Replaced local Pydantic models with imports from omnibase_core (ModelWorkerContract, load_worker_contract); added alias/export for ModelWorkerEvidenceRequirement; updated __all__ and re-exports to expose the new name.
Tests tests/overseer/test_cr_findings_157.py	Adjusted test to expect ModelOnexError with a specific message when load_worker_contract receives a non-mapping input (changed from expecting TypeError).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 I hopped through code with nimble paws,
Exports folded into wiser laws,
One pin moved, one import grown,
Cleaned the burrow, kept it known—
A tiny hop, a tidy home. ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: importing ModelWorkerEvidenceRequirement from omnibase_core and updating the OCC codebase accordingly.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch jonah/omn-10251-occ-sibling

---

_{Review rate limit: 0/5 reviews remaining, refill in 5 minutes and 29 seconds.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/onex_change_control/overseer/__init__.py`:
- Around line 78-83: The module docstring in overseer.__init__ incorrectly
claims "Zero upstream runtime deps." but the added import from
onex_change_control.overseer.model_worker_contract (ModelEvidenceRequirement,
ModelWorkerContract, ModelWorkerEvidenceRequirement, load_worker_contract)
introduces a transitive runtime dependency; update the top-of-file docstring to
remove or reword that claim (e.g., state that there are upstream runtime model
dependencies or list them) so the docstring accurately reflects the presence of
model_worker_contract and load_worker_contract as runtime dependencies.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d5e09f10-b9d3-4541-8a70-0d541e827432

📥 Commits

Reviewing files that changed from the base of the PR and between bd66d37 and 816eedc.

⛔ Files ignored due to path filters (1)

• uv.lock is excluded by !**/*.lock

📒 Files selected for processing (3)

• pyproject.toml
• src/onex_change_control/overseer/__init__.py
• src/onex_change_control/overseer/model_worker_contract.py