Repository navigation
chore(OMN-10492): add OCC contract binding omniclaude PR #1571 - #974
Merged
Merged
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughPR adds/updates three contract YAMLs (OMN-10171, OMN-10492, OMN-9906) and multiple drift DOD command receipts that record PASS checks, probe commands/stdout, PR numbers, and run metadata. ChangesSeam Tickets Definition and Evidence
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@contracts/OMN-9906.yaml`:
- Around line 26-34: The dod-001 entry claims migration of ONEX_WORKTREE_GUARD
and ONEX_TEAM_LEAD_GUARD_DISABLE but the checks only verify onex_hook_gate
WORKTREE_GUARD; add a second command check to the checks array that mirrors the
existing command (using TARGET_PR=1572; gh pr diff ${TARGET_PR} --repo
OmniNode-ai/omniclaude | grep -q 'onex_hook_gate TEAM_LEAD_GUARD' or the exact
internal token name for TEAM_LEAD_GUARD_DISABLE) so both ONEX_WORKTREE_GUARD and
ONEX_TEAM_LEAD_GUARD_DISABLE are asserted by checks for id dod-001.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: e1531587-276e-4c65-bbd0-19bd6913f27a
📒 Files selected for processing (9)
contracts/OMN-10171.yamlcontracts/OMN-10492.yamlcontracts/OMN-9906.yamldrift/dod_receipts/OMN-10171/dod-001/command.yamldrift/dod_receipts/OMN-10171/dod-occ-pr/command.yamldrift/dod_receipts/OMN-10492/dod-001/command.yamldrift/dod_receipts/OMN-10492/dod-occ-pr/command.yamldrift/dod_receipts/OMN-9906/dod-001/command.yamldrift/dod_receipts/OMN-9906/dod-occ-pr/command.yaml
- contracts/OMN-10492.yaml — binds delivery PR omniclaude#1571 (replace raw Postgres probe with runtime HTTP health check in check_database_health) - drift/dod_receipts/OMN-10492/dod-001/command.yaml — receipt bound to PR #1571 Delivery PR: OmniNode-ai/omniclaude#1571
…1572, #1573 - contracts/OMN-9906.yaml + dod-001 receipt bound to omniclaude#1572 - contracts/OMN-10171.yaml + dod-001 receipt bound to omniclaude#1573 Delivery PRs: - OmniNode-ai/omniclaude#1572 - OmniNode-ai/omniclaude#1573
jonahgabriel
force-pushed
the
jonah/omn-occ-bind-overnight
branch
from
May 13, 2026 12:07
e7f1553 to
163431a
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
drift/dod_receipts/OMN-10171/dod-occ-pr-974/command.yaml (1)
6-7: ⚡ Quick winMake
check_valuedeterministic by hardcoding PR974.Using
${PR_NUMBER}makes the receipt environment-dependent and less tightly bound to Line 18 (pr_number: 974).Proposed fix
-check_value: "gh pr view ${PR_NUMBER} --repo OmniNode-ai/onex_change_control --json state -q '.state' +check_value: "gh pr view 974 --repo OmniNode-ai/onex_change_control --json state -q '.state' | grep -q OPEN"🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@drift/dod_receipts/OMN-10171/dod-occ-pr-974/command.yaml` around lines 6 - 7, The check_value uses a variable (${PR_NUMBER}) making the command non-deterministic; update the check_value string to hardcode the pull request number 974 so it matches the pr_number: 974 field — locate the check_value entry and replace the ${PR_NUMBER} interpolation with 974 (i.e., reference the check_value key and ensure it exactly uses "gh pr view 974 --repo OmniNode-ai/onex_change_control --json state -q '.state' | grep -q OPEN").
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@contracts/OMN-9906.yaml`:
- Around line 45-46: Update the check_value for the dod-omniclaude-pr-1572
receipt to also assert the ticket_id field: modify the existing check_value
string for receipt "dod-omniclaude-pr-1572" to include an additional grep that
matches the exact ticket_id line (grep -q '^ticket_id: <EXPECTED_TICKET_ID>$'
drift/dod_receipts/OMN-9906/dod-omniclaude-pr-1572/command.yaml), keeping it
combined with the existing status and pr_number checks so all three fields are
validated together.
In `@drift/dod_receipts/OMN-10171/dod-omniclaude-pr-1573/command.yaml`:
- Line 9: Update the commit_sha value in command.yaml: replace the current
commit_sha value "eea532f64c6de238c9d99fc10986418bfaaac279" with the PR head
commit "06f7d5b2dd1ad94eb0f41c8bd3f73692042bbec6" so the commit_sha key reflects
the current head of omniclaude PR `#1573` and preserves provenance.
---
Nitpick comments:
In `@drift/dod_receipts/OMN-10171/dod-occ-pr-974/command.yaml`:
- Around line 6-7: The check_value uses a variable (${PR_NUMBER}) making the
command non-deterministic; update the check_value string to hardcode the pull
request number 974 so it matches the pr_number: 974 field — locate the
check_value entry and replace the ${PR_NUMBER} interpolation with 974 (i.e.,
reference the check_value key and ensure it exactly uses "gh pr view 974 --repo
OmniNode-ai/onex_change_control --json state -q '.state' | grep -q OPEN").
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 9a402352-3b47-45a8-af4d-c9f42d06c7eb
📒 Files selected for processing (11)
contracts/OMN-10171.yamlcontracts/OMN-10492.yamlcontracts/OMN-9906.yamldrift/dod_receipts/OMN-10171/dod-occ-pr-974/command.yamldrift/dod_receipts/OMN-10171/dod-occ-pr/command.yamldrift/dod_receipts/OMN-10171/dod-omniclaude-pr-1573/command.yamldrift/dod_receipts/OMN-10492/dod-001/command.yamldrift/dod_receipts/OMN-10492/dod-occ-pr/command.yamldrift/dod_receipts/OMN-9906/dod-occ-pr-974/command.yamldrift/dod_receipts/OMN-9906/dod-occ-pr/command.yamldrift/dod_receipts/OMN-9906/dod-omniclaude-pr-1572/command.yaml
✅ Files skipped from review due to trivial changes (4)
- drift/dod_receipts/OMN-10171/dod-occ-pr/command.yaml
- drift/dod_receipts/OMN-9906/dod-omniclaude-pr-1572/command.yaml
- drift/dod_receipts/OMN-10492/dod-001/command.yaml
- drift/dod_receipts/OMN-10492/dod-occ-pr/command.yaml
🚧 Files skipped from review as they are similar to previous changes (2)
- contracts/OMN-10492.yaml
- drift/dod_receipts/OMN-9906/dod-occ-pr/command.yaml
jonahgabriel
force-pushed
the
jonah/omn-occ-bind-overnight
branch
2 times, most recently
from
May 13, 2026 12:16
68999e8 to
69a3fdd
Compare
jonahgabriel
force-pushed
the
jonah/omn-occ-bind-overnight
branch
from
May 13, 2026 12:18
69a3fdd to
ccd7b9d
Compare
This was referenced May 13, 2026
This was referenced May 28, 2026
andywu42
pushed a commit
to andywu42/onex_change_control
that referenced
this pull request
Jun 10, 2026
…tch B (OmniNode-ai#522) Adds contract and 4 DoD evidence receipts for OMN-10246 (Task 6 of OMN-9582 Wave 3): 11 governance models (autopilot, compliance, eval) migrated into omnibase_core PR OmniNode-ai#974. Receipts cover: TDD tests green, mypy strict clean, pre-commit pass, PR open against main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Binds three omniclaude delivery PRs to OCC contracts with PASS receipts.
contracts/OMN-10492.yaml+dod-001receipt → omniclaude#1571 (replace raw Postgres probe with runtime HTTP health check)contracts/OMN-9906.yaml+dod-001receipt → omniclaude#1572 (migrate ONEX_WORKTREE_GUARD + ONEX_TEAM_LEAD_GUARD_DISABLE to ONEX_HOOKS_MASK)contracts/OMN-10171.yaml+dod-001receipt → omniclaude#1573 (replace validate_skill_backing_node with omnibase_core shim, SEAM-2)dod-occ-prreceipts for OCC#974 under each ticketDelivery PRs
Tickets
OMN-10492, OMN-9906, OMN-10171
Evidence-Source: OCC#974
Evidence-Ticket: OMN-10492
Summary by CodeRabbit