Skip to content

feat(OMN-7836): contract + receipts for delegation dashboard fix - #611

Merged
jonahgabriel merged 4 commits into
mainfrom
jonah/occ-7836-dash-fix
May 1, 2026
Merged

jonahgabriel merged 4 commits into
mainfrom
jonah/occ-7836-dash-fix

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented May 1, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Adds OCC contract and DoD receipts for OMN-7836 delegation dashboard evidence.
  • Tightens OMN-7836 contract checks to validate canonical OCC receipts for byModel, qualityGatePassed, qualityGateTotal, 13 passing tests, lint, and typecheck.
  • Carries forward OMN-10420 receipt-evidence hardening from PR feat(OMN-10420): contract + receipts for ticket-identity binding #606 so this branch does not regress newer central evidence.

Related code PR: OmniNode-ai/omnidash#61

Evidence-Source: jonah/occ-7836-dash-fix
Evidence-Ticket: OMN-7836

Verification

  • uv run validate-yaml contracts/OMN-7836.yaml contracts/OMN-10420.yaml
  • ModelDodReceipt.model_validate(...) for all OMN-7836 and OMN-10420 receipt YAML files

Pairs with omnibase_core PR implementing I3 invariant: OCC evidence
must provably belong to the same ticket as the code PR.

Receipts verify:
  - dod-001: 9 identity-binding tests pass (5 required plan cases)
  - dod-002: 68 existing receipt_gate tests pass (no regressions)
  - dod-003: EVIDENCE_SOURCE/TICKET_PATTERN exported in __all__
  - dod-004: CLI accepts --evidence-ticket and --branch-name flags
@coderabbitai

coderabbitai Bot commented May 1, 2026 •

Copy link
Copy Markdown

Warning

Rate limit exceeded

@jonahgabriel has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 7 minutes and 36 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: af38d324-d70d-496d-bbbf-084176fca80b

📥 Commits

Reviewing files that changed from the base of the PR and between 8bdd0c7 and e6aac1c.

📒 Files selected for processing (7)
  • contracts/OMN-10420.yaml
  • contracts/OMN-7836.yaml
  • drift/dod_receipts/OMN-10420/dod-001/command.yaml
  • drift/dod_receipts/OMN-10420/dod-002/command.yaml
  • drift/dod_receipts/OMN-10420/dod-003/command.yaml
  • drift/dod_receipts/OMN-10420/dod-004/command.yaml
  • drift/dod_receipts/OMN-7836/dod-001/command.yaml
📝 Walkthrough

Walkthrough

This pull request adds a new contract manifest for OMN-10420 documenting receipt-gate identity-binding changes and updates the OMN-7836 manifest for omnidash delegation components. Seven DOD evidence receipt files record test execution results, code verification checks, and CLI validation outcomes for both tickets.

Changes

Cohort / File(s) Summary
Contract Manifests
contracts/OMN-10420.yaml, contracts/OMN-7836.yaml
New manifest for OMN-10420 specifies identity-binding unit tests and CLI evidence requirements. OMN-7836 manifest updated with omnidash-specific verification steps replacing generic PR checks, emphasizing byModel and qualityGatePassed field validation plus test suite and lint/typecheck passes.
OMN-10420 DOD Evidence Receipts
drift/dod_receipts/OMN-10420/dod-00[1-4]/command.yaml
Four receipt files recording command executions: dod-001 validates identity-binding failure cases (9 passed), dod-002 confirms receipt-gate test suite results (68 passed), dod-003 verifies exported constant presence, dod-004 confirms CLI help flags presence.
OMN-7836 DOD Evidence Receipts
drift/dod_receipts/OMN-7836/dod-00[1-3]/command.yaml
Three receipt files documenting verification outcomes: dod-001 confirms byModel and qualityGatePassed presence in delegation components, dod-002 records delegation test suite passing (13/13), dod-003 verifies clean lint and typecheck execution.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 twitches nose at evidence scrolls
Four tests run green, receipts all sealed,
Identity-binding truth revealed,
Delegation charts with metrics fair,
Contract proof fills the air! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately describes the main changes: it references the ticket (OMN-7836) and summarizes the primary objective (contract + receipts for delegation dashboard fix). The title is clear, concise, and directly relates to the primary changeset.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/occ-7836-dash-fix

Review rate limit: 0/5 reviews remaining, refill in 7 minutes and 36 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@contracts/OMN-10420.yaml`:
- Around line 45-47: The current check only ensures EVIDENCE_SOURCE_PATTERN and
EVIDENCE_TICKET_PATTERN are importable from
omnibase_core.validation.receipt_gate; update the validation command to import
the module object (import omnibase_core.validation.receipt_gate as m) and assert
that both "EVIDENCE_SOURCE_PATTERN" and "EVIDENCE_TICKET_PATTERN" are present in
getattr(m, "__all__", []) (and exit non‑zero if not). Change the check_value to
run a python -c snippet that imports the module, checks membership in m.__all__,
and prints ok / raises SystemExit(1) on failure so the DoD requirement for
__all__ export membership is enforced.
- Around line 53-54: The current check_value uses a single grep with an OR
pattern so it can pass if only one flag appears; update the check_value shell
command (the line containing "python -m
omnibase_core.validation.receipt_gate_cli --help | grep -E
'evidence-ticket|branch-name'") to require both flags, e.g., by running two
greps (or grep -q twice) chained with && so the check only succeeds if both
"evidence-ticket" and "branch-name" are present in the help output.

In `@contracts/OMN-7836.yaml`:
- Around line 24-30: The DoD check for id dod-001 currently asserts presence of
byModel and qualityGatePassed but omits qualityGateTotal; update the check under
dod-001 (check_type: command, check_value) to include a grep for
"qualityGateTotal" in
omnidash/src/components/dashboard/delegation/DelegationMetrics3D.tsx so the
command verifies byModel, qualityGatePassed and qualityGateTotal (i.e., extend
the existing check_value to include a third grep for qualityGateTotal).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 064bfb2f-b92f-4de3-9f57-97e03e7970c5

📥 Commits

Reviewing files that changed from the base of the PR and between 64f35cc and 8bdd0c7.

📒 Files selected for processing (9)
  • contracts/OMN-10420.yaml
  • contracts/OMN-7836.yaml
  • drift/dod_receipts/OMN-10420/dod-001/command.yaml
  • drift/dod_receipts/OMN-10420/dod-002/command.yaml
  • drift/dod_receipts/OMN-10420/dod-003/command.yaml
  • drift/dod_receipts/OMN-10420/dod-004/command.yaml
  • drift/dod_receipts/OMN-7836/dod-001/command.yaml
  • drift/dod_receipts/OMN-7836/dod-002/command.yaml
  • drift/dod_receipts/OMN-7836/dod-003/command.yaml

Comment thread contracts/OMN-10420.yaml Outdated
Comment thread contracts/OMN-10420.yaml Outdated
Comment thread contracts/OMN-7836.yaml Outdated
@github-actions
github-actions Bot enabled auto-merge May 1, 2026 16:27
@jonahgabriel jonahgabriel changed the title feat(OCC-7836): contract + receipts for delegation dashboard fix feat(OMN-7836): contract + receipts for delegation dashboard fix May 1, 2026
@jonahgabriel
jonahgabriel added this pull request to the merge queue May 1, 2026
Merged via the queue into main with commit f5f608e May 1, 2026
26 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/occ-7836-dash-fix branch May 1, 2026 17:51
jonahgabriel added a commit that referenced this pull request May 13, 2026
jonahgabriel added a commit that referenced this pull request May 13, 2026
…t PR #611 (#973)

* contract(OMN-10747): add OCC contract + deploy receipts for omnimarket PR #611

NodeOverseerBenchmarker DI injection — constructor-signature-only change in an
offline benchmarking node. Adds contracts/OMN-10747.yaml with dod-unit-tests,
dod-deploy (no-op: no handler routing change, no migration, no topology change),
and dod-occ-pr self-binding evidence. Receipts record 2273-test unit suite pass
and the deploy no-op rationale.

Evidence-Ticket: OMN-10747
Evidence-Source: OCC#968

* contract(OMN-10747): fix receipt contract_sha256 to match yamlfmt-normalized contract

* contract(OMN-10747): fill dod-occ-pr receipt with valid commit_sha + pr_number 973

* contract(OMN-10747): point receipt commit_sha at omnimarket PR #611 head (CodeRabbit)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant