Repository navigation
feat(OMN-7836): contract + receipts for delegation dashboard fix - #611
Conversation
Pairs with omnibase_core PR implementing I3 invariant: OCC evidence must provably belong to the same ticket as the code PR. Receipts verify: - dod-001: 9 identity-binding tests pass (5 required plan cases) - dod-002: 68 existing receipt_gate tests pass (no regressions) - dod-003: EVIDENCE_SOURCE/TICKET_PATTERN exported in __all__ - dod-004: CLI accepts --evidence-ticket and --branch-name flags
…mes + quality gate fix
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughThis pull request adds a new contract manifest for OMN-10420 documenting receipt-gate identity-binding changes and updates the OMN-7836 manifest for omnidash delegation components. Seven DOD evidence receipt files record test execution results, code verification checks, and CLI validation outcomes for both tickets. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Review rate limit: 0/5 reviews remaining, refill in 7 minutes and 36 seconds. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@contracts/OMN-10420.yaml`:
- Around line 45-47: The current check only ensures EVIDENCE_SOURCE_PATTERN and
EVIDENCE_TICKET_PATTERN are importable from
omnibase_core.validation.receipt_gate; update the validation command to import
the module object (import omnibase_core.validation.receipt_gate as m) and assert
that both "EVIDENCE_SOURCE_PATTERN" and "EVIDENCE_TICKET_PATTERN" are present in
getattr(m, "__all__", []) (and exit non‑zero if not). Change the check_value to
run a python -c snippet that imports the module, checks membership in m.__all__,
and prints ok / raises SystemExit(1) on failure so the DoD requirement for
__all__ export membership is enforced.
- Around line 53-54: The current check_value uses a single grep with an OR
pattern so it can pass if only one flag appears; update the check_value shell
command (the line containing "python -m
omnibase_core.validation.receipt_gate_cli --help | grep -E
'evidence-ticket|branch-name'") to require both flags, e.g., by running two
greps (or grep -q twice) chained with && so the check only succeeds if both
"evidence-ticket" and "branch-name" are present in the help output.
In `@contracts/OMN-7836.yaml`:
- Around line 24-30: The DoD check for id dod-001 currently asserts presence of
byModel and qualityGatePassed but omits qualityGateTotal; update the check under
dod-001 (check_type: command, check_value) to include a grep for
"qualityGateTotal" in
omnidash/src/components/dashboard/delegation/DelegationMetrics3D.tsx so the
command verifies byModel, qualityGatePassed and qualityGateTotal (i.e., extend
the existing check_value to include a third grep for qualityGateTotal).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 064bfb2f-b92f-4de3-9f57-97e03e7970c5
📒 Files selected for processing (9)
contracts/OMN-10420.yamlcontracts/OMN-7836.yamldrift/dod_receipts/OMN-10420/dod-001/command.yamldrift/dod_receipts/OMN-10420/dod-002/command.yamldrift/dod_receipts/OMN-10420/dod-003/command.yamldrift/dod_receipts/OMN-10420/dod-004/command.yamldrift/dod_receipts/OMN-7836/dod-001/command.yamldrift/dod_receipts/OMN-7836/dod-002/command.yamldrift/dod_receipts/OMN-7836/dod-003/command.yaml
…t PR #611 (#973) * contract(OMN-10747): add OCC contract + deploy receipts for omnimarket PR #611 NodeOverseerBenchmarker DI injection — constructor-signature-only change in an offline benchmarking node. Adds contracts/OMN-10747.yaml with dod-unit-tests, dod-deploy (no-op: no handler routing change, no migration, no topology change), and dod-occ-pr self-binding evidence. Receipts record 2273-test unit suite pass and the deploy no-op rationale. Evidence-Ticket: OMN-10747 Evidence-Source: OCC#968 * contract(OMN-10747): fix receipt contract_sha256 to match yamlfmt-normalized contract * contract(OMN-10747): fill dod-occ-pr receipt with valid commit_sha + pr_number 973 * contract(OMN-10747): point receipt commit_sha at omnimarket PR #611 head (CodeRabbit)
Summary
Related code PR: OmniNode-ai/omnidash#61
Evidence-Source: jonah/occ-7836-dash-fix
Evidence-Ticket: OMN-7836
Verification
uv run validate-yaml contracts/OMN-7836.yaml contracts/OMN-10420.yamlModelDodReceipt.model_validate(...)for all OMN-7836 and OMN-10420 receipt YAML files