Repository navigation
feat(OMN-10420): contract + receipts for ticket-identity binding - #606
Conversation
Pairs with omnibase_core PR implementing I3 invariant: OCC evidence must provably belong to the same ticket as the code PR. Receipts verify: - dod-001: 9 identity-binding tests pass (5 required plan cases) - dod-002: 68 existing receipt_gate tests pass (no regressions) - dod-003: EVIDENCE_SOURCE/TICKET_PATTERN exported in __all__ - dod-004: CLI accepts --evidence-ticket and --branch-name flags
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
✅ Files skipped from review due to trivial changes (4)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds a contract for OMN-10420 declaring ticket‑identity binding enforcement in receipt_gate.py and four DoD evidence records documenting required CI checks: unit tests for identity binding, broader receipt_gate test suite, exported constant presence, and CLI help showing required flags. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Review rate limit: 0/5 reviews remaining, refill in 58 minutes and 50 seconds. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@contracts/OMN-10420.yaml`:
- Around line 41-47: The current check only verifies those names are importable;
update the command check to assert that EVIDENCE_SOURCE_PATTERN and
EVIDENCE_TICKET_PATTERN are present in the module's __all__ instead: load
omnibase_core.validation.receipt_gate, then inspect its __all__ attribute and
fail unless both "EVIDENCE_SOURCE_PATTERN" and "EVIDENCE_TICKET_PATTERN" are
listed; reference the module name omnibase_core.validation.receipt_gate and the
symbols EVIDENCE_SOURCE_PATTERN and EVIDENCE_TICKET_PATTERN so the check
enforces explicit export membership rather than mere importability.
- Around line 49-54: The check currently uses a single grep with alternation
which passes if either flag exists; update the check_value in
contracts/OMN-10420.yaml so the CLI help is tested for both flags (e.g., run the
help command twice or capture output once and test both patterns): replace the
single pipe to grep -E 'evidence-ticket|branch-name' with a command that ensures
both are present, such as `python -m omnibase_core.validation.receipt_gate_cli
--help | grep -E 'evidence-ticket' && python -m
omnibase_core.validation.receipt_gate_cli --help | grep -E 'branch-name'` (or
capture output once and run two greps), so the check verifies presence of both
--evidence-ticket and --branch-name.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: ab9d4ca0-6966-42fd-bb9b-2f307909dc15
📒 Files selected for processing (5)
contracts/OMN-10420.yamldrift/dod_receipts/OMN-10420/dod-001/command.yamldrift/dod_receipts/OMN-10420/dod-002/command.yamldrift/dod_receipts/OMN-10420/dod-003/command.yamldrift/dod_receipts/OMN-10420/dod-004/command.yaml
…upstream PR receipts Set commit_sha to 5a3dd07b (omnimarket PR #606 head SHA) in all receipts that document omnimarket evidence. Previously had the OCC branch SHA which misrepresents the provenance of the upstream evidence.
…idence for canary→routing feedback loop (#942) * contract(OMN-10846,OMN-10847,OMN-10848): add OCC contracts and DoD evidence for canary→routing feedback loop tickets All three tickets delivered via PR #606 on OmniNode-ai/omnimarket (merge commit 1af2f16a1c7d10a1f9392288f6cd63a8a1473957). PRs #604 and #605 were closed as superseded after cherry-pick into #606. - OMN-10846: build_available_models_from_scores() bridge (capability_scores → routing policy) - OMN-10847: ModelMaterializeResult + routing_outcomes.quality_score population - OMN-10848: Proof-of-life integration test (canary → scores → routing, pure in-memory) * fix(OMN-10846,OMN-10847,OMN-10848): add dod-occ-pr receipts and all evidence receipts for verify gate - Add dod-occ-pr evidence item to OMN-10846, OMN-10847, OMN-10848 contracts - Create drift/dod_receipts YAML for all dod_evidence items across all three tickets - Fix dod-no-handler-modification check_value to use grep '^+.*def' prefix - Fix dod-quality-score-nonzero check_value to assert quality_score > 0.0 - Address CodeRabbit threads on evidence description mismatches * fix(OMN-10846,OMN-10847,OMN-10848): replace hardcoded gh pr diff 606 with receipt-check pattern Switch dod_evidence check_values from inline `gh pr diff 606 -R omnimarket` commands to `grep -q '^status: PASS$' "$CONTRACT_REPO_DIR/drift/dod_receipts/...` to comply with the legacy-gh-pr lint rule (OMN-9350) that forbids hardcoded PR numbers in gh pr commands. * fix(OMN-10846,OMN-10847,OMN-10848): correct commit_sha provenance in upstream PR receipts Set commit_sha to 5a3dd07b (omnimarket PR #606 head SHA) in all receipts that document omnimarket evidence. Previously had the OCC branch SHA which misrepresents the provenance of the upstream evidence. * fix(OMN-10848): tighten quality-score probe to require > 0.0 match only Remove the loose |assert.*quality_score fallback from the probe regex. The actual diff output confirms quality_score.*>.*0.0 matches directly, so the tighter form is both accurate and avoids false-positive via None-check. * fix(OMN-10846): align dod-no-handler-modification description with receipt-check approach The description previously said "diff shows only X added" but the check reads a receipt file — mismatched claim/verification. Updated to say "verified via receipt" to match the actual check pattern.
Summary
contracts/OMN-10420.yamlwith 4 DoD evidence items for the ticket-identity binding featuredrift/dod_receipts/OMN-10420/for all 4 itemsOMN-10420
Evidence-Source: jonah/omn-10420-ticket-identity-binding
Evidence-Ticket: OMN-10420
Test plan
Summary by CodeRabbit
New Features
Tests
Chores