contract(OMN-10747): add OCC contract + deploy receipts for omnimarket PR #611

[jonahgabriel]

Summary

• Adds contracts/OMN-10747.yaml — ticket contract for the NodeOverseerBenchmarker DI-injection PR (omnimarket feat(OMN-7836): contract + receipts for delegation dashboard fix #611)
• Adds drift/dod_receipts/OMN-10747/{dod-unit-tests,dod-deploy,dod-occ-pr}/command.yaml PASS receipts
• dod-deploy evidence confirms the change is a constructor-signature addition only (new optional harness param, default-None preserves prior behavior) — no handler routing change, no migration, no new runtime service, no Kafka topic change, no restart required

Ticket

OMN-10747

dod_evidence

ticket: OMN-10747
type: contract_schema
proof: contracts/OMN-10747.yaml — dod-deploy receipt records the deploy no-op rationale; dod-unit-tests receipt records the 2273-test omnimarket unit suite pass

Evidence-Ticket: OMN-10747
Evidence-Source: OCC#968

Summary by CodeRabbit

• Chores
  • Added a Definition-of-DoD contract entry to track acceptance evidence.
  • Added evidence receipts recording deployment verification, PR status checks, and unit-test execution results to support internal acceptance and QA.
  • Captured run metadata, command outputs, PASS statuses, and checksums for traceability.

[coderabbitai]

Warning

Rate limit exceeded

@jonahgabriel has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 3 minutes and 42 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d5db872c-13eb-452a-8f69-445c765b681e

📥 Commits

Reviewing files that changed from the base of the PR and between 86b31d8 and c71536d.

📒 Files selected for processing (3)

• drift/dod_receipts/OMN-10747/dod-deploy/command.yaml
• drift/dod_receipts/OMN-10747/dod-occ-pr/command.yaml
• drift/dod_receipts/OMN-10747/dod-unit-tests/command.yaml

📝 Walkthrough

Walkthrough

Adds an OCC "definition of done" contract for OMN-10747 and three new drift evidence receipt YAML files documenting PASS status for unit tests, deployment, and PR validation.

Changes

OMN-10747 Definition of Done Contract

Layer / File(s)	Summary
Contract Specification contracts/OMN-10747.yaml	Defines the contract header, ticket metadata, and three dod_evidence entries (dod-unit-tests, dod-deploy, dod-occ-pr) with command-based PASS assertions. Marks is_seam_ticket: false and disables emergency_bypass.
Evidence Receipts drift/dod_receipts/OMN-10747/dod-deploy/command.yaml, drift/dod_receipts/OMN-10747/dod-occ-pr/command.yaml, drift/dod_receipts/OMN-10747/dod-unit-tests/command.yaml	Three YAML command receipts documenting PASS status: deploy validates constructor-only signature change, occ-pr records PR state check via GitHub CLI, and unit-tests records pytest run outputs, timestamps, and commit SHA.

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 In YAML rows I hop and write,
Dod entries tidy, checks all bright.
Deploy, PR, and tests attest,
Three PASS receipts — the contract's blessed.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically summarizes the main change: adding an OCC contract and deploy receipts for ticket OMN-10747 related to omnimarket PR #611. It is concise, descriptive, and directly reflects the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch jonah/omn-10747-occ-contract

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@drift/dod_receipts/OMN-10747/dod-deploy/command.yaml`:
- Line 10: Replace the incorrect commit SHA value set for commit_sha with the
actual head SHA for omnimarket PR `#611`: change the value currently set to
2d693eb6c4e3e40b08047595c2f06db2a05ccdec to
303c27ad1b4761056b888cc187cca0e2cfb52bd7 so the commit_sha field matches the PR
head.

In `@drift/dod_receipts/OMN-10747/dod-occ-pr/command.yaml`:
- Line 10: The file contains a placeholder value PENDING_OCC_HEAD for commit_sha
(and also in probe_stdout) which must be replaced with the actual OCC PR head
commit SHA; run git rev-parse HEAD to obtain the 40-character SHA and update the
commit_sha field and the probe_stdout entry to that SHA (replace the literal
PENDING_OCC_HEAD occurrences), ensuring the commit_sha and probe_stdout values
now reference the real commit SHA.
- Line 19: The pr_number field in the self-binding receipt is incorrect
(currently set to 0); update the pr_number entry in command.yaml to the correct
OCC PR number 973 so the receipt references this pull request (look for the
pr_number key in the command.yaml content and replace 0 with 973).

In `@drift/dod_receipts/OMN-10747/dod-unit-tests/command.yaml`:
- Line 9: The commit_sha field in command.yaml is incorrect for omnimarket PR
`#611`; update the commit_sha value (the commit_sha key in command.yaml) from
2d693eb6c4e3e40b08047595c2f06db2a05ccdec to the actual head commit
303c27ad1b4761056b888cc187cca0e2cfb52bd7 so the cross-repo receipt references
the correct head of PR `#611`; make the single-line replacement for the commit_sha
value and verify the file now contains the exact SHA
303c27ad1b4761056b888cc187cca0e2cfb52bd7.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e123fcd3-a830-4bbc-8d86-1bc1cc7de763

📥 Commits

Reviewing files that changed from the base of the PR and between dce81d6 and f69fd07.

📒 Files selected for processing (4)

• contracts/OMN-10747.yaml
• drift/dod_receipts/OMN-10747/dod-deploy/command.yaml
• drift/dod_receipts/OMN-10747/dod-occ-pr/command.yaml
• drift/dod_receipts/OMN-10747/dod-unit-tests/command.yaml