Repository navigation
evidence(OMN-14001): OCC companion for omnimarket #1629 ROI routing - #3642
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 13 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughAdds an OCC contract file ChangesOMN-14001 contract and evidence receipts
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@drift/dod_receipts/OMN-14001/dod-deploy-scope/command.yaml`:
- Line 12: The probe_command value is currently descriptive text instead of a
runnable shell command, so update the command in the OMN-14001 scope receipt to
be valid executable syntax like the other receipts. Replace the non-executable
content in probe_command with the actual command used for verification, keeping
it as a single shell command and avoiding embedded parenthetical notes or
trailing prose.
- Line 9: The receipt is pointing at the wrong commit SHA, so update the
commit_sha in the command.yaml entry to match PR 1629’s head commit used by the
attestation. Use the existing commit_sha field in this receipt, and if the
receipt is intentionally for an intermediate probe instead of the final PR
state, add an explicit note clarifying that rather than leaving the head
mismatch unresolved.
In `@drift/dod_receipts/OMN-14001/dod-occ-self/command.yaml`:
- Around line 6-7: The self-binding verification in the receipt command is
incomplete because it does not include the new dod-deploy-scope artifact. Update
the command YAML for the OMN-14001 self-check so the check_value explicitly
validates the presence of
drift/dod_receipts/OMN-14001/dod-deploy-scope/command.yaml alongside the
existing contract and other receipt files, and make sure the probe_stdout
output/listing in the same receipt also includes that file. This keeps the
evidence check aligned with the full set of artifacts produced by the PR.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 1f161f40-4778-4252-9d50-b8a3d7b60978
📒 Files selected for processing (5)
contracts/OMN-14001.yamldrift/dod_receipts/OMN-14001/dod-deploy-scope/command.yamldrift/dod_receipts/OMN-14001/dod-learning-loop-proof/command.yamldrift/dod_receipts/OMN-14001/dod-occ-self/command.yamldrift/dod_receipts/OMN-14001/dod-omnimarket-pr-1629/command.yaml
247494a to
6e5ac4a
Compare
…ce validator (#4426) * feat(OMN-14051): reject non-hermetic check_value in contract-compliance validator Fold a non-hermetic check_value guard into the existing contract-compliance engine (onex_change_control.scripts.contract_compliance_check) so an ssh / live-docker / network-egress / LAN-Tailscale-IP command check_value is rejected up front with an actionable message steering the author to the receipt-grep pattern, instead of surfacing as a late, cryptic CI BLOCK ('sh: 1: ssh: not found', exit 127). No new gate/workflow (net-negative-surface); the guard reuses the OMN-14436 demotion path so grandfathered legacy contracts are reported (WARN) not wedged, while new/touched contracts are enforced. Observed on OCC PR #3642 (OMN-14001). - _non_hermetic_reason() + quote-aware _command_binaries() command-position scan - guard called at top of _run_single_check(); _demote() still applies ratchet - re-exported via the thin scripts/ci wrapper - 20 new focused tests (reject ssh/docker/LAN-IP/scp/rsync/sudo-wrapped; accept receipt-grep/local-file/loopback-curl/quoted-docker-word; new-ticket BLOCK vs grandfathered WARN integration) * evidence(OMN-14051): supersede validator PR head binding
Summary
Adds central OCC contract and PASS receipts for OMN-14001, binding omnimarket PR #1629's delegation ROI overlay routing change.
Evidence
contracts/OMN-14001.yamldrift/dod_receipts/OMN-14001/dod-omnimarket-pr-1629/command.yaml,dod-learning-loop-proof/command.yaml, anddod-occ-self/command.yamla5925dabdacf12c90fdbd755a58b89208530bae2uv run validate-yaml contracts/OMN-14001.yamluv run python -m omnibase_core.validation.validator_receipt_gate_cli ...passed 3 checks across 1 ticketRuntime
No deploy, restart, or .201 mutation performed. This PR only adds central OCC evidence for the existing omnimarket PR.
Summary by CodeRabbit