Skip to content

evidence(OMN-14001): OCC companion for omnimarket #1629 ROI routing - #3642

Merged
jonahgabriel merged 10 commits into
devfrom
jonah/omn-14001-occ-evidence
Jul 7, 2026
Merged

jonahgabriel merged 10 commits into
devfrom
jonah/omn-14001-occ-evidence

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Jul 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Adds central OCC contract and PASS receipts for OMN-14001, binding omnimarket PR #1629's delegation ROI overlay routing change.

Evidence

Runtime

No deploy, restart, or .201 mutation performed. This PR only adds central OCC evidence for the existing omnimarket PR.

Summary by CodeRabbit

  • Documentation
    • Added a new contract record and supporting evidence receipts for a platform learning-loop rollout.
    • Expanded verification coverage with checks for deployment status, test evidence, and proof of related release artifacts.
    • Linked the work to required approval and traceability records for easier auditing and release confidence.

@coderabbitai

coderabbitai Bot commented Jul 6, 2026 •

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 13 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dcf78ef6-bbb7-4883-bf13-49081c4d08a6

📥 Commits

Reviewing files that changed from the base of the PR and between 95fff52 and 6367b12.

📒 Files selected for processing (5)
  • contracts/OMN-14001.yaml
  • drift/dod_receipts/OMN-14001/dod-deploy-scope/command.yaml
  • drift/dod_receipts/OMN-14001/dod-learning-loop-proof/command.yaml
  • drift/dod_receipts/OMN-14001/dod-occ-self/command.yaml
  • drift/dod_receipts/OMN-14001/dod-omnimarket-pr-1629/command.yaml
📝 Walkthrough

Walkthrough

Adds an OCC contract file contracts/OMN-14001.yaml defining evidence requirements for closing a learning-loop capability, along with four DoD receipt YAML files under drift/dod_receipts/OMN-14001/ recording PASS-status verification results (deploy scope, learning-loop proof, OCC self-binding, and omnimarket PR #1629).

Changes

OMN-14001 contract and evidence receipts

Layer / File(s) Summary
Contract definition
contracts/OMN-14001.yaml
Defines schema, ticket metadata, flags (not a seam ticket, no interface changes), evidence requirements, and dod_evidence bindings with grep-based PASS checks; emergency bypass disabled.
DoD receipt records
drift/dod_receipts/OMN-14001/dod-deploy-scope/command.yaml, .../dod-learning-loop-proof/command.yaml, .../dod-occ-self/command.yaml, .../dod-omnimarket-pr-1629/command.yaml
Adds four PASS-status receipt YAMLs with probe commands, probe stdout, commit/provenance metadata, and contract hash bindings supporting the contract's evidence requirements.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • OmniNode-ai/onex_change_control#3130: Both PRs add OCC contracts/receipts validating delegation decisions through LocalDelegationDispatchPort, sharing the same delegation routing code path.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly reflects the PR’s main change: adding OCC evidence for OMN-14001 tied to omnimarket #1629 ROI routing.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-14001-occ-evidence

Comment @coderabbitai help to get the list of available commands.

@jonahgabriel
jonahgabriel enabled auto-merge (squash) July 6, 2026 06:41
@jonahgabriel
jonahgabriel changed the base branch from main to dev July 6, 2026 09:48

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@drift/dod_receipts/OMN-14001/dod-deploy-scope/command.yaml`:
- Line 12: The probe_command value is currently descriptive text instead of a
runnable shell command, so update the command in the OMN-14001 scope receipt to
be valid executable syntax like the other receipts. Replace the non-executable
content in probe_command with the actual command used for verification, keeping
it as a single shell command and avoiding embedded parenthetical notes or
trailing prose.
- Line 9: The receipt is pointing at the wrong commit SHA, so update the
commit_sha in the command.yaml entry to match PR 1629’s head commit used by the
attestation. Use the existing commit_sha field in this receipt, and if the
receipt is intentionally for an intermediate probe instead of the final PR
state, add an explicit note clarifying that rather than leaving the head
mismatch unresolved.

In `@drift/dod_receipts/OMN-14001/dod-occ-self/command.yaml`:
- Around line 6-7: The self-binding verification in the receipt command is
incomplete because it does not include the new dod-deploy-scope artifact. Update
the command YAML for the OMN-14001 self-check so the check_value explicitly
validates the presence of
drift/dod_receipts/OMN-14001/dod-deploy-scope/command.yaml alongside the
existing contract and other receipt files, and make sure the probe_stdout
output/listing in the same receipt also includes that file. This keeps the
evidence check aligned with the full set of artifacts produced by the PR.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1f161f40-4778-4252-9d50-b8a3d7b60978

📥 Commits

Reviewing files that changed from the base of the PR and between 99e58b7 and 95fff52.

📒 Files selected for processing (5)
  • contracts/OMN-14001.yaml
  • drift/dod_receipts/OMN-14001/dod-deploy-scope/command.yaml
  • drift/dod_receipts/OMN-14001/dod-learning-loop-proof/command.yaml
  • drift/dod_receipts/OMN-14001/dod-occ-self/command.yaml
  • drift/dod_receipts/OMN-14001/dod-omnimarket-pr-1629/command.yaml

Comment thread drift/dod_receipts/OMN-14001/dod-deploy-scope/command.yaml Outdated
Comment thread drift/dod_receipts/OMN-14001/dod-deploy-scope/command.yaml Outdated
Comment thread drift/dod_receipts/OMN-14001/dod-occ-self/command.yaml Outdated
@jonahgabriel
jonahgabriel force-pushed the jonah/omn-14001-occ-evidence branch from 247494a to 6e5ac4a Compare July 7, 2026 15:55
@jonahgabriel
jonahgabriel merged commit 042673b into dev Jul 7, 2026
42 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-14001-occ-evidence branch July 7, 2026 17:32
jonahgabriel added a commit that referenced this pull request Jul 19, 2026
…ce validator (#4426)

* feat(OMN-14051): reject non-hermetic check_value in contract-compliance validator

Fold a non-hermetic check_value guard into the existing contract-compliance
engine (onex_change_control.scripts.contract_compliance_check) so an ssh /
live-docker / network-egress / LAN-Tailscale-IP command check_value is rejected
up front with an actionable message steering the author to the receipt-grep
pattern, instead of surfacing as a late, cryptic CI BLOCK ('sh: 1: ssh: not
found', exit 127). No new gate/workflow (net-negative-surface); the guard reuses
the OMN-14436 demotion path so grandfathered legacy contracts are reported (WARN)
not wedged, while new/touched contracts are enforced.

Observed on OCC PR #3642 (OMN-14001).

- _non_hermetic_reason() + quote-aware _command_binaries() command-position scan
- guard called at top of _run_single_check(); _demote() still applies ratchet
- re-exported via the thin scripts/ci wrapper
- 20 new focused tests (reject ssh/docker/LAN-IP/scp/rsync/sudo-wrapped; accept
  receipt-grep/local-file/loopback-curl/quoted-docker-word; new-ticket BLOCK vs
  grandfathered WARN integration)

* evidence(OMN-14051): supersede validator PR head binding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant