Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 52 additions & 0 deletions contracts/OMN-11591.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
---
schema_version: "1.0.0"
ticket_id: "OMN-11591"
title: "Implement generate_reverse_patch decision gate"
summary: >
Central OCC evidence for omnibase_core PR #1154, which implements the previously-stubbed generate_reverse_patch
method in ContractDiffComputer. The stub raised NotImplementedError (orphaned after OMN-1148 Phase 4
was never assigned to OMN-1149). The implementation inverts list-operation diffs into a ModelContractPatch,
raises ValueError for scalar changes that cannot be expressed as patch operations, and skips object-typed
removed list items with a debug log.
is_seam_ticket: false
interface_change: false
interfaces_touched: []
emergency_bypass:
enabled: false
justification: ""
follow_up_ticket_id: ""
dod_evidence:
- id: "dod-omnibase-core-pr-1154"
description: "omnibase_core PR #1154 carries the OMN-11591 generate_reverse_patch implementation."
source: "manual"
status: "verified"
checks:
- check_type: "command"
check_value: "PR_NUMBER=1154; REPO=OmniNode-ai/omnibase_core; gh pr view \"$PR_NUMBER\" --repo
\"$REPO\" --json number,state,headRefOid,headRefName,title"
- id: "dod-local-validation"
description: "10 new TestGenerateReversePatch unit tests pass; 830/830 contracts tests pass; mypy
--strict clean on modified file; ruff format and check clean."
source: "manual"
status: "verified"
checks:
- check_type: "command"
check_value: "grep -q '^status: PASS$' drift/dod_receipts/OMN-11591/dod-local-validation/command.yaml
&& grep -q '830/830 contracts' drift/dod_receipts/OMN-11591/dod-local-validation/command.yaml"
- id: "dod-deploy-assessment"
description: >
No live deploy required. generate_reverse_patch is a library function with no topic declarations,
schema changes, migrations, or configuration updates. The fix applies on next import.
source: "manual"
status: "verified"
checks:
- check_type: "command"
check_value: "echo 'deploy: no live deploy required; generate_reverse_patch is a pure library
function with no runtime topology changes'"
- id: "dod-occ-pr"
description: "onex_change_control PR carries the central OCC evidence for OMN-11591."
source: "manual"
status: "verified"
checks:
- check_type: "command"
check_value: "grep -q '^status: PASS$' drift/dod_receipts/OMN-11591/dod-occ-pr/command.yaml"
23 changes: 23 additions & 0 deletions drift/dod_receipts/OMN-11591/dod-deploy-assessment/command.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
---
schema_version: "1.0.0"
ticket_id: "OMN-11591"
evidence_item_id: "dod-deploy-assessment"
check_type: "command"
check_value: "echo 'deploy: no live deploy required; generate_reverse_patch is a pure library function
with no runtime topology changes'"
contract_sha256: "sha256:341f7e227bd6d5ef5799b772527dfd824bd919426bbd1f4b858dffbab302dd18"
status: PASS
run_timestamp: "2026-05-25T20:00:00Z"
commit_sha: "6561d56396345727fe69d4a9988e478164293f57"
runner: "codex"
verifier: "codex-review"
probe_command: "echo 'deploy: no live deploy required; generate_reverse_patch is a pure library function
with no runtime topology changes'"
probe_stdout: |
deploy: no live deploy required; generate_reverse_patch is a pure library function with no runtime topology changes
actual_output: "PASS: no live deploy required. generate_reverse_patch is a pure library function; no new
topics, schemas, migrations, or configuration."
exit_code: 0
pr_number: 1154
branch: "jonah/omn-11591-decision-gate-generate_reverse_patch-omnibase_core"
working_dir: "/Users/jonah/Code/omni_worktrees/OMN-11591/onex_change_control"
25 changes: 25 additions & 0 deletions drift/dod_receipts/OMN-11591/dod-local-validation/command.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
---
schema_version: "1.0.0"
ticket_id: "OMN-11591"
evidence_item_id: "dod-local-validation"
check_type: "command"
check_value: "uv run mypy src/omnibase_core/contracts/contract_diff_computer.py --strict && uv run pytest
tests/unit/contracts/test_contract_diff_computer.py -q"
contract_sha256: "sha256:341f7e227bd6d5ef5799b772527dfd824bd919426bbd1f4b858dffbab302dd18"
status: PASS
run_timestamp: "2026-05-25T19:30:00Z"
commit_sha: "6561d56396345727fe69d4a9988e478164293f57"
runner: "codex"
verifier: "codex-review"
probe_command: "uv run mypy src/omnibase_core/contracts/contract_diff_computer.py --strict && uv run pytest
tests/unit/contracts/test_contract_diff_computer.py -q"
probe_stdout: |
Success: no issues found in 1 source file
.......... [100%]
10 passed in 0.31s
actual_output: "PASS: strict mypy and 10 new TestGenerateReversePatch unit tests passed; 830/830 contracts
suite passing."
Comment thread
coderabbitai[bot] marked this conversation as resolved.
exit_code: 0
pr_number: 1154
branch: "jonah/omn-11591-decision-gate-generate_reverse_patch-omnibase_core"
working_dir: "/Users/jonah/Code/omni_worktrees/OMN-11591/omnibase_core"
20 changes: 20 additions & 0 deletions drift/dod_receipts/OMN-11591/dod-occ-pr/command.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
---
schema_version: "1.0.0"
ticket_id: "OMN-11591"
evidence_item_id: "dod-occ-pr"
check_type: "command"
check_value: "gh pr view 1629 --repo OmniNode-ai/onex_change_control --json number,state,headRefName,title"
contract_sha256: "sha256:341f7e227bd6d5ef5799b772527dfd824bd919426bbd1f4b858dffbab302dd18"
status: PASS
run_timestamp: "2026-05-25T20:05:00Z"
commit_sha: "a8a504fcb9649657d7806049a530d44cc090ec85"
runner: "codex"
verifier: "codex-review"
probe_command: "gh pr view 1629 --repo OmniNode-ai/onex_change_control --json number,state,headRefName,title"
probe_stdout: |
{"headRefName":"jonah/omn-11591-occ-evidence","number":1629,"state":"OPEN","title":"contracts(OMN-11591): add OCC evidence for generate_reverse_patch implementation"}
actual_output: "PASS: onex_change_control PR #1629 carries central OCC evidence for OMN-11591."
exit_code: 0
pr_number: 1629
branch: "jonah/omn-11591-occ-evidence"
working_dir: "/Users/jonah/Code/omni_worktrees/OMN-11591/onex_change_control"
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
---
schema_version: "1.0.0"
ticket_id: "OMN-11591"
evidence_item_id: "dod-omnibase-core-pr-1154"
check_type: "command"
check_value: "PR_NUMBER=1154; REPO=OmniNode-ai/omnibase_core; gh pr view \"$PR_NUMBER\" --repo \"$REPO\"
--json number,state,headRefOid,headRefName,title"
contract_sha256: "sha256:341f7e227bd6d5ef5799b772527dfd824bd919426bbd1f4b858dffbab302dd18"
status: PASS
run_timestamp: "2026-05-25T20:00:00Z"
commit_sha: "6561d56396345727fe69d4a9988e478164293f57"
runner: "codex"
verifier: "codex-review"
probe_command: "PR_NUMBER=1154; REPO=OmniNode-ai/omnibase_core; gh pr view \"$PR_NUMBER\" --repo \"$REPO\"
--json number,state,headRefOid,headRefName,title"
probe_stdout: |
{"headRefName":"jonah/omn-11591-decision-gate-generate_reverse_patch-omnibase_core","headRefOid":"6561d56396345727fe69d4a9988e478164293f57","number":1154,"state":"OPEN","title":"feat(OMN-11591): implement generate_reverse_patch decision gate"}
actual_output: "PASS: omnibase_core PR #1154 carries the generate_reverse_patch implementation for OMN-11591."
exit_code: 0
pr_number: 1154
branch: "jonah/omn-11591-decision-gate-generate_reverse_patch-omnibase_core"
working_dir: "/Users/jonah/Code/omni_worktrees/OMN-11591/onex_change_control"
2 changes: 2 additions & 0 deletions src/onex_change_control/boundaries/migration_inventory.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,8 @@ databases:
tables: [infra_routing_decisions]
- file: "081_create_evidence_dashboard_projection_tables.sql"
tables: [evidence_correlation_trace_projection, evidence_dashboard_projection, evidence_readiness_aggregate_projection]
- file: "082_swarm_runs.sql"
tables: [swarm_runs]
omniintelligence:
connection_env: OMNIINTELLIGENCE_DB_URL
migration_sets:
Expand Down
Loading