Skip to content

fix(cli): restore messaging toolset for gateway platforms - #8934

Closed
abutbul wants to merge 1 commit into
NousResearch:mainfrom
abutbul:fix/messaging-toolset-send-message
Closed

fix(cli): restore messaging toolset for gateway platforms#8934
abutbul wants to merge 1 commit into
NousResearch:mainfrom
abutbul:fix/messaging-toolset-send-message

Conversation

@abutbul

@abutbul abutbul commented Apr 13, 2026

Copy link
Copy Markdown

Summary

  • add the missing messaging entry back to CONFIGURABLE_TOOLSETS
  • keep send_message visible when gateway platforms resolve composite toolsets like hermes-telegram / hermes-matrix
  • add targeted regression tests for the registry entry and default Telegram platform resolution

Root cause

_get_platform_tools() reverse-maps composite platform toolsets through CONFIGURABLE_TOOLSETS. The runtime messaging toolset already exists in toolsets.py, but because it was missing from the configurable registry, gateway platforms never re-enabled it and send_message was silently dropped from live platform sessions.

Why this PR

I checked existing upstream work before sending this:

This branch keeps the fix intentionally minimal and directly reproducible on current origin/main: one registry entry plus two focused regressions.

Testing

  • python -m pytest tests/hermes_cli/test_tools_config.py -q
  • runtime verification via _get_platform_tools(load_config(), "telegram") + get_tool_definitions(...) confirms:
    • messaging present in resolved toolsets
    • send_message present in live schema

Fixes #8616.

@abutbul

abutbul commented Apr 13, 2026

Copy link
Copy Markdown
Author

I reviewed the overlapping upstream work before deciding whether to keep this open.

Notes:

I’m keeping this PR intentionally tiny/current-main-friendly so maintainers have a clean, low-risk option to merge even if older overlapping PRs have drifted. If maintainers prefer #8626 or another existing branch, I’m happy to close this in favor of that one.

@abutbul

abutbul commented Apr 13, 2026

Copy link
Copy Markdown
Author

Additional maintainer note: #8626 looks like the closest existing overlap to this PR — it follows the same minimal fix strategy (restore messaging in CONFIGURABLE_TOOLSETS + focused regressions). I’m happy to close #8934 in favor of #8626 if maintainers prefer to consolidate there. I kept this branch open because I reproduced the bug directly on current origin/main during live gateway debugging, and wanted to provide a current-main-verified version of the smallest possible fix.

@teknium1

Copy link
Copy Markdown
Contributor

Merged via PR #10114. Your commit was cherry-picked onto current main with authorship preserved. Thanks for the fix and the solid test coverage! Also closes #6140 and #6007 which fixed the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(gateway): messaging toolset missing from CONFIGURABLE_TOOLSETS — send_message silently dropped for all gateway platforms

2 participants