fix(cli): restore messaging toolset for gateway platforms - #8934
Conversation
|
I reviewed the overlapping upstream work before deciding whether to keep this open. Notes:
I’m keeping this PR intentionally tiny/current-main-friendly so maintainers have a clean, low-risk option to merge even if older overlapping PRs have drifted. If maintainers prefer #8626 or another existing branch, I’m happy to close this in favor of that one. |
|
Additional maintainer note: #8626 looks like the closest existing overlap to this PR — it follows the same minimal fix strategy (restore |
977e03b to
db91bcd
Compare
Summary
messagingentry back toCONFIGURABLE_TOOLSETSsend_messagevisible when gateway platforms resolve composite toolsets likehermes-telegram/hermes-matrixRoot cause
_get_platform_tools()reverse-maps composite platform toolsets throughCONFIGURABLE_TOOLSETS. The runtimemessagingtoolset already exists intoolsets.py, but because it was missing from the configurable registry, gateway platforms never re-enabled it andsend_messagewas silently dropped from live platform sessions.Why this PR
I checked existing upstream work before sending this:
This branch keeps the fix intentionally minimal and directly reproducible on current
origin/main: one registry entry plus two focused regressions.Testing
python -m pytest tests/hermes_cli/test_tools_config.py -q_get_platform_tools(load_config(), "telegram")+get_tool_definitions(...)confirms:messagingpresent in resolved toolsetssend_messagepresent in live schemaFixes #8616.