fix(cli): add messaging to configurable toolsets - #8626
Closed
sgaofen wants to merge 1 commit into
Closed
Conversation
sgaofen
marked this pull request as ready for review
April 13, 2026 00:53
This was referenced Apr 24, 2026
fix(discord): end-to-end Discord support — toolset loading, tool split, and context injection
#15091
Closed
Contributor
|
Thanks for the thorough write-up and for tracking down the root cause in This is an automated hermes-sweeper review. The fix has already landed on
The PR's change is fully superseded by that commit. Closing as implemented on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
messagingentry toCONFIGURABLE_TOOLSETSsend_messagevisible when gateway platforms resolve composite toolsets likehermes-telegramRoot Cause
Issue #8616 came from
_get_platform_tools()reverse-mapping composite platform toolsets back throughCONFIGURABLE_TOOLSETS. The runtimemessagingtoolset already exists intoolsets.py, but because it was missing from the configurable registry, gateway platforms never re-enabled it andsend_messagewas silently dropped from platform sessions.Fixes #8616.
Testing
uv run --extra dev pytest tests/hermes_cli/test_tools_config.pyPlatform Tested
Contribution Guide Notes
CONTRIBUTING.mdand checked for existing open PRs before submitting this scoped bug fix.pytest tests/ -qpass unless explicitly noted.