Skip to content

fix(cli): add messaging to configurable toolsets - #8626

Closed
sgaofen wants to merge 1 commit into
NousResearch:mainfrom
sgaofen:codex/messaging-toolset-config
Closed

fix(cli): add messaging to configurable toolsets#8626
sgaofen wants to merge 1 commit into
NousResearch:mainfrom
sgaofen:codex/messaging-toolset-config

Conversation

@sgaofen

@sgaofen sgaofen commented Apr 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add the missing messaging entry to CONFIGURABLE_TOOLSETS
  • keep send_message visible when gateway platforms resolve composite toolsets like hermes-telegram
  • add regression tests for the configurable toolset registry and Telegram default platform resolution

Root Cause

Issue #8616 came from _get_platform_tools() reverse-mapping composite platform toolsets back through CONFIGURABLE_TOOLSETS. The runtime messaging toolset already exists in toolsets.py, but because it was missing from the configurable registry, gateway platforms never re-enabled it and send_message was silently dropped from platform sessions.

Fixes #8616.

Testing

  • uv run --extra dev pytest tests/hermes_cli/test_tools_config.py

Platform Tested

  • macOS 15.x (Apple Silicon)

Contribution Guide Notes

  • Reviewed CONTRIBUTING.md and checked for existing open PRs before submitting this scoped bug fix.
  • Ran the targeted verification commands listed above for this PR. I have not claimed a full repo-wide pytest tests/ -q pass unless explicitly noted.

@sgaofen sgaofen changed the title [codex] fix missing messaging toolset config fix(cli): add messaging to configurable toolsets Apr 12, 2026
@sgaofen
sgaofen marked this pull request as ready for review April 13, 2026 00:53
@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the thorough write-up and for tracking down the root cause in _get_platform_tools() — this was a real bug.

This is an automated hermes-sweeper review. The fix has already landed on main.

  • hermes_cli/tools_config.py line 68messaging is present in CONFIGURABLE_TOOLSETS on current main.
  • Commit da8bab77f (fix(cli): restore messaging toolset for gateway platforms, 2026-04-13) added the identical +1 line to tools_config.py and the same regression tests (test_configurable_toolsets_include_messaging + test_get_platform_tools_default_telegram_includes_messaging) to tests/hermes_cli/test_tools_config.py.

The PR's change is fully superseded by that commit. Closing as implemented on main.

@teknium1 teknium1 closed this Apr 28, 2026
@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/tools Tool registry, model_tools, toolsets comp/gateway Gateway runner, session dispatch, delivery labels Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery comp/tools Tool registry, model_tools, toolsets P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(gateway): messaging toolset missing from CONFIGURABLE_TOOLSETS — send_message silently dropped for all gateway platforms

3 participants