fix(tools): add messaging to CONFIGURABLE_TOOLSETS - #6007
Closed
r266-tech wants to merge 2 commits into
Closed
Conversation
Tools registered to the 'messaging' toolset (e.g. send_message) are silently dropped from every messaging-platform session because 'messaging' has no entry in CONFIGURABLE_TOOLSETS. The subset-matching logic in _get_platform_tools() only adds toolset keys that appear in CONFIGURABLE_TOOLSETS, so send_message is never included in the resolved tool list. Fixes NousResearch#5991
Contributor
|
Superseded by PR #10114 (salvaged from #8934 which had the best test coverage). Same fix — messaging added to CONFIGURABLE_TOOLSETS. Thanks @r266-tech! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tools registered to the
messagingtoolset (e.g.send_message) are silently dropped from every messaging-platform session (Telegram, Discord, Slack, WhatsApp, Signal, Matrix) becausemessaginghas no entry inCONFIGURABLE_TOOLSETS.Root cause
_get_platform_tools()resolves composite toolset names (e.g.hermes-matrix) by callingresolve_toolset()then reverse-mapping individual tool names back toCONFIGURABLE_TOOLSETSkeys. Sincemessagingis not listed there, the subset-match at line 521-524 never adds it, andsend_messageis silently excluded from the tool list passed toget_tool_definitions().Fix
Add
("messaging", "📨 Cross-platform Messaging", "send_message")toCONFIGURABLE_TOOLSETS— same pattern as every other registered toolset.Changes
hermes_cli/tools_config.py: Addmessagingentry toCONFIGURABLE_TOOLSETStests/hermes_cli/test_tools_config.py: Add regression test assertingmessagingis in configurable keysFixes #5991