Skip to content

fix(tools): register "messaging" toolset so send_message reaches platform sessions - #6140

Closed
bkadish wants to merge 1 commit into
NousResearch:mainfrom
bkadish:fix/messaging-toolset-registration
Closed

fix(tools): register "messaging" toolset so send_message reaches platform sessions#6140
bkadish wants to merge 1 commit into
NousResearch:mainfrom
bkadish:fix/messaging-toolset-registration

Conversation

@bkadish

@bkadish bkadish commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • The send_message tool lives in the messaging toolset, but messaging is not listed in CONFIGURABLE_TOOLSETS in hermes_cli/tools_config.py.
  • As a result, the subset-match collapse in _get_platform_tools() silently drops send_message from matrix/discord/slack/telegram sessions. The tool loads at cold start, then vanishes after the first toolset reconciliation.
  • Two-line fix: add the ("messaging", …) entry so the collapse keeps it. No runtime behavior changes beyond "the tool is now reachable".

Refs #5991.

Test plan

  • Restarted a matrix gateway session and confirmed send_message is present in the resolved toolset after reconciliation (previously absent).
  • Sent a real cross-room message via send_message end-to-end.
  • CI

…form sessions

The `send_message` tool lives in the `messaging` toolset, but `messaging` is
not listed in `CONFIGURABLE_TOOLSETS`. As a result, the subset-match collapse
in `_get_platform_tools()` silently drops every `send_message` binding from
matrix/discord/slack/telegram sessions — the tool exists, the session has it
loaded at cold start, but it vanishes after the first toolset reconciliation.

This is a two-line fix: add the `("messaging", …)` entry so the collapse
keeps it. No runtime behavior changes beyond "the tool is now reachable".

Refs #5991.
@teknium1

Copy link
Copy Markdown
Contributor

Superseded by PR #10114 (salvaged from #8934 which had the best test coverage). The fix is identical — messaging added to CONFIGURABLE_TOOLSETS. Thanks @bkadish for identifying this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants