fix(photon): reconcile FFFC placeholder handling + deps-check fixtures (post-wave) - #73762
Closed
teknium1 wants to merge 1 commit into
Closed
fix(photon): reconcile FFFC placeholder handling + deps-check fixtures (post-wave)#73762teknium1 wants to merge 1 commit into
teknium1 wants to merge 1 commit into
Conversation
…fixtures Two cross-PR collisions from today's photon wave: - #54514's early U+FFFC drop (merged via #73560) shadowed the pending-FFFC wait/timeout machinery that landed with the voice-routing work, making its 4 tests fail and the attachment-wait path unreachable. Remove the early drop; the FFFC machinery both suppresses the text turn and waits for the real attachment (strictly more capable). - #73562's partial-install guard (sidecar_deps_installed now requires node_modules/spectrum-ts) broke #73564's runtime-record fixtures that mkdir'd bare node_modules.
alt-glitch
added
type/bug
Collaborator
Contributor
૮ >ﻌ< ა ci reviewran on d4d7736 ℹ️ InfoDesktop E2E visual evidence · View test artifacts · View job1 visual diff. inline evidence upload failed. Failed to upload diff-665a0833239e-onboarding-overlay-diff.png with gh image (exit code 1): Error uploading /home/runner/work/_temp/e2e-evidence/diff-665a0833239e-onboarding-overlay-diff.png: step 0 (get upload token): uploadToken not found on repo page — do you have write access to NousResearch/hermes-agent? (or, if NousResearch enforces SAML SSO, authorize at https://github.com/orgs/NousResearch/sso) |
19 tasks
This was referenced Jul 29, 2026
Closed
Contributor
Author
|
Superseded — equivalent fix landed on main via ceaa788. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reconciles two cross-PR collisions from today's Photon wave that left main's photon suite red at 158/164: the #54514 early U+FFFC drop shadowed the pending-FFFC wait/timeout machinery (making its attachment-wait path unreachable and orphaning 4 tests), and the new partial-install deps guard broke the runtime-record test fixtures.
Changes
adapter.py: remove the early U+FFFC return at the text-normalization boundary — the pending-FFFC machinery (detected later in_dispatch_inbound) both suppresses the bogus text turn AND waits for the real attachment with a timeout, strictly superseding the early drop. Comment documents why it must not be re-added.test_runtime_record.py: fixtures createnode_modules/spectrum-tsto satisfysidecar_deps_installed()'s partial-install guard.Validation
Infographic