fix(photon): quick-fix wave — placeholder drop, edit-flag, envelope unwrap, test isolation (salvage #71673 #54514 #62172 #70818) - #73560
Merged
Conversation
alt-glitch
added
type/bug
Contributor
૮ >ﻌ< ა ci reviewran on a826e2d ℹ️ InfoDesktop E2E visual evidence · View test artifacts · View job1 visual diff. inline evidence upload failed. Failed to upload diff-665a0833239e-onboarding-overlay-diff.png with gh image (exit code 1): Error uploading /home/runner/work/_temp/e2e-evidence/diff-665a0833239e-onboarding-overlay-diff.png: step 0 (get upload token): uploadToken not found on repo page — do you have write access to NousResearch/hermes-agent? (or, if NousResearch enforces SAML SSO, authorize at https://github.com/orgs/NousResearch/sso) |
Cherry-picked from PR #54514; dropped frozen AUTHOR_MAP hunk in scripts/release.py, contributor mapping added instead.
…ss streaming cursor Photon (iMessage) has no real edit API for already-sent messages. When streaming completes, the gateway attempts to edit the message to remove the streaming cursor (▉). Without edit support, this cursor gets stuck in the final message, corrupting Unicode characters. This change sets SUPPORTS_MESSAGE_EDITING=False on PhotonAdapter, which causes the gateway to suppress the streaming cursor entirely for this platform (via _effective_cursor in gateway/run.py). This prevents the stale tofu square (▉) from appearing in streamed iMessage responses. Fixes #49253
teknium1
force-pushed
the
photon/quick-fixes
branch
from
July 28, 2026 20:33
9798a66 to
a826e2d
Compare
This was referenced Jul 29, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four small independent Photon fixes salvaged onto current main with contributor authorship preserved: U+FFFC media placeholders no longer surface as ghost message text, the streaming-cursor tofu (▉) never reaches iMessage bubbles, dashboard project-API envelope responses unwrap correctly, and Photon/delegation env state is quarantined in tests.
Changes
HERMES_DELEGATED_CHILD_CONTEXT+PHOTON_*env; cron no-connected-channels env list derived from the platform registry._record_last_inboundand dispatch (frozenrelease.pyAUTHOR_MAP hunk dropped; mapping added viacontributors/emails/).SUPPORTS_MESSAGE_EDITING = Falseon PhotonAdapter — matches the BlueBubbles/Signal/WeCom capability-flag convention; fixes the stuck ▉ cursor since iMessage cannot edit sent messages. Fixes Photon iMessage: streaming cursor/tofu shows as white square in outbound messages #49793.{succeed, data:{id}}dashboard envelopes increate_projectwith legacy path preserved — prevents duplicate project creation on retry.Validation
Fixes #49793.
Infographic