fix(photon): un-shadow U+FFFC deferred-wait handler + stale sidecar-deps fixture (red on main) - #73763
Merged
Merged
Conversation
…decar-deps fixture Two independent cross-PR collisions red on main (slice 8/8): 1. fd4f756 (salvaged from stale #54514) added an early 'drop U+FFFC placeholder' return at the top of _dispatch_inbound — written before the deferred-wait handler (6b91b50/afab7ed46e) existed further down the same function. The early return shadowed it: _pending_fffc never populated, no attachment-timeout tracking, 4 tests red. Remove the duplicate block; the deferred handler already drops the placeholder AND tracks/cancels/warns. 2. 9cf2046 tightened sidecar_deps_installed() to require node_modules/spectrum-ts, but test_runtime_record's _patch_spawn fixture still created only bare node_modules/ — 2 tests red. Mirror a real completed install. tests/plugins/platforms/photon: 164/164 after; 158/164 before.
Contributor
૮ >ﻌ< ა ci reviewran on 56d76be ℹ️ InfoDesktop E2E visual evidence · View test artifacts · View job1 visual diff. inline evidence upload failed. Failed to upload diff-665a0833239e-onboarding-overlay-diff.png with gh image (exit code 1): Error uploading /home/runner/work/_temp/e2e-evidence/diff-665a0833239e-onboarding-overlay-diff.png: step 0 (get upload token): uploadToken not found on repo page — do you have write access to NousResearch/hermes-agent? (or, if NousResearch enforces SAML SSO, authorize at https://github.com/orgs/NousResearch/sso) |
alt-glitch
added
type/bug
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repairs 6 Photon tests red on current main (CI slice 8/8, failing unrelated PRs — first seen on #73761): two independent cross-PR collisions.
_dispatch_inbound. It shadowed the deferred-wait handler further down the same function (6b91b50/afab7ed46e):_pending_fffcnever populated, no attachment-timeout tracking or cancellation — 4 tests red, and the regression is real behavior loss, not just test drift (a placeholder with no follow-up attachment now timed out silently with no warning). Removing the duplicate restores the full handler; it already drops the placeholder.sidecar_deps_installed()to requirenode_modules/spectrum-ts(empty node_modules from aborted npm installs read as "installed"), buttest_runtime_record's_patch_spawnfixture still created barenode_modules/— 2 tests red.Changes
plugins/platforms/photon/adapter.py: remove the duplicate early-return placeholder block (deferred-wait handler is the single owner)tests/plugins/platforms/photon/test_runtime_record.py: fixture mirrors a real completed installValidation
Infographic