fix(acp): pass fallback_model chain to ACP sessions

[tzy-17]

Problem

ACP (editor) sessions built via _make_agent constructed AIAgent without the fallback_model kwarg, unlike the CLI (cli.py) and cron (scheduler.py) paths, which both wire get_fallback_chain(config).

As a result, ACP sessions silently ignored the configured fallback_providers / fallback_model chain — when the primary provider hit a rate-limit, overload, or connection failure, the session could never fall back to a backup provider.

Closes #64441

Fix

Pass fallback_model=get_fallback_chain(config) or None in acp_adapter/session.py _make_agent, matching the other agent-construction paths.

Verification

• ruff check on touched files: clean
• python -m py_compile: clean
• Added a regression test (test_acp_real_agent_gets_fallback_chain_from_config) mirroring the existing test_acp_real_agent_gets_session_db_for_recall pattern, asserting the fallback chain reaches AIAgent.

Checklist

• Change is minimal and scoped to the bug
• Tests added
• Lint passes

[alt-glitch]

This was generated by AI during triage.

Duplicate of #18460 — same code site (acp_adapter/session.py _make_agent) and same mechanism (missing fallback_model kwarg to AIAgent). #18460 is the earliest still-open fix PR in this cluster (also #22200, #36720). Marking as duplicate; the maintainer will pick the canonical PR to merge. related_to the underlying issues #64441 / #18452.

[GottZ]

This was generated by AI during triage.

Summary

Five of the 11 listed PRs address the ACP fallback defect: #18460, #22200, #36720, #57418, and #64868; their changes range from canonical get_fallback_chain(config) forwarding with tests to incorrect or unsafe variants. The other six concern Discord typing retries, diary skills, attribution cleanup, or Discord regression coverage rather than the reported ACP cause.

Related pull requests

• fix(acp): pass fallback_providers to AIAgent (parity with CLI) #18460 best fix — (+153/-0) — n/a: The complete diff forwards get_fallback_chain(config) as fallback_model and tests modern, legacy, and combined de-duplicated chains, satisfying the COMMENTED keep_open review's requested corrections and retaining its recorded best-fix role.
• fix(acp): pass fallback_providers to AIAgent in ACP sessions #22200 partial — (+7/-1234990) — n/a: The intended ACP hunk addresses the missing kwarg but uses fallback_providers or fallback_model and sits inside a reported 3,214-file aggregate; despite the keep_open verdict, its suggested canonical helper and focused tests are already present in fix(acp): pass fallback_providers to AIAgent (parity with CLI) #18460.
• fix: handle Discord typing indicator 429 gracefully #22398 [closed] related — (+22/-4) — n/a: The complete diff changes Discord typing-indicator cadence and 429 backoff rather than ACP construction; although closed, it remains relevant as the source implementation salvaged into fix(discord): handle typing indicator 429 gracefully #29671.
• chore: remove personal name references #26527 related — (+1324032/-1215) — n/a: Its stated scope removes personal-name references, while the contributor review reports an unfocused 3,384-file comparison and attribution concerns rather than an ACP fallback fix.
• feat(optional-skills): add daily-diary skill #28363 [closed] related — (+406/-1372450) — n/a: Its stated scope is the daily-diary optional skill, not fallback_model propagation; although closed, it remains relevant as the aggregate predecessor of focused diary PR feat(optional-skills): add daily-diary skill #28616.
• feat(optional-skills): add daily-diary skill #28616 related — (+406/-0) — n/a: The complete diff adds daily-diary skill files and workflows without changing ACP agent construction; its keep_open review concerns diary-specific ISO-week, memory-schema, and cron-placeholder corrections.
• fix(discord): handle typing indicator 429 gracefully #29671 [merged] related — (+23/-4) — n/a: This merged reference implementation contains the Discord typing-indicator 429 retry salvaged from fix: handle Discord typing indicator 429 gracefully #22398 plus release attribution, not an ACP fallback-chain change.
• test(discord): regression guard for typing-indicator 429 handling (#29671) #32761 related — (+1561465/-1215) — n/a: Its stated test scope covers the Discord behavior from fix(discord): handle typing indicator 429 gracefully #29671, and the keep_open review recommends salvaging an explicit-429 test file from the conflicting aggregate rather than treating it as an ACP fix.
• fix(acp): pass fallback_providers to AIAgent in editor integrations (… #36720 partial — (+5/-0) — n/a: The complete diff adds fallback_model but reads top-level fallback keys from model_cfg, so the contributor COMMENTED keep_open review finds normal configurations still ineffective; despite that verdict, fix(acp): pass fallback_providers to AIAgent (parity with CLI) #18460 already implements its requested helper call and regression coverage.
• fix(acp): pass configured fallback chain to AIAgent — model failover was broken over ACP #57418 [closed] fixes — (+71/-0) — n/a: The complete diff correctly uses get_fallback_chain(config) and adds ACP forwarding tests, but it is closed because its author and contributor triage deferred it as a duplicate of earlier fix(acp): pass fallback_providers to AIAgent (parity with CLI) #18460.
• fix(acp): pass fallback_model chain to ACP sessions #64868 fixes — (+57/-0) — n/a: The complete diff forwards get_fallback_chain(config) or None and adds a constructor-kwargs regression test, directly addressing [Bug]: ACP adapter (hermes acp) ignores fallback_providers — _make_agent never passes fallback_model, so ACP sessions run with an empty fallback chain #64441, but contributor triage identifies it as a duplicate of fix(acp): pass fallback_providers to AIAgent (parity with CLI) #18460 at the same call site.

Duplicates

#18460, #22200, #36720, #57418, and #64868 form the ACP fallback-propagation duplicate cluster, with #57418 already closed in favor of #18460; #22398 and merged #29671 represent the same Discord typing-retry implementation, while #28363 and #28616 overlap in stated daily-diary scope.

Suggested consolidation

Keep #18460 open with a salvage path: preserve its focused get_fallback_chain(config) wiring and combined-key regression coverage, consistent with both its recorded best-fix designation and COMMENTED keep_open review. Close #22200 as a duplicate of #18460 despite its keep_open verdict because its aggregate diff and or-based semantics are superseded there; close #36720 and #64868 as duplicates of #18460, keep #57418 closed in that chain, and exclude #22398, #26527, #28363, #28616, #29671, and #32761 from this ACP issue complex.

Complex graph

flowchart TD
    classDef open fill:#dbeafe,stroke:#1d4ed8,color:#1e3a8a
    classDef merged fill:#dcfce7,stroke:#15803d,color:#14532d
    classDef closed fill:#e5e7eb,stroke:#6b7280,color:#1f2937
    classDef unverified fill:#f3f4f6,stroke:#9ca3af,color:#374151
    classDef best stroke-width:3px,stroke:#b45309
    classDef target stroke-width:3px,stroke:#4338ca
    I18452(["issue #18452 (open)"])
    I64441(["issue #64441 (open)"])
    subgraph Dup18460 ["PRs duplicating each other"]
        P18460["PR #18460 (open)"]
        P22200["PR #22200 (open)"]
        P36720["PR #36720 (open)"]
        P57418["PR #57418 (closed)"]
        P64868["PR #64868 (open)"]
    end
    P64868 -->|fixes| I18452
    P64868 -->|fixes| I64441
    class I18452 open
    class I64441 open
    class P18460 open
    class P22200 open
    class P36720 open
    class P57418 closed
    class P64868 open
    class P18460 best
    class P18460 best
    class P64868 target
    click I18452 "https://github.com/NousResearch/hermes-agent/issues/18452"
    click I64441 "https://github.com/NousResearch/hermes-agent/issues/64441"
    click P18460 "https://github.com/NousResearch/hermes-agent/pull/18460"
    click P22200 "https://github.com/NousResearch/hermes-agent/pull/22200"
    click P36720 "https://github.com/NousResearch/hermes-agent/pull/36720"
    click P57418 "https://github.com/NousResearch/hermes-agent/pull/57418"
    click P64868 "https://github.com/NousResearch/hermes-agent/pull/64868"

Loading

Graph: solid arrow = fixes / best fix, dashed arrow = partial or unverified (see edge label); boxed group = PRs duplicating each other; amber border = best fix; indigo border = target; gray node = closed (state tag in the node label).

Cross-PR triage: Reviewed 11 pull requests and 2 issues in this complex. Diffs were read for 7 of 11 PRs (rest unavailable); Assessment working set: 35 kB of PR diffs, 21 kB of issue/PR text, 12 kB of discussion (21 comments), 12 verify verdicts. verdicts reflect diff content, not PR titles. Part of an automated triage batch.