fix(acp): pass fallback_providers to AIAgent in ACP sessions - #22200
Open
hitken wants to merge 1 commit into
Open
fix(acp): pass fallback_providers to AIAgent in ACP sessions#22200hitken wants to merge 1 commit into
hitken wants to merge 1 commit into
Conversation
ACP adapter's _make_agent() was not reading fallback_providers/ fallback_model from config and passing it to AIAgent — so ACP clients (VS Code, Zed, JetBrains) would never auto-switch to fallback models on primary provider failure. This patch mirrors the same fallback resolution logic from cli.py into acp_adapter/session.py's _make_agent() method.
Collaborator
2 tasks
Contributor
|
Thanks for identifying the ACP failover gap. The current implementation still constructs Problems
Suggested changes
This is an automated hermes-sweeper review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
ACP adapter's
_make_agent()inacp_adapter/session.pydid not readfallback_providers/fallback_modelfrom config and pass it toAIAgent. This means ACP clients (VS Code, Zed, JetBrains) would never auto-switch to fallback models when the primary provider fails — the agent would simply error out instead of gracefully degrading.Fix
Mirrors the same fallback resolution logic from
cli.pyintoacp_adapter/session.py's_make_agent()method:The
fallback_modelkwarg is now populated beforeAIAgentis instantiated, ensuring ACP sessions benefit from the same provider failover behaviour as CLI and gateway sessions.Testing
fallback_providersfrom~/.hermes/config.yaml