fix(discord): handle typing indicator 429 gracefully - #29671
Merged
Conversation
The typing indicator loop (send_typing) ran every 8s and died on any exception, including Discord 429 rate limits. Once a 429 killed the loop, the indicator never restarted — and the raw exception bounce could cascade into broader gateway instability. Changes: - Bump sleep interval from 8s to 12s (typing light lasts ~10s) - On 429: extract retry_after, log a warning, sleep the backoff, and continue the loop - On non-rate-limit errors: log debug and return (unchanged behaviour)
Contributor
🔎 Lint report:
|
2 tasks
Closed
19 tasks
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #22398 by @nycomar.
Summary
Discord typing indicator loop no longer dies on rate-limit errors — extracts
retry_after, sleeps the backoff, and continues.Changes
gateway/platforms/discord.py: on exception in typing loop, use existing_extract_discord_retry_after()helper; if 429 → log warning + sleep + continue; otherwise → log debug + return (existing behavior).scripts/release.py: AUTHOR_MAP entry for @nycomar.Validation
tests/gateway/test_discord_send.py: 18/18 pass.Closes #22398.
Infographic