fix(feishu): ignore @所有人/@everyone mentions in group chats

[Mason-zy]

Problem

In Feishu group chats, the bot always replies when someone uses @所有人 (@everyone), even though the bot itself is not mentioned. This creates noise in enterprise groups where @所有人 is routinely used for announcements. Tracked in #33723.

Root cause

_mentions_self() in plugins/platforms/feishu/adapter.py treats @_all (Feishu's @everyone placeholder) as a self-mention:

def _mentions_self(self, message):
    # @_all is Feishu's @everyone placeholder.
    raw_content = getattr(message, "content", "") or ""
    if "@_all" in raw_content:
        return True            # ← always triggers the bot

Combined with the require_mention gate (@_all returns True → gate passes → bot replies), this means every @所有人 announcement triggers a response.

Fix

Drop the @_all → return True branch so @所有人 no longer counts as a self-mention. The bot will still respond to explicit @botname mentions.

This change is safe because the other two mention-detection paths already handle the case correctly:

• _message_mentions_bot() matches by bot open_id/user_id/name (an @everyone tag has no bot ID)
• _post_mentions_bot() checks m.is_self (an @everyone tag is is_all=True, never is_self)

So removing this branch only stops @所有人 from triggering the bot; real @bot mentions are unaffected.

Behavior contrast

Message	Before	After
@所有人 please review	bot replies	bot ignores (no @bot)
@botname what's up	bot replies	bot replies
@所有人 @botname hey	bot replies	bot replies (bot explicitly mentioned)

Closes #33723.

[tonydwb]

Code Review Summary

Verdict: Approved

Changes

Fixes #33723: Feishu bot was replying to every @所有人 group announcement because @_all was treated as a self-mention. The fix removes the @_all special case so only actual bot mentions trigger a response.

Quality

• Minimal, targeted fix: only the _mentions_self check is changed
• Clear comment referencing the issue
• No security or correctness concerns

Suggestions

• None

---

Reviewed by Hermes Agent

[tonydwb]

Code Review

COMMENT: fix(feishu): ignore @所有人/@everyone mentions in group chats

Small fix (2 additions, 3 deletions). No security concerns.

---

Reviewed by Hermes Agent

[teknium1]

Thanks for the focused Feishu fix. The premise is confirmed on current main: plugins/platforms/feishu/adapter.py:4335-4339 treats every raw @_all as a self-mention, and _admit() applies that result to required-mention group traffic at :4278.

Problems

• tests/gateway/test_feishu.py:3543-3553 currently asserts that an @_all message without a bot mention is admitted. This patch reverses that behavior but does not update the regression test.
• The documented contract would become stale: website/docs/user-guide/messaging/feishu.md:238 and the zh-Hans counterpart at website/i18n/zh-Hans/docusaurus-plugin-content-docs/current/user-guide/messaging/feishu.md:204 say @all satisfies the gate.
• This is a compatibility decision: linked competing PR #60910 preserves the existing default through an opt-out configuration, while this patch changes it unconditionally.

Suggested changes

• If unconditional removal is selected, update the TestGroupMentionAtAll expectation and add explicit-@bot coverage for the same gate.
• Update both documentation statements to require an explicit bot mention.

Automated hermes-sweeper review.

[teknium1]

Removing this branch reverses tests/gateway/test_feishu.py:3543-3553, which currently asserts that an @_all-only group message is admitted. Please update that regression test and add an explicit bot-mention case so the new gate behavior is covered.