Skip to content

fix(feishu): ignore @所有人/@everyone mentions in group chats #59347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mason-zy wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −3
Open

fix(feishu): ignore @所有人/@everyone mentions in group chats #59347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions plugins/platforms/feishu/adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4329,10 +4329,9 @@ def _allow_group_message(
# --- Mention detection ----------------------------------------------------

def _mentions_self(self, message: Any) -> bool:
# @_all is Feishu's @everyone placeholder.
# Fix #33723: @_all (@everyone) no longer treated as self-mention —
# stops the bot replying to every @所有人 group announcement. (@Mason-zy)
raw_content = getattr(message, "content", "") or ""
if "@_all" in raw_content:
return True
mentions = getattr(message, "mentions", None) or []
if mentions and self._message_mentions_bot(mentions):

@teknium1 teknium1 Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this branch reverses tests/gateway/test_feishu.py:3543-3553, which currently asserts that an @_all-only group message is admitted. Please update that regression test and add an explicit bot-mention case so the new gate behavior is covered.

return True
Expand Down