feat(feishu): add ignore_at_all config to opt out of @everyone triggering the bot

[glow1128]

Summary

Add an ignore_at_all configuration option to the Feishu gateway adapter, allowing users to prevent @所有人 (@everyone) from counting as a bot mention in group chats.

By default, the bot still responds to @所有人 (backward compatible), but this can be turned off via config or environment variable.

Motivation

Currently, the Feishu bot responds to @所有人 (@everyone) messages in groups because _mentions_self() treats @_all (Feishu's internal @everyone placeholder) as equivalent to an explicit @bot mention. This is often undesirable — group admins frequently use @所有人 for announcements that are not directed at the bot, causing unnecessary and noisy responses.

Users should be able to opt out of this behavior so the bot only responds to explicit @bot mentions.

Changes

• plugins/platforms/feishu/adapter.py:

  • Add ignore_at_all: bool = False to FeishuAdapterSettings (default: False, backward compatible)
  • Add FEISHU_IGNORE_AT_ALL env var support in FeishuAdapter._load_settings()
  • Add ignore_at_all config key support via extra.get("ignore_at_all", ...)
  • Apply setting in _apply_settings() → self._ignore_at_all
  • Gate the @_all check in _mentions_self() on not self._ignore_at_all

• tests/gateway/test_feishu.py:

  • Add TestIgnoreAtAll test class with 4 tests:
    • test_ignore_at_all_rejects_at_everyone_message — @_all is rejected when ignore_at_all=true
    • test_default_ignore_at_all_false_accepts_at_everyone — default behavior preserved
    • test_ignore_at_all_does_not_affect_explicit_bot_mention — direct @bot still works
    • test_ignore_at_all_does_not_affect_dm — DMs bypass mention gate regardless

• website/docs/user-guide/messaging/feishu.md:

  • Add "Ignoring @everyone" section documenting the new config

• website/i18n/zh-Hans/.../feishu.md:

  • Add corresponding Chinese documentation

Configuration

# config.yaml
feishu:
  ignore_at_all: true

Or via environment variable:

FEISHU_IGNORE_AT_ALL=true

Behavior when ignore_at_all=true

• @所有人 / @everyone messages are not treated as mentioning the bot.
• Direct @bot mentions still work as expected.
• DMs are unaffected (they always bypass the mention gate).
• The group policy (open / allowlist / disabled) is still enforced independently.

Backward Compatibility

Fully backward compatible. Default is ignore_at_all: false, preserving existing behavior where @所有人 counts as a bot mention.

[alt-glitch]

This was generated by AI during triage.

Competing with #59347 for the same issue (#33723). This PR (#60910) makes the @everyone behavior configurable (ignore_at_all, default off, backward-compatible), whereas #59347 removes the @_all self-mention branch unconditionally. Cross-linking so a maintainer can pick the preferred approach; not a duplicate.

[tonydwb]

Code Review Summary

Verdict: Comment (token read-only - maintainer approval needed)

PR 60910 adds an ignore_at_all configuration option to the Feishu integration, allowing users to opt out of bot responses when @everyone or @channel is used. Well-scoped (4 files, 127 additions, 1 deletion). No security issues, debug artifacts, or quality concerns detected. Implementation follows existing config patterns in the codebase.

LGTM - awaiting maintainer approval.

[glow1128]

Comparison with #59347

Thanks to the triage bot for cross-linking. Both PRs address #33723 — here is a summary of the tradeoffs so a maintainer can pick the preferred approach:

	#59347 (unconditional removal)	#60910 (configurable, this PR)
Default behavior	Breaking: @所有人 no longer triggers the bot	Preserved: @所有人 still triggers the bot (backward compatible)
Opt-in/opt-out	No choice — always ignored	ignore_at_all: true to opt out
Use cases covered	Only "never respond to @everyone"	Both "respond to @everyone" and "ignore @everyone"
Lines changed	2 additions, 3 deletions	127 additions, 1 deletion
Risk	Low (simple deletion)	Low (additive, default-off config)

Why configurable is the safer default

Some deployments intentionally want the bot to respond to @所有人 — for example, a dedicated support channel where the bot should acknowledge every announcement. Removing the feature unconditionally in #59347 breaks that use case with no migration path.

This PR keeps the existing behavior as the default and adds an escape hatch for users who find it noisy. The cost is a few extra lines of config wiring + tests, but the benefit is zero breakage for existing users.

If a maintainer prefers the unconditional approach, I am happy to rework this PR to match — but I would recommend at minimum a deprecation period (e.g., log a warning when @_all triggers the bot, then remove in a future release) rather than a silent behavior change.

[tonydwb]

Code Review Summary

Verdict: Comment (127 additions — Feishu ignore_at_all config to opt out of @everyone)

Scope

Adds ignore_at_all config option for Feishu to opt out of @everyone notifications.

Observations

• Platform-specific quality-of-life feature.
• The existing 1 review is a COMMENT-only (not APPROVED) — this is a fresh formal review.
• Well-scoped addition with a clear user benefit.

Recommendation

Human reviewer familiar with Feishu bot behavior should confirm the config properly gates @everyone without breaking other at-mentions.

---

Reviewed by Hermes Agent

[teknium1]

Thanks for preserving the existing default while adding the requested opt-out. The underlying behavior is present on current main: plugins/platforms/feishu/adapter.py:4331-4335 classifies @_all as a self-mention, and _admit() applies that result at :4274.

Problems

• The documented feishu.ignore_at_all: true path is not currently wired. The plugin YAML bridge at plugins/platforms/feishu/adapter.py:5618-5627 handles only allow_bots, and the generic bridge in gateway/config.py:1164-1250 does not include ignore_at_all. The added tests cover only FEISHU_IGNORE_AT_ALL, so this regression is not detected.
• Add FEISHU_IGNORE_AT_ALL to both existing environment-variable tables (website/docs/user-guide/messaging/feishu.md:539-558 and the zh-Hans counterpart at :482-500).

Suggested changes

• Bridge feishu.ignore_at_all into the adapter configuration, and add a load_gateway_config() integration test using a temporary HERMES_HOME.

Automated hermes-sweeper review.

[teknium1]

This documented top-level YAML key is not wired by the current Feishu configuration bridge: _apply_yaml_config() only handles allow_bots (plugins/platforms/feishu/adapter.py:5618-5627), and the shared gateway bridge has no ignore_at_all key. Please add that bridge and a load_gateway_config() regression test.