fix(feishu): ignore @所有人/@everyone mentions in group chats - #57
Merged
Conversation
Backport of NousResearch/hermes-agent#59347 (upstream issue #33723). _mentions_self() treated @_all (Feishu @everyone placeholder) as a self-mention, so @所有人 announcements triggered the bot in groups. Drop that branch — real @bot mentions still work via the ID-based mention detection paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of upstream NousResearch/hermes-agent#59347 (issue #33723).
Problem
In Feishu group chats, the bot replies to every
@所有人(@everyone) announcement, even when not explicitly mentioned.Root cause
_mentions_self()inhermes-agent/plugins/platforms/feishu/adapter.pyreturns True for any message containing@_all(Feishu's@everyoneplaceholder), bypassing therequire_mentiongate.Fix
Drop the
@_all → return Truebranch. The other two mention paths (_message_mentions_botby ID,_post_mentions_botbyis_self) do not match@everyone, so real@botmentions are unaffected.@所有人 review please@botname hey