gateway: respect explicit 'enabled: false' for plugin-owned platforms - #34733
Closed
rp-keeran wants to merge 1 commit into
Closed
gateway: respect explicit 'enabled: false' for plugin-owned platforms#34733rp-keeran wants to merge 1 commit into
rp-keeran wants to merge 1 commit into
Conversation
The env-override registry pass re-enabled any platform whose plugin dependency check passed, overriding an explicit 'enabled: false' in config.yaml — e.g. Discord with no bot token got flipped back on and retried pointlessly. Skip platforms that were explicitly disabled.
alt-glitch
added
type/bug
Collaborator
13 tasks
Contributor
|
Thanks for the focused gateway fix. This is already implemented on current
Automated hermes-sweeper review. |
teknium1
added
the
sweeper:implemented-on-main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The env-override registry pass re-enabled any platform whose plugin dependency check passed, overriding an explicit
enabled: falseinconfig.yaml. A platform like Discord with no bot token would be flipped back on and retried pointlessly. Guards the loop to skip platforms that were explicitly disabled.