Skip to content

fix: respect explicit plugin platform disables - #32527

Closed
NicoMetaBreakThrough wants to merge 1 commit into
NousResearch:mainfrom
NicoMetaBreakThrough:fix/respect-explicit-platform-disable
Closed

NicoMetaBreakThrough wants to merge 1 commit into
NousResearch:mainfrom
NicoMetaBreakThrough:fix/respect-explicit-platform-disable

Conversation

@NicoMetaBreakThrough

Copy link
Copy Markdown

Fixes plugin platform disable handling so explicit platform disables are respected.

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/gateway Gateway runner, session dispatch, delivery comp/plugins Plugin system and bundled plugins area/config Config system, migrations, profiles duplicate This issue or pull request already exists labels May 26, 2026
@alt-glitch

Copy link
Copy Markdown
Contributor

Duplicate of #31596 — same fix for _apply_env_overrides() ignoring explicit enabled: false on plugin platforms. Previous duplicates: #31665, #31676, #32148.

@NicoMetaBreakThrough

Copy link
Copy Markdown
Author

Thanks for pointing that out. I saw #31596 is currently conflicting, while this PR is mergeable against main. Happy to close this if maintainers prefer to continue with #31596, but leaving it open in case this is useful as a clean/current branch.

@teknium1

Copy link
Copy Markdown
Collaborator

Thanks for the focused gateway regression fix. This is now implemented on current main; this automated hermes-sweeper review found the PR redundant.

  • gateway/config.py:1125 records _enabled_explicit for every platform block that explicitly sets enabled.
  • gateway/config.py:2156 skips plugin-registry auto-enablement when that platform is explicitly disabled, so plugin checks cannot reactivate it.
  • Commit 5600105478ffde29d7566b45421b100eaa29c4ef carried this behavior into the bundled-platform migration and shipped in v2026.7.1.

The member comment identifying #31596 as the canonical duplicate is consistent with the later implementation on main.

@teknium1 teknium1 closed this Jul 13, 2026
@teknium1 teknium1 added the sweeper:implemented-on-main Sweeper: behavior already present on current main label Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Config system, migrations, profiles comp/gateway Gateway runner, session dispatch, delivery comp/plugins Plugin system and bundled plugins duplicate This issue or pull request already exists P2 Medium — degraded but workaround exists sweeper:implemented-on-main Sweeper: behavior already present on current main type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants