Conversation
This was referenced May 24, 2026
Collaborator
|
Thanks for the focused gateway regression fix. This is now implemented on current
The linked issue discussion for #31049 also records the broader plugin auto-enable/reconnect behavior as resolved on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes registry-driven gateway plugin platform activation so an explicit
enabled: falseconfiguration is respected even when plugin auto-detection would otherwise enable the platform.Related Issue
Fixes #31049
Type of Change
Changes Made
enabled: falsefor registry-driven plugin platforms during gateway env overrides.check_fn()passes.How to Test
scripts/run_tests.sh tests/gateway/test_plugin_platform_explicit_disable.py— 2 passedpython -m pytest tests/gateway/test_bluebubbles.py tests/gateway/test_whatsapp_group_gating.py tests/gateway/test_plugin_platform_explicit_disable.py -q -o 'addopts='— 77 passedTested Platforms
Reviewer Notes
Pre-PR review was run through Hermes review-agent and OpenCode reviewers. No blocking findings remained; draft PR opened to let upstream CI and maintainers review.
Checklist