Skip to content

fix(gateway): respect explicit platform disables - #31676

Closed
ArktosIO wants to merge 1 commit into
NousResearch:mainfrom
ArktosIO:fix/respect-explicit-platform-disable
Closed

fix(gateway): respect explicit platform disables#31676
ArktosIO wants to merge 1 commit into
NousResearch:mainfrom
ArktosIO:fix/respect-explicit-platform-disable

Conversation

@ArktosIO

Copy link
Copy Markdown

Summary

  • Respect explicit platforms.<name>.enabled=false settings during plugin platform auto-enable.
  • Preserve the explicit enabled marker for all platforms, not just Slack.
  • Add a regression test covering Discord remaining disabled when its dependency check passes.

Test plan

  • ./venv/bin/python -m pytest tests/gateway/test_gateway_plugin_platform_disable.py -q -o 'addopts='
  • ./venv/bin/python -m pytest tests/test_gateway_streaming_nested_config.py tests/gateway/test_gateway_plugin_platform_disable.py -q -o 'addopts='

@ArktosIO ArktosIO closed this May 24, 2026
@ArktosIO
ArktosIO deleted the fix/respect-explicit-platform-disable branch May 24, 2026 21:37
@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/gateway Gateway runner, session dispatch, delivery comp/plugins Plugin system and bundled plugins area/config Config system, migrations, profiles duplicate This issue or pull request already exists labels May 24, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Duplicate of #31596 (and #31665). All three PRs fix the same bug: _apply_env_overrides() in gateway/config.py ignores explicit enabled: false for plugin platforms. #31596 was first and takes a cleaner approach (checks enabled is False directly without requiring an _enabled_explicit marker).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Config system, migrations, profiles comp/gateway Gateway runner, session dispatch, delivery comp/plugins Plugin system and bundled plugins duplicate This issue or pull request already exists P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants