ghcide: include and configure additional specific package versions#76103
Closed
mdorman wants to merge 19 commits intoNixOS:haskell-updatesfrom
Closed
ghcide: include and configure additional specific package versions#76103mdorman wants to merge 19 commits intoNixOS:haskell-updatesfrom
mdorman wants to merge 19 commits intoNixOS:haskell-updatesfrom
Conversation
This update was generated by hackage2nix v2.15.0-9-g650d530 from Hackage revision commercialhaskell/all-cabal-hashes@dc5b0e7.
This update was generated by hackage2nix v2.15.0-9-g650d530 from Hackage revision commercialhaskell/all-cabal-hashes@b2a082b.
haskellPackages.glirc is a "Console IRC Client." I've added a doJailbreak to fix the build (thanks @infinisil) and added it to top-level/all-packages.nix so people can find and install it as they would normally. Would be nice to make this build in a way that allows the OTR extension to be enabled. One thing at a time....
glirc: init at 2.33.1
This update was generated by hackage2nix v2.15.0-11-g2fb6f7e from Hackage revision commercialhaskell/all-cabal-hashes@4fa8739.
haskellPackages.snap-server: patch for network >= 3.0
spago: add update script for automatically updating to new versions
This PR fixes dhall_1_28_0, dhall-bash_1_0_25, and dhall-json_1_6_0 so they build. They all require a newer version of prettyprinter than we get from the LTS package set. This is from NixOS#75931 by @ijaketak. Co-authored-by: Keito Kajitani <ijaketak@gmail.com>
haskellPackages.dhall_1_28_0: fix overrides so it builds
This adds dhall-1.27.0 to extra-packages in configuration-hackage2nix.yaml. dhall-1.27.0 is used by spago, so this package needs to be available.
…l_1_27_0 haskellPackages.dhall_1_27_0: generate this package
haskell-lsp: Added 0.18.* to extra-packages for ghcide
Builds fine now.
haskellPackages.postgresql-simple-url: mark unbroken
In addition to the haskell-lsp and haskell-lsp-types, ghcide is tied to particular versions of lsp-test, hie-bios and shake, so we need to keep them around if it is to work.
peti
force-pushed
the
haskell-updates
branch
from
6484351 to
1f79abf
Compare
Member
|
cc @turion and @mgttlinger who have also taken a look at this. |
cdepillabout
added
the
6.topic: haskell
10 tasks
Member
|
Personally, I believe that these extensive overrides in Nixpkgs are a step in the wrong direction. I'd much rather see that we cooperate with upstream to make sure that |
peti
force-pushed
the
haskell-updates
branch
2 times, most recently
from
1f7024e to
7d2cc64
Compare
peti
force-pushed
the
haskell-updates
branch
from
d3a751a to
aa46cdd
Compare
peti
force-pushed
the
haskell-updates
branch
from
aa46cdd to
fdd64fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
In addition to the haskell-lsp and haskell-lsp-types, ghcide is tied
to particular versions of lsp-test, hie-bios and shake, so we need to
keep them around if it is to work.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @peti