Skip to content

glirc: init at 2.33.1#75945

Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
Kiwi:glirc2
Dec 19, 2019
Merged

glirc: init at 2.33.1#75945
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
Kiwi:glirc2

Conversation

@Kiwi
Copy link
Copy Markdown
Member

@Kiwi Kiwi commented Dec 19, 2019

haskellPackages.glirc is a "Console IRC Client." I've added a doJailbreak
to fix the build (thanks @infinisil) and added it to top-level/all-packages.nix
so people can find and install it as they would normally.

Would be nice to make this build in a way that allows the OTR extension to be
enabled. One thing at a time....

Motivation for this change

glirc2 is my favorite IRC client and I'd like it to be easier to install and for it to stop being marked broken. :(

It has an OTR extension that I'd like to enable but I'm not sure how to yet. Right now getting it as a regular package that can build is a good start.

Things done

Added doJailbreak to glirc to make it build. Removed glirc from the yaml list of failing builds. Added glirc to all-packages.nix

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md. 😏 I think (hope) so
Notify maintainers

cc @

@ofborg ofborg bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Dec 19, 2019
@cdepillabout
Copy link
Copy Markdown
Member

@Kiwi Thanks for this PR.

Could you rebase this on top of the haskell-updates branch?

Also, if you'd like this to never be marked broken, you can add yourself as a maintainer for this package:

We would expect you to fix up glirc if it ever breaks in the future.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 19, 2019
@Kiwi Kiwi changed the base branch from master to haskell-updates December 19, 2019 15:14
@Kiwi
Copy link
Copy Markdown
Member Author

Kiwi commented Dec 19, 2019

@Kiwi Thanks for this PR.

Could you rebase this on top of the haskell-updates branch?

Also, if you'd like this to never be marked broken, you can add yourself as a maintainer for this package:

We would expect you to fix up glirc if it ever breaks in the future.

I am trying to rebase but it seems to not be going well...

I believe to have done this properly now.

Though the tests are failing so I'm not sure what's going on.

haskellPackages.glirc is a "Console IRC Client." I've added a doJailbreak
to fix the build (thanks @infinisil) and added it to top-level/all-packages.nix
so people can find and install it as they would normally.

Would be nice to make this build in a way that allows the OTR extension to be
enabled. One thing at a time....
@cdepillabout
Copy link
Copy Markdown
Member

@Kiwi This builds and appears to work. Thanks for the quick turn-around time on this!

This should be marked unbroken when #75857 is updated and merged into master.

@cdepillabout cdepillabout merged commit 6266c98 into NixOS:haskell-updates Dec 19, 2019
@Kiwi Kiwi deleted the glirc2 branch January 10, 2020 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants