haskellPackages.dhall_1_28_0: fix overrides so it builds#76079
Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom Dec 20, 2019
Merged
haskellPackages.dhall_1_28_0: fix overrides so it builds#76079cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
Conversation
This PR fixes dhall_1_28_0, dhall-bash_1_0_25, and dhall-json_1_6_0 so they build. They all require a newer version of prettyprinter than we get from the LTS package set. This is from NixOS#75931 by @ijaketak. Co-authored-by: Keito Kajitani <ijaketak@gmail.com>
Member
Author
|
@GrahamcOfBorg build haskellPackages.dhall-bash_1_0_25 haskellPackages.dhall_1_28_0 haskellPackages.dhall-json_1_6_0 |
10 tasks
Member
Author
|
This builds cleanly on x86_64 and darwin, so I'm going to go ahead and merge in. Thanks @ijaketak! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes dhall_1_28_0, dhall-bash_1_0_25, and dhall-json_1_6_0 so
they build.
They all require a newer version of prettyprinter than we get from the
LTS package set.
This is from #75931 by @ijaketak.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @