haskellPackages.snap-server: patch for network >= 3.0#75882
Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom Dec 20, 2019
Merged
haskellPackages.snap-server: patch for network >= 3.0#75882cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
Conversation
ba74f97 to
fe3713f
Compare
Member
|
@jerith666 Sorry I missed this earlier, but could you rebase this PR on the |
jonringer
reviewed
Dec 19, 2019
Member
|
thanks for this @jerith666 I was about to do this myself so you saved me some time:D I can confirm this builds fine for me on nixos and that it fixes broken build of |
fe3713f to
062d582
Compare
Contributor
Author
|
comments added and rebased |
Contributor
|
there's a conflict, please rebase |
062d582 to
f8a4352
Compare
Contributor
Author
|
rebased to resolve the conflict & force-pushed |
Member
|
@jerith666 Thanks for working with us on fixing this up. Looks good. I've tested that haskellPackages.snap-server now builds, so I am merging this in. This should be available on |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @peti
patches are from snapframework/snap-server#126