Fixes for GHC 8.8.1#67709
Merged
basvandijk merged 22 commits intoNixOS:haskell-updatesfrom Sep 2, 2019
Merged
Conversation
added 5 commits
August 29, 2019 13:03
This was referenced Aug 29, 2019
ofborg
bot
added
the
6.topic: haskell
ofborg
bot
added
10.rebuild-darwin: 0
ofborg
bot
added
10.rebuild-darwin: 0
Member
|
@GrahamcOfBorg build haskell.packages.ghc881.foundation haskell.packages.ghc881.socks haskell.packages.ghc881.aeson haskell.packages.ghc881.polyparse haskell.packages.ghc881.cabal-doctest haskell.packages.ghc881.dlist haskell.packages.ghc881.happy haskell.packages.ghc881.attoparsec haskell.packages.ghc881.th-lift haskell.packages.ghc881.th-abstraction haskell.packages.ghc881.unordered-containers haskell.packages.ghc881.haskell-src-exts |
cdepillabout
approved these changes
Aug 29, 2019
Member
cdepillabout
left a comment
cdepillabout
left a comment
There was a problem hiding this comment.
LGTM other than the cabal-doctest_1_0_7 thing.
Member
|
@GrahamcOfBorg build haskell.packages.ghc881.memory haskell.packages.ghc881.cabal-doctest |
added 8 commits
August 29, 2019 17:42
basvandijk
approved these changes
Sep 2, 2019
Member
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @