Skip to content

haskell.packages.ghc881.haskell-src-exts: fix build#67653

Closed
vaibhavsagar wants to merge 1 commit intoNixOS:masterfrom
vaibhavsagar:ghc881-haskell-src-exts
Closed

haskell.packages.ghc881.haskell-src-exts: fix build#67653
vaibhavsagar wants to merge 1 commit intoNixOS:masterfrom
vaibhavsagar:ghc881-haskell-src-exts

Conversation

@vaibhavsagar
Copy link
Member

@vaibhavsagar vaibhavsagar commented Aug 28, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@vaibhavsagar
Copy link
Member Author

vaibhavsagar commented Aug 28, 2019

This depends on #67651.

@ofborg ofborg bot added 6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 28, 2019
@jonringer
Copy link
Contributor

jonringer commented Aug 29, 2019

@vaibhavsagar it may be worthwhile to combine all the related fix-build PR's into #67651 since they all rely on it.

@cdepillabout cdepillabout mentioned this pull request Aug 29, 2019
Closed
10 tasks
@vaibhavsagar
Copy link
Member Author

vaibhavsagar commented Aug 29, 2019

Closed in favour of #67709.

@vaibhavsagar vaibhavsagar deleted the ghc881-haskell-src-exts branch August 29, 2019 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vaibhavsagar @jonringer