Skip to content

[WIP] Build nixpkgs with gcc 8 by default#63132

Merged
FRidh merged 2533 commits intostagingfrom
gcc-8
Sep 8, 2019
Merged

[WIP] Build nixpkgs with gcc 8 by default#63132
FRidh merged 2533 commits intostagingfrom
gcc-8

Conversation

@vcunat
Copy link
Member

@vcunat vcunat commented Jun 14, 2019

Reopened #53760

@vcunat vcunat changed the base branch from master to staging June 14, 2019 16:03
@vcunat
Copy link
Member Author

vcunat commented Jun 14, 2019

Unfortunately it will need some work, probably a rebase after the months.

@vcunat vcunat mentioned this pull request Jun 14, 2019
Merged
@fpletz
Copy link
Member

fpletz commented Jun 14, 2019 •
edited
Loading

@vcunat Do you intend to work on this? Otherwise I'd like to try to do the rebase.

@vcunat
Copy link
Member Author

vcunat commented Jun 14, 2019

I do not, at least not immediately.

@ofborg ofborg bot added 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 2.status: merge conflict This PR has merge conflicts with the target branch labels Jun 14, 2019
@FRidh FRidh added this to the 19.09 milestone Jun 15, 2019
@ofborg ofborg bot removed 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 2.status: merge conflict This PR has merge conflicts with the target branch labels Jun 17, 2019
@fpletz
Copy link
Member

fpletz commented Jun 17, 2019

Rebased. Here is the jobset on Hydra: https://hydra.nixos.org/jobset/nixpkgs/gcc8

@vcunat
Copy link
Member Author

vcunat commented Jun 17, 2019

BTW, gcc 9 should be already viable as well. Whole Fedora has switched months ago. Still, it might be easier to do these steps separately, for better grouping of similar problems.

@ofborg ofborg bot added 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jun 17, 2019
@tobim
Copy link
Contributor

tobim commented Aug 13, 2019

I'd like to help with this PR, I hope there is still a chance for 19.09.
Here is a cutout of the most problematic dependencies (generated with eval-report):

name count
aarch64-linux llvm-7.1.0 4491
x86_64-linux qtscript-5.12.0 444
aarch64-linux perl5.30.0-B-C-1.55 330
x86_64-linux qt-4.8.7 229
aarch64-linux linux-4.19.51-libre-src 81
aarch64-linux xapian-1.4.11 68
aarch64-linux linux-5.2-rc4 64
x86_64-linux qtscript-5.11.3 48
aarch64-linux python2.7-httpretty-0.9.6 39
aarch64-linux linux-4.9.181 28
aarch64-linux linux-4.4.181 27
aarch64-linux python3.7-Faker-1.0.7 17
aarch64-linux python3.7-notebook-5.7.8 15
x86_64-linux python3.7-scikit-learn-0.20.3 15
aarch64-linux buildbot_www-2.3.1-py3-none-any.whl 14
x86_64-linux xen-4.8.3 14
x86_64-linux gmime-3.2.3 13
aarch64-linux libc++abi-7.1.0 12
aarch64-linux llvm-3.8.1 12
x86_64-linux python2.7-Faker-1.0.7 10
x86_64-linux arrow-cpp-0.13.0 10
aarch64-linux epson-inkjet-printer-escpr2-1.0.29-1lsb3.2.src.rpm 10
aarch64-linux python3.7-pycurl-7.43.0.2 10
x86_64-linux cwrap-5.1 6
aarch64-linux llvm-4.0.1 6
aarch64-linux ucto-v0.9.6 5
aarch64-linux buildbot-grid-view-2.3.1.tar.gz 5
aarch64-linux buildbot-waterfall-view-2.3.1.tar.gz 5
aarch64-linux nlohmann_json-3.6.1 5
aarch64-linux sbcl-1.5.3 5

@tobim
Copy link
Contributor

tobim commented Aug 13, 2019

For qt4: we could reuse the AUR patch: https://aur.archlinux.org/cgit/aur.git/plain/qt4-gcc8.patch?h=qt4, or do sed -i in postPatch.
For qt5: 5.12 is fixed in patchlevel 2, latest is 4, we are at .0.
qt-5.11 and lower are not patched and need a similar patch as qt4.

@tobim
Copy link
Contributor

tobim commented Aug 13, 2019

llvm should already be fixed thanks to #63928.

@vcunat vcunat requested a review from basvandijk as a code owner August 25, 2019 16:56
infinisil and others added 22 commits September 3, 2019 17:46
@infinisil
Merge pull request #55510 from florianjacob/declarative-printers
ad13ebe 
nixos/printers: declarative configuration
@peti
openshot-qt: fix title generator
d7bbcdf 
@ferdnyc has kindly provided a patch for our Nix-specific permission
issue OpenShot/openshot-qt#2972.

Fixes #32898.
Fixes #48591.
Related to #55683.
coreboot-utils: init at 4.10
d977d48 
Build various tools from the coreboot tree with a generic builder for better
maintainability and provide a buildEnv with all of them, similar to other
distributions' coreboot-utils package.
@worldofpeace
Merge pull request #67836 from petabyteboy/feature/corebootutils
62973dd 
coreboot-utils: init at 4.10
@jtojnar
Merge pull request #68008 from jtojnar/ibus-fixes
47df740 
ibus-engines.hangul: fix ibus-setup-hangul
@flokli @worldofpeace
biber: fix currently broken tests
5c0478a
@worldofpeace
Merge pull request #67926 from flokli/fix-biber-tests
460927a 
biber: fix currently broken tests
@worldofpeace
treewide: don't use single quotes with placeholder
59e68d3
@worldofpeace
Merge pull request #68016 from worldofpeace/no-single-quote-placeholder
26b8a0a 
treewide: don't use single quotes with placeholder
@infinisil
Merge pull request #64552 from evanjs/feature/openrazer-2.3.1
ce944b4 
openrazer: init at 2.6.0
@srhb
Merge pull request #68001 from johanot/fix-cherrypy
ce8cd5f 
python3Packages.cherrypy: fix tests after upgrade to pytest5
@fpletz
llvm_4: fix build with gcc8
e3434a3
@fpletz
ocamlPackages.llvm: build with llvm_8
e7b6d87
@fpletz
bap: build with llvm_8
bd85a83
@srhb
Merge pull request #68012 from jojosch/add-maintainer
9266577 
maintainers: add jojosch
@manveru @alyssais
ruby.withPackages: init
1f49035 
Co-authored-by: Alyssa Ross <hi@alyssa.is>
@fpletz
irods: build with current version of llvm
3a7a990
@fpletz
llvm_38: drop since it doesn't build with gcc8
be9901a
@fpletz
Revert "xbps: fix build with gcc8"
d512362 
This reverts commit f0a1f7e.
@fpletz
Merge remote-tracking branch 'origin/master' into gcc-8
de85797
@fpletz
highlight: build with standard llvm version on darwin
4d85d28
@globin
arangodb_3_2: remove
087ba0e 
doesn't support gcc 8
@globin globin mentioned this pull request Sep 3, 2019
Merged
@FRidh
Copy link
Member

FRidh commented Sep 6, 2019

This is now in staging-next.
https://hydra.nixos.org/eval/1541002

@vcunat
Copy link
Member Author

vcunat commented Sep 8, 2019

No, it isn't, at least not the current version e729736 :-/ Bitten by the rebasing workflow?

@vcunat vcunat mentioned this pull request Sep 8, 2019
Merged
10 tasks
@vcunat
Copy link
Member Author

vcunat commented Sep 8, 2019

As I'm against history-rewriting on staging-next, I suggest we merge this commit to staging-next and have a careful look at the conflicts and the overall merge result.

@FRidh
Copy link
Member

FRidh commented Sep 8, 2019 •
edited
Loading

Seems we have a gcc8 and gcc-8 branch. I merged the gcc8 branch instead of this gcc-8.

@vcunat
Copy link
Member Author

vcunat commented Sep 8, 2019

Bad luck; first GitHub decided it got merged even if it didn't, and now this naming confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alyssais alyssais Awaiting requested review from alyssais

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@zimbatm zimbatm Awaiting requested review from zimbatm

@basvandijk basvandijk Awaiting requested review from basvandijk

@edolstra edolstra Awaiting requested review from edolstra

@edwtjo edwtjo Awaiting requested review from edwtjo

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@FRidh FRidh Awaiting requested review from FRidh

@infinisil infinisil Awaiting requested review from infinisil

@joachifm joachifm Awaiting requested review from joachifm

@LnL7 LnL7 Awaiting requested review from LnL7

@Mic92 Mic92 Awaiting requested review from Mic92

@nbp nbp Awaiting requested review from nbp

@peti peti Awaiting requested review from peti

@Profpatsch Profpatsch Awaiting requested review from Profpatsch

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@ttuegel ttuegel Awaiting requested review from ttuegel

@adisbladis adisbladis Awaiting requested review from adisbladis

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

None yet

Milestone

19.09

Development

Successfully merging this pull request may close these issues.