Skip to content

treewide: don't use single quotes with placeholder#68016

Merged
worldofpeace merged 1 commit intoNixOS:masterfrom
worldofpeace:no-single-quote-placeholder
Sep 3, 2019
Merged

treewide: don't use single quotes with placeholder#68016
worldofpeace merged 1 commit intoNixOS:masterfrom
worldofpeace:no-single-quote-placeholder

Conversation

@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Sep 3, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: pantheon The Pantheon desktop environment 6.topic: xfce The Xfce Desktop Environment labels Sep 3, 2019
@ofborg ofborg bot requested a review from romildo September 3, 2019 16:58
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 3, 2019
@worldofpeace worldofpeace force-pushed the no-single-quote-placeholder branch from 495706c to 59e68d3 Compare September 3, 2019 17:01
@worldofpeace worldofpeace merged commit 26b8a0a into NixOS:master Sep 3, 2019
@worldofpeace worldofpeace deleted the no-single-quote-placeholder branch September 3, 2019 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romildo romildo Awaiting requested review from romildo

1 more reviewer

@jonringer jonringer jonringer left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: pantheon The Pantheon desktop environment 6.topic: xfce The Xfce Desktop Environment 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@worldofpeace @jonringer