Skip to content

python3Packages.cherrypy: fix tests after upgrade to pytest5#68001

Merged
srhb merged 1 commit intoNixOS:masterfrom
johanot:fix-cherrypy
Sep 3, 2019
Merged

python3Packages.cherrypy: fix tests after upgrade to pytest5#68001
srhb merged 1 commit intoNixOS:masterfrom
johanot:fix-cherrypy

Conversation

@johanot
Copy link
Contributor

@johanot johanot commented Sep 3, 2019

Motivation for this change

Fix cherrypy python3 build after pytest5 upgrade broke the tests: b3ddab8
See cherrypy/cherrypy#1791 for reference.

@GrahamcOfBorg build python3Packages.cherrypy

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @FRidh

@johanot johanot requested a review from FRidh as a code owner September 3, 2019 10:57
@ofborg ofborg bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 3, 2019
@FRidh
Copy link
Member

FRidh commented Sep 3, 2019

@GrahamcOfBorg build python3Packages.cherrypy

@johanot johanot mentioned this pull request Sep 3, 2019
Merged
10 tasks
@srhb
Copy link
Contributor

srhb commented Sep 3, 2019

Looks good!

@srhb srhb merged commit ce8cd5f into NixOS:master Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@johanot @FRidh @srhb