coreboot-utils: init at 4.10

[ghost]

Motivation for this change

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

Notify maintainers

cc @

[ghost]

@worldofpeace
I am aware it is not best practise to use custom phases, but I think the advantage here is that new tools can be easily added. If you see any better way to do this, I would like to see it.

[ghost]

One alternative I see is putting each tool in an own derivation, but using a generic expression for them. Do you think that's preferable?

[ghost]

I don't get why ofborg is failing

[ghost]

Ah, pmtools is an alias.

[worldofpeace]

@worldofpeace
I am aware it is not best practice to use custom phases, but I think the advantage here is that new tools can be easily added. If you see any better way to do this, I would like to see it.

I'd say ideally, coreboot would just have a Makefile in the util directory with targets for each of the utilities.

One alternative I see is putting each tool in an own derivation, but using a generic expression for them. Do you think that's preferable?

I'm not sure about putting each tool into it's own derivation.
Current disadvantage of coreboot-utils is that you can't have just one utility, so maybe split it.
Though it does seem to be more popular

• https://repology.org/project/coreboot-utils/versions

My only nit currently is that it looks a bit procedural, we could use loops to make it clearer.
Fake code looks like

makeFlags = [ 
  "PREFIX=${placeholder "out"}"
];

preBuild = ''
  cd util
'';

buildPhase = ''
  runHook preBuild

  for util in ...directories of tools; do
    make $makeFlags -C $util
  done

  runHook postBuild
'';

installPhase = ''
  ....similar thing as build phase
'';

postFixup = ''
  ...should wrap that program here
'';

[ghost]

@worldofpeace: I found it easier to solve it like this, please take a look

[ghost]

We should be good to go then :)

[worldofpeace]

I noticed when building i had to unpack the archive multiple times, but I guess there's no way around that.

[worldofpeace]

It looks like it tries to install things to sbin

├── bin
│   ├── acpidump-all -> /nix/store/50ydys5lgnqbv34rvpra2jwa7ys85g3l-acpidump-all-4.10/bin/acpidump-all
│   ├── amdfwtool -> /nix/store/b78wwi966a4an64gk19nhmkblzqp42wv-amdfwtool-4.10/bin/amdfwtool
│   ├── cbfs-compression-tool -> /nix/store/f1qvacrckyvnxshkdpl37gzf06zlhl2s-cbfstool-4.10/bin/cbfs-compression-tool
│   ├── cbfstool -> /nix/store/f1qvacrckyvnxshkdpl37gzf06zlhl2s-cbfstool-4.10/bin/cbfstool
│   ├── cbmem -> /nix/store/3nbj9bmrdnvg9s3a919kq3ns2wil93lz-cbmem-4.10/bin/cbmem
│   ├── ectool -> /nix/store/ypinf2l28mn05j5jdzx5szx5i0fx8dly-ectool-4.10/bin/ectool
│   ├── fmaptool -> /nix/store/f1qvacrckyvnxshkdpl37gzf06zlhl2s-cbfstool-4.10/bin/fmaptool
│   ├── ifdtool -> /nix/store/skwh2bdgjppksr4sn5nmw0cp4h4qnpxk-ifdtool-4.10/bin/ifdtool
│   ├── ifittool -> /nix/store/f1qvacrckyvnxshkdpl37gzf06zlhl2s-cbfstool-4.10/bin/ifittool
│   ├── ifwitool -> /nix/store/f1qvacrckyvnxshkdpl37gzf06zlhl2s-cbfstool-4.10/bin/ifwitool
│   ├── intelmetool -> /nix/store/hsf1rgq5aqv2bhjhlka1n574wzjaa5i2-intelmetool-4.10/bin/intelmetool
│   ├── inteltool -> /nix/store/8m36y393g2ikfnk9y04h84kklvif8jyw-inteltool-4.10/bin/inteltool
│   ├── msrtool -> /nix/store/cayfmg47wgliwmwz5cn77hmvwphr2601-msrtool-4.10/bin/msrtool
│   ├── nvramtool -> /nix/store/kcysznlapfr4cj3vz8nd6k8hbhaz3pgv-nvramtool-4.10/bin/nvramtool
│   ├── rmodtool -> /nix/store/f1qvacrckyvnxshkdpl37gzf06zlhl2s-cbfstool-4.10/bin/rmodtool
│   └── superiotool -> /nix/store/l28ay2p1ly63nz9dw3bddj8ls0z4r85d-superiotool-4.10/bin/superiotool
├── sbin
│   ├── cbmem -> /nix/store/3nbj9bmrdnvg9s3a919kq3ns2wil93lz-cbmem-4.10/sbin/cbmem
│   ├── ectool -> /nix/store/ypinf2l28mn05j5jdzx5szx5i0fx8dly-ectool-4.10/sbin/ectool
│   ├── intelmetool -> /nix/store/hsf1rgq5aqv2bhjhlka1n574wzjaa5i2-intelmetool-4.10/sbin/intelmetool
│   ├── inteltool -> /nix/store/8m36y393g2ikfnk9y04h84kklvif8jyw-inteltool-4.10/sbin/inteltool
│   ├── msrtool -> /nix/store/cayfmg47wgliwmwz5cn77hmvwphr2601-msrtool-4.10/sbin/msrtool
│   ├── nvramtool -> /nix/store/kcysznlapfr4cj3vz8nd6k8hbhaz3pgv-nvramtool-4.10/sbin/nvramtool
│   └── superiotool -> /nix/store/l28ay2p1ly63nz9dw3bddj8ls0z4r85d-superiotool-4.10/sbin/superiotool

and we have setup hook that moves these things, but it probably doesn't work because of duplication?
Perhaps look at which makefiles do this and install manually, or maybe there's a way to override it.

[ghost]

It looks like it tries to install things to sbin

├── bin
│   ├── acpidump-all -> /nix/store/50ydys5lgnqbv34rvpra2jwa7ys85g3l-acpidump-all-4.10/bin/acpidump-all
│   ├── amdfwtool -> /nix/store/b78wwi966a4an64gk19nhmkblzqp42wv-amdfwtool-4.10/bin/amdfwtool
│   ├── cbfs-compression-tool -> /nix/store/f1qvacrckyvnxshkdpl37gzf06zlhl2s-cbfstool-4.10/bin/cbfs-compression-tool
│   ├── cbfstool -> /nix/store/f1qvacrckyvnxshkdpl37gzf06zlhl2s-cbfstool-4.10/bin/cbfstool
│   ├── cbmem -> /nix/store/3nbj9bmrdnvg9s3a919kq3ns2wil93lz-cbmem-4.10/bin/cbmem
│   ├── ectool -> /nix/store/ypinf2l28mn05j5jdzx5szx5i0fx8dly-ectool-4.10/bin/ectool
│   ├── fmaptool -> /nix/store/f1qvacrckyvnxshkdpl37gzf06zlhl2s-cbfstool-4.10/bin/fmaptool
│   ├── ifdtool -> /nix/store/skwh2bdgjppksr4sn5nmw0cp4h4qnpxk-ifdtool-4.10/bin/ifdtool
│   ├── ifittool -> /nix/store/f1qvacrckyvnxshkdpl37gzf06zlhl2s-cbfstool-4.10/bin/ifittool
│   ├── ifwitool -> /nix/store/f1qvacrckyvnxshkdpl37gzf06zlhl2s-cbfstool-4.10/bin/ifwitool
│   ├── intelmetool -> /nix/store/hsf1rgq5aqv2bhjhlka1n574wzjaa5i2-intelmetool-4.10/bin/intelmetool
│   ├── inteltool -> /nix/store/8m36y393g2ikfnk9y04h84kklvif8jyw-inteltool-4.10/bin/inteltool
│   ├── msrtool -> /nix/store/cayfmg47wgliwmwz5cn77hmvwphr2601-msrtool-4.10/bin/msrtool
│   ├── nvramtool -> /nix/store/kcysznlapfr4cj3vz8nd6k8hbhaz3pgv-nvramtool-4.10/bin/nvramtool
│   ├── rmodtool -> /nix/store/f1qvacrckyvnxshkdpl37gzf06zlhl2s-cbfstool-4.10/bin/rmodtool
│   └── superiotool -> /nix/store/l28ay2p1ly63nz9dw3bddj8ls0z4r85d-superiotool-4.10/bin/superiotool
├── sbin
│   ├── cbmem -> /nix/store/3nbj9bmrdnvg9s3a919kq3ns2wil93lz-cbmem-4.10/sbin/cbmem
│   ├── ectool -> /nix/store/ypinf2l28mn05j5jdzx5szx5i0fx8dly-ectool-4.10/sbin/ectool
│   ├── intelmetool -> /nix/store/hsf1rgq5aqv2bhjhlka1n574wzjaa5i2-intelmetool-4.10/sbin/intelmetool
│   ├── inteltool -> /nix/store/8m36y393g2ikfnk9y04h84kklvif8jyw-inteltool-4.10/sbin/inteltool
│   ├── msrtool -> /nix/store/cayfmg47wgliwmwz5cn77hmvwphr2601-msrtool-4.10/sbin/msrtool
│   ├── nvramtool -> /nix/store/kcysznlapfr4cj3vz8nd6k8hbhaz3pgv-nvramtool-4.10/sbin/nvramtool
│   └── superiotool -> /nix/store/l28ay2p1ly63nz9dw3bddj8ls0z4r85d-superiotool-4.10/sbin/superiotool

and we have setup hook that moves these things, but it probably doesn't work because of duplication?
Perhaps look at which makefiles do this and install manually, or maybe there's a way to override it.

It moves the files, and then creates a symlink from sbin to bin so that things don't break. Is this a problem?

[worldofpeace]

It moves the files, and then creates a symlink from sbin to bin so that things don't break. Is this a problem?

Ahh, I forgot it was a buildEnv. So what happens is it works properly individually, but when they get merged with buildEnv sbin becomes an actual directory with symlinks to symlinks.
I think that's kinda messy for coreboot-utils, can you prune that away?

[ghost]

It moves the files, and then creates a symlink from sbin to bin so that things don't break. Is this a problem?

Ahh, I forgot it was a buildEnv. So what happens is it works properly individually, but when they get merged with buildEnv sbin becomes an actual directory with symlinks to symlinks.
I think that's kinda messy for coreboot-utils, can you prune that away?

Sure, done.

[worldofpeace]

LGTM, can you describe your changes in your commit body?

[ghost]

LGTM, can you describe your changes in your commit body?

Done

[worldofpeace]

Thanks for fixing this @petabyteboy ✨