fetchFromGitProvider: init (optional dynamically switchable after `<pkg>.overrideAttrs`) by ShamrockLee · Pull Request #462034 · NixOS/nixpkgs

ShamrockLee · 2025-11-15T20:12:22Z

This PR introduces fetchFromGitProvider, a general foundation for all other fetchFrom<Git hosting provider> constructors.

Not only can it choose between fetchgit (for Git-related features) and fetchgit (for hash stability) automatically, but it can optionally switch between fetchgit and fetchzip dynamically after <pkg>.overrideAttrs overriding based on the overridden arguments.

Such a black magic depends on the fact that fetchurl, fetchzip, and fetchgit pass arguments unconditionally (i.e., without the lib.optionalAttrs part of stdenv.mkDerivation ({ ... } // lib.optionalAttrs myCondition { ... })).
By making fetchgithub pass unconditionally to fetchgit, fetchzip, and stdenvNoCC.mkDerivation, dynamic switching is achievable.
The unconditional passing to stdenvNoCC.mkDerivation uses null as the generic hole-filling default value, and the unconditional passing to fetchgit is done in a depending PR listed below.

Depending PRs:

lib.makeOverridable: preserve constructor override and metadata attributes #461032
It fixes lib.makeOverridable so that it won't drop attributes from a callable attribute set it decorates.
This is necessary to implement any kind of fetchFromGitHub restructuring with lib.extendMkDerivation changes while keeping the automatic selection.
mkDerivation: make allowedReference/allowedRequisites nullable when __structuredAttrs is true #462141
It allows structured-attributes packages to pass allowReferences/allowRequisites unconditionally.
fetchgit: give leaveDotGit, nonConeMode, and sparseCheckout a default value null #462032
It enables fetchFromGitProvider (previously fetchFromGitHub) to pass leaveDotGit unconditionally.
fetchFromGitHub: converge arguments that determines useFetchGit #456226
Since fetchFromGitProvider abstracts out the fetcher-choosing part of fetchFromGitHub, we need to clean up fetchFromGitHub's fetcher choosing first.

Things done

Add a 👍 reaction to pull requests you find important.

ShamrockLee · 2025-11-17T12:57:53Z

`nixpkgs-review` result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 462034
Commit: 733b8b98584f72e7464c55a243ea5cc22e956010 (subsequent changes)
Merge: 9546d0bf09ba27607c9cb3279211ca0900196d65

Logs: https://github.com/ShamrockLee/nixpkgs-review-gha/actions/runs/19430058086

`x86_64-linux`

⏩ 2 packages blacklisted:

nixos-install-tools
tests.nixos-functions.nixos-test

✅ 47 packages built:

extra-container
nixos-container
nixpkgs-manual
tests.fetchFromBitbucket.withEncodedWhitespaceGit
tests.fetchFromGitHub.dumb-http-signed-tag
tests.fetchFromGitHub.fetchTags
tests.fetchFromGitHub.leave-git
tests.fetchFromGitHub.rootDir
tests.fetchFromGitHub.simple
tests.fetchFromGitHub.sparseCheckout
tests.fetchFromGitHub.sparseCheckoutNonConeMode
tests.fetchFromGitHub.submodule-deep
tests.fetchFromGitHub.submodule-leave-git
tests.fetchFromGitHub.submodule-leave-git-deep
tests.fetchFromGitHub.submodule-simple
tests.fetchPypiLegacy.fetchSimple
tests.fetchgit.dumb-http-signed-tag
tests.fetchgit.fetchTags
tests.fetchgit.leave-git
tests.fetchgit.prefetch-git-no-add-path
tests.fetchgit.rootDir
tests.fetchgit.simple
tests.fetchgit.sparseCheckout
tests.fetchgit.sparseCheckoutNonConeMode
tests.fetchgit.submodule-deep
tests.fetchgit.submodule-leave-git
tests.fetchgit.submodule-leave-git-deep
tests.fetchgit.submodule-simple
tests.fetchgit.withGitConfig
tests.fetchpatch2.decode
tests.fetchpatch2.fileWithApostrophe
tests.fetchpatch2.fileWithSpace
tests.fetchpatch2.full
tests.fetchpatch2.hunks
tests.fetchpatch2.relative
tests.fetchpatch2.simple
tests.fetchtorrent.http-link (tests.fetchtorrent.http-link-transmission)
tests.fetchtorrent.http-link-rqbit (tests.fetchtorrent.http-link-rqbit-flattened)
tests.fetchtorrent.http-link-rqbit-unflattened
tests.fetchtorrent.magnet-link (tests.fetchtorrent.magnet-link-transmission)
tests.fetchtorrent.magnet-link-rqbit (tests.fetchtorrent.magnet-link-rqbit-flattened)
tests.fetchtorrent.magnet-link-rqbit-unflattened
tests.fetchurl.header
tests.haskell.cabalSdist.assumptionLocalHasDirectReference
tests.haskell.cabalSdist.localHasNoDirectReference
tests.overriding
tests.testers.runCommand.bork

`aarch64-linux`

⏩ 2 packages blacklisted:

nixos-install-tools
tests.nixos-functions.nixos-test

✅ 47 packages built:

extra-container
nixos-container
nixpkgs-manual
tests.fetchFromBitbucket.withEncodedWhitespaceGit
tests.fetchFromGitHub.dumb-http-signed-tag
tests.fetchFromGitHub.fetchTags
tests.fetchFromGitHub.leave-git
tests.fetchFromGitHub.rootDir
tests.fetchFromGitHub.simple
tests.fetchFromGitHub.sparseCheckout
tests.fetchFromGitHub.sparseCheckoutNonConeMode
tests.fetchFromGitHub.submodule-deep
tests.fetchFromGitHub.submodule-leave-git
tests.fetchFromGitHub.submodule-leave-git-deep
tests.fetchFromGitHub.submodule-simple
tests.fetchPypiLegacy.fetchSimple
tests.fetchgit.dumb-http-signed-tag
tests.fetchgit.fetchTags
tests.fetchgit.leave-git
tests.fetchgit.prefetch-git-no-add-path
tests.fetchgit.rootDir
tests.fetchgit.simple
tests.fetchgit.sparseCheckout
tests.fetchgit.sparseCheckoutNonConeMode
tests.fetchgit.submodule-deep
tests.fetchgit.submodule-leave-git
tests.fetchgit.submodule-leave-git-deep
tests.fetchgit.submodule-simple
tests.fetchgit.withGitConfig
tests.fetchpatch2.decode
tests.fetchpatch2.fileWithApostrophe
tests.fetchpatch2.fileWithSpace
tests.fetchpatch2.full
tests.fetchpatch2.hunks
tests.fetchpatch2.relative
tests.fetchpatch2.simple
tests.fetchtorrent.http-link (tests.fetchtorrent.http-link-transmission)
tests.fetchtorrent.http-link-rqbit (tests.fetchtorrent.http-link-rqbit-flattened)
tests.fetchtorrent.http-link-rqbit-unflattened
tests.fetchtorrent.magnet-link (tests.fetchtorrent.magnet-link-transmission)
tests.fetchtorrent.magnet-link-rqbit (tests.fetchtorrent.magnet-link-rqbit-flattened)
tests.fetchtorrent.magnet-link-rqbit-unflattened
tests.fetchurl.header
tests.haskell.cabalSdist.assumptionLocalHasDirectReference
tests.haskell.cabalSdist.localHasNoDirectReference
tests.overriding
tests.testers.runCommand.bork

`x86_64-darwin` (sandbox = relaxed)

✅ 66 packages built:

nixpkgs-manual
tests.fetchDebianPatch.libPackage
tests.fetchDebianPatch.simple
tests.fetchFirefoxAddon.simple (tests.fetchFirefoxAddon.overridden-source)
tests.fetchFromBitbucket.withEncodedWhitespace
tests.fetchFromBitbucket.withEncodedWhitespaceGit
tests.fetchFromBitbucket.withoutWhitespace
tests.fetchFromGitHub.dumb-http-signed-tag
tests.fetchFromGitHub.fetchTags
tests.fetchFromGitHub.leave-git
tests.fetchFromGitHub.rootDir
tests.fetchFromGitHub.simple
tests.fetchFromGitHub.sparseCheckout
tests.fetchFromGitHub.sparseCheckoutNonConeMode
tests.fetchFromGitHub.submodule-deep
tests.fetchFromGitHub.submodule-leave-git
tests.fetchFromGitHub.submodule-leave-git-deep
tests.fetchFromGitHub.submodule-simple
tests.fetchNextcloudApp.simple-sha256
tests.fetchNextcloudApp.simple-sha512
tests.fetchPypiLegacy.fetchSimple
tests.fetchgit.dumb-http-signed-tag
tests.fetchgit.fetchTags
tests.fetchgit.leave-git
tests.fetchgit.prefetch-git-no-add-path
tests.fetchgit.rootDir
tests.fetchgit.simple
tests.fetchgit.sparseCheckout
tests.fetchgit.sparseCheckoutNonConeMode
tests.fetchgit.submodule-deep
tests.fetchgit.submodule-leave-git
tests.fetchgit.submodule-leave-git-deep
tests.fetchgit.submodule-simple
tests.fetchgit.withGitConfig
tests.fetchpatch.decode
tests.fetchpatch.fileWithApostrophe
tests.fetchpatch.fileWithSpace
tests.fetchpatch.full
tests.fetchpatch.hunks
tests.fetchpatch.relative
tests.fetchpatch.simple
tests.fetchpatch2.decode
tests.fetchpatch2.fileWithApostrophe
tests.fetchpatch2.fileWithSpace
tests.fetchpatch2.full
tests.fetchpatch2.hunks
tests.fetchpatch2.relative
tests.fetchpatch2.simple
tests.fetchtorrent.http-link (tests.fetchtorrent.http-link-transmission)
tests.fetchtorrent.http-link-rqbit (tests.fetchtorrent.http-link-rqbit-flattened)
tests.fetchtorrent.http-link-rqbit-unflattened
tests.fetchtorrent.magnet-link (tests.fetchtorrent.magnet-link-transmission)
tests.fetchtorrent.magnet-link-rqbit (tests.fetchtorrent.magnet-link-rqbit-flattened)
tests.fetchtorrent.magnet-link-rqbit-unflattened
tests.fetchurl.hashedMirrors
tests.fetchurl.header
tests.fetchurl.no-skipPostFetch
tests.fetchzip.hiddenDir
tests.fetchzip.postFetch
tests.fetchzip.simple
tests.haskell.cabalSdist.assumptionLocalHasDirectReference
tests.haskell.cabalSdist.localHasNoDirectReference
tests.overriding
tests.testers.runCommand.bork
tests.testers.runCommand.dns-resolution
tests.testers.runCommand.nonDefault-hash

`aarch64-darwin` (sandbox = relaxed)

❌ 1 package failed to build:

tests.testers.runCommand.bork

✅ 65 packages built:

nixpkgs-manual
tests.fetchDebianPatch.libPackage
tests.fetchDebianPatch.simple
tests.fetchFirefoxAddon.simple (tests.fetchFirefoxAddon.overridden-source)
tests.fetchFromBitbucket.withEncodedWhitespace
tests.fetchFromBitbucket.withEncodedWhitespaceGit
tests.fetchFromBitbucket.withoutWhitespace
tests.fetchFromGitHub.dumb-http-signed-tag
tests.fetchFromGitHub.fetchTags
tests.fetchFromGitHub.leave-git
tests.fetchFromGitHub.rootDir
tests.fetchFromGitHub.simple
tests.fetchFromGitHub.sparseCheckout
tests.fetchFromGitHub.sparseCheckoutNonConeMode
tests.fetchFromGitHub.submodule-deep
tests.fetchFromGitHub.submodule-leave-git
tests.fetchFromGitHub.submodule-leave-git-deep
tests.fetchFromGitHub.submodule-simple
tests.fetchNextcloudApp.simple-sha256
tests.fetchNextcloudApp.simple-sha512
tests.fetchPypiLegacy.fetchSimple
tests.fetchgit.dumb-http-signed-tag
tests.fetchgit.fetchTags
tests.fetchgit.leave-git
tests.fetchgit.prefetch-git-no-add-path
tests.fetchgit.rootDir
tests.fetchgit.simple
tests.fetchgit.sparseCheckout
tests.fetchgit.sparseCheckoutNonConeMode
tests.fetchgit.submodule-deep
tests.fetchgit.submodule-leave-git
tests.fetchgit.submodule-leave-git-deep
tests.fetchgit.submodule-simple
tests.fetchgit.withGitConfig
tests.fetchpatch.decode
tests.fetchpatch.fileWithApostrophe
tests.fetchpatch.fileWithSpace
tests.fetchpatch.full
tests.fetchpatch.hunks
tests.fetchpatch.relative
tests.fetchpatch.simple
tests.fetchpatch2.decode
tests.fetchpatch2.fileWithApostrophe
tests.fetchpatch2.fileWithSpace
tests.fetchpatch2.full
tests.fetchpatch2.hunks
tests.fetchpatch2.relative
tests.fetchpatch2.simple
tests.fetchtorrent.http-link (tests.fetchtorrent.http-link-transmission)
tests.fetchtorrent.http-link-rqbit (tests.fetchtorrent.http-link-rqbit-flattened)
tests.fetchtorrent.http-link-rqbit-unflattened
tests.fetchtorrent.magnet-link (tests.fetchtorrent.magnet-link-transmission)
tests.fetchtorrent.magnet-link-rqbit (tests.fetchtorrent.magnet-link-rqbit-flattened)
tests.fetchtorrent.magnet-link-rqbit-unflattened
tests.fetchurl.hashedMirrors
tests.fetchurl.header
tests.fetchurl.no-skipPostFetch
tests.fetchzip.hiddenDir
tests.fetchzip.postFetch
tests.fetchzip.simple
tests.haskell.cabalSdist.assumptionLocalHasDirectReference
tests.haskell.cabalSdist.localHasNoDirectReference
tests.overriding
tests.testers.runCommand.dns-resolution
tests.testers.runCommand.nonDefault-hash

Error logs: `aarch64-darwin`

tests.testers.runCommand.bork

                    exc.stdout, exc.stderr = process.communicate()
                else:
                    # POSIX _communicate already populated the output so
                    # far into the TimeoutExpired exception.
                    process.wait()
                raise
            except:  # Including KeyboardInterrupt, communicate handled that.
                process.kill()
                # We don't call process.wait() as .__exit__ does that for us.
                raise
            retcode = process.poll()
            if check and retcode:
>               raise CalledProcessError(retcode, process.args,
                                         output=stdout, stderr=stderr)
E               subprocess.CalledProcessError: Command '['/nix/store/hv7qldswrqvg1sjys1lmgjg875hkffng-python3-3.13.9/bin/python3.13', '-m', 'bork', 'download', 'gh:duckinator/emanate', 'v7.0.0']' returned non-zero exit status 1.
/nix/store/hv7qldswrqvg1sjys1lmgjg875hkffng-python3-3.13.9/lib/python3.13/subprocess.py:577: CalledProcessError

=========================== short test summary info ============================

FAILED bork/tests/test_cmd_download.py::test_download - subprocess.CalledProcessError: Command '['/nix/store/hv7qldswrqvg1sjys1lmgj...

================== 1 failed, 3 passed, 5 deselected in 30.29s ==================

ShamrockLee · 2025-11-17T13:41:04Z

`nixpkgs-review` result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 462034
Commit: 733b8b98584f72e7464c55a243ea5cc22e956010 (subsequent changes)
Merge: e6e5437315f21939c99f0e549953be0c6d8c91cf

Logs: https://github.com/ShamrockLee/nixpkgs-review-gha/actions/runs/19431391804

`aarch64-darwin` (sandbox = relaxed)

✅ 66 packages built:

nixpkgs-manual
tests.fetchDebianPatch.libPackage
tests.fetchDebianPatch.simple
tests.fetchFirefoxAddon.simple (tests.fetchFirefoxAddon.overridden-source)
tests.fetchFromBitbucket.withEncodedWhitespace
tests.fetchFromBitbucket.withEncodedWhitespaceGit
tests.fetchFromBitbucket.withoutWhitespace
tests.fetchFromGitHub.dumb-http-signed-tag
tests.fetchFromGitHub.fetchTags
tests.fetchFromGitHub.leave-git
tests.fetchFromGitHub.rootDir
tests.fetchFromGitHub.simple
tests.fetchFromGitHub.sparseCheckout
tests.fetchFromGitHub.sparseCheckoutNonConeMode
tests.fetchFromGitHub.submodule-deep
tests.fetchFromGitHub.submodule-leave-git
tests.fetchFromGitHub.submodule-leave-git-deep
tests.fetchFromGitHub.submodule-simple
tests.fetchNextcloudApp.simple-sha256
tests.fetchNextcloudApp.simple-sha512
tests.fetchPypiLegacy.fetchSimple
tests.fetchgit.dumb-http-signed-tag
tests.fetchgit.fetchTags
tests.fetchgit.leave-git
tests.fetchgit.prefetch-git-no-add-path
tests.fetchgit.rootDir
tests.fetchgit.simple
tests.fetchgit.sparseCheckout
tests.fetchgit.sparseCheckoutNonConeMode
tests.fetchgit.submodule-deep
tests.fetchgit.submodule-leave-git
tests.fetchgit.submodule-leave-git-deep
tests.fetchgit.submodule-simple
tests.fetchgit.withGitConfig
tests.fetchpatch.decode
tests.fetchpatch.fileWithApostrophe
tests.fetchpatch.fileWithSpace
tests.fetchpatch.full
tests.fetchpatch.hunks
tests.fetchpatch.relative
tests.fetchpatch.simple
tests.fetchpatch2.decode
tests.fetchpatch2.fileWithApostrophe
tests.fetchpatch2.fileWithSpace
tests.fetchpatch2.full
tests.fetchpatch2.hunks
tests.fetchpatch2.relative
tests.fetchpatch2.simple
tests.fetchtorrent.http-link (tests.fetchtorrent.http-link-transmission)
tests.fetchtorrent.http-link-rqbit (tests.fetchtorrent.http-link-rqbit-flattened)
tests.fetchtorrent.http-link-rqbit-unflattened
tests.fetchtorrent.magnet-link (tests.fetchtorrent.magnet-link-transmission)
tests.fetchtorrent.magnet-link-rqbit (tests.fetchtorrent.magnet-link-rqbit-flattened)
tests.fetchtorrent.magnet-link-rqbit-unflattened
tests.fetchurl.hashedMirrors
tests.fetchurl.header
tests.fetchurl.no-skipPostFetch
tests.fetchzip.hiddenDir
tests.fetchzip.postFetch
tests.fetchzip.simple
tests.haskell.cabalSdist.assumptionLocalHasDirectReference
tests.haskell.cabalSdist.localHasNoDirectReference
tests.overriding
tests.testers.runCommand.bork
tests.testers.runCommand.dns-resolution
tests.testers.runCommand.nonDefault-hash

ShamrockLee · 2025-11-17T13:48:02Z

Now it passes all the existing tests, but the "CPU time increased by 14.5%" performance overhead is not quite acceptable.

I'll try to optimize it.

Performance comparison

This compares the performance of this branch against its pull request base branch (e.g., 'master')

For further help please refer to: ci/README.md

Unchanged values

metric	value
sizes.Attr¹	16
sizes.Bindings²	24
sizes.Env³	8
sizes.Value⁴	16

Updated values

metric	mean_before	mean_after	mean_diff	mean_pct_change	p_value	t_stat
time.cpu⁵	26.2992	30.1918	3.8926	14.5303	-	13.3068
time.gc⁶	2.0607	2.7813	0.7206	38.9145	-	11.3923
time.gcFraction⁷	0.0755	0.0897	0.0142	20.7026	-	9.1617
gc.cycles⁸	8.5769	10.3077	1.7308	20.9264	-	14.4152
gc.heapSize⁹	1846401181.5385	2085153870.7692	238752689.2308	14.4830	-	10.0539
gc.totalBytes¹⁰	3481972329.2308	4381634855.0769	899662525.8462	26.6369	-	13.9828
envs.bytes¹¹	611916669.0769	701896202.9231	89979533.8462	15.2425	-	14.2532
list.bytes¹²	86394604.1538	90307111.2308	3912507.0769	4.6224	-	13.9794
sets.bytes¹³	1327595539.8462	1952547122.7692	624951582.9231	48.9251	-	13.9015
symbols.bytes¹⁴	1452974.2308	1453715.2308	741.0000	0.0545	-	549.8722
values.bytes¹⁵	825376726.4615	950151677.2308	124774950.7692	15.8872	-	14.1941
envs.number¹⁶	30747166.1923	35280877.4231	4533711.2308	15.2844	-	14.2188
nrAvoided¹⁷	37278251.5385	40999689.9423	3721438.4038	10.1547	-	14.0338
nrExprs¹⁸	1564427.7692	1564889.3077	461.5385	0.0313	-	618.4658
nrFunctionCalls¹⁹	27687666.7308	31735632.5000	4047965.7692	15.1248	-	14.1329
nrLookups²⁰	13612368.8462	15983994.3462	2371625.5000	18.4031	-	13.9755
nrOpUpdateValuesCopied²¹	42290049.1923	62196596.3846	19906547.1923	49.3418	-	13.9000
nrOpUpdates²²	4864289.5577	6478620.5192	1614330.9615	33.5087	-	14.3086
nrPrimOpCalls²³	16073393.9231	17056812.2115	983418.2885	6.1660	-	14.1666
nrThunks²⁴	39150908.3077	43091064.4038	3940156.0962	10.4801	-	14.5125
sets.number²⁵	6759438.0577	8456160.2692	1696722.2115	26.1742	-	14.0699
symbols.number²⁶	117413.7308	117452.3462	38.6154	0.0342	-	373.7618
values.number²⁷	51586045.4038	59384479.8269	7798434.4231	15.8872	-	14.1941
envs.elements²⁸	45742417.4423	52456147.9423	6713730.5000	15.2184	-	14.2764
list.concats²⁹	2202940.2885	2245403.3077	42463.0192	2.0064	-	13.8849
list.elements³⁰	10799325.5192	11288388.9038	489063.3846	4.6224	-	13.9794
sets.elements³¹	72835564.1538	109349954.7692	36514390.6154	52.2253	-	13.8898

Size in bytes of the Attr type. ↩
Size in bytes of the Bindings type. ↩
Size in bytes of the Env type. ↩
Size in bytes of the Value type. ↩
Number of seconds of CPU time accounted by the OS to the Nix evaluator process. On UNIX systems, this comes from getrusage(RUSAGE_SELF). ↩
Number of seconds of CPU time accounted by the Boehm garbage collector to performing GC. ↩
What fraction of the total CPU time is accounted towards performing GC. ↩
Number of times garbage collection has been performed. ↩
Size in bytes of the garbage collector heap. ↩
Size in bytes of all allocations in the garbage collector. ↩
Size in bytes of all Env objects allocated by the Nix evaluator. These are almost exclusively created by nix-env. ↩
Size in bytes of all lists allocated by the Nix evaluator. ↩
Size in bytes of all attrsets allocated by the Nix evaluator. ↩
Size in bytes of all items in the Nix evaluator symbol table. ↩
Size in bytes of all values allocated by the Nix evaluator. ↩
The count of all Env objects allocated. ↩
The number of thunks avoided being created. ↩
The number of expression objects ever created. ↩
The number of function calls ever made. ↩
The number of lookups into an attrset ever made. ↩
The number of attrset values copied in the process of merging attrsets. ↩
The number of attrsets merge operations (//) performed. ↩
The number of function calls to primops (Nix builtins) ever made. ↩
The number of thunks ever made. A thunk is a delayed computation, represented by an expression reference and a closure. ↩
The number of attrsets ever made. ↩
The number of symbols ever added to the symbol table. ↩
The number of values ever made. ↩
The number of values contained within an Env object. ↩
The number of list concatenation operations (++) performed. ↩
The number of values contained within a list. ↩
The number of values contained within an attrset. ↩

…nally

…utes

…struction

…_structuedAttrs is true

…tputHashAlgo values

…fetchgitSpecialArgs

fetchgit: move assertions down to argument values

1d6c7d6

ShamrockLee changed the title ~~fetchGitProvider: init~~ fetchFromGitProvider: init Nov 15, 2025

ShamrockLee force-pushed the fetchgitprovider-always-pass branch 3 times, most recently from 24aed81 to c4bbde3 Compare November 15, 2025 22:10

github-project-automation bot added this to Stdenv Nov 15, 2025

ShamrockLee force-pushed the fetchgitprovider-always-pass branch 3 times, most recently from 6c38f00 to 5772760 Compare November 16, 2025 06:00

This comment was marked as resolved.

Sign in to view

ShamrockLee mentioned this pull request Nov 16, 2025

fetchFromGitHub: converge arguments that determines useFetchGit #456226

Merged

13 tasks

fetchgit: default argument leaveDotGit to null

9fe4e65

ShamrockLee force-pushed the fetchgitprovider-always-pass branch 3 times, most recently from 82c91ab to 733b8b9 Compare November 17, 2025 12:28

ShamrockLee force-pushed the fetchgitprovider-always-pass branch 7 times, most recently from 6932aa3 to ff736c3 Compare November 17, 2025 15:52

ShamrockLee added 17 commits December 4, 2025 15:20

fetchFromGitHub: elaborate the fetchSubmodules default choice

5916868

fetchgit: default nonConeMode to null and manage its default internally

6c5dc5d

fetchgit: nonConeMode: reference depending attributes from finalAttrs

ea5b3c6

fetchgit: keep sparseCheckout a list and stringify as sparseCheckoutText

83b42e3

fetchgit: default sparseCheckout to null and handle the default inter…

dd26422

…nally

fetchgit: move sparseCheckout type check down to sparseCheckoutText

d1275c4

fetchgit: format expression after eliminating global assertions

8c85578

fetchFromGitHub: default sparseCheckout to null

4c681c7

fetchgit: sparseCheckout: reference depending attributes from finalAttrs

5c51547

fetchFromGitHub: explicitly support addditional fetchgit args

239a6f8

fetchFromGitHub: converge arguments that determines useFetchGit

746e443

lib.makeOverrdable: preserve constructor override and metadata attrib…

7f9a1c8

…utes

fetchFromGitProvider: init

185b80b

fetchFromGitHub: base on fetchFromGitProvider and lib.extendMkDerivation

a514aaf

fetchFromGitHub: format expression after lib.extendMkDerivation recon…

351c182

…struction

fetchurl: provide fetchurl.extendDrvArgs

1a7e9b1

fetchzip: provide fetchzip.expectDrvArgs

e08b2c3

ShamrockLee force-pushed the fetchgitprovider-always-pass branch from cb8d206 to 351c182 Compare December 4, 2025 07:35

ShamrockLee added 6 commits December 4, 2025 20:57

mkDerivation: make allowedReference/allowedRequisites nullable when _…

1bafb30

…_structuedAttrs is true

fetchgit: provide fetchgit.expectDrvArgs

a04426d

fetchFromGitProvider, fetchFromGitHub: use and provide expectDrvArgs

c54b742

lib.fetchers.normalizeHash: move assertions down to outputHash and ou…

d27d2a3

…tputHashAlgo values

fetchGitProvider: default enableUseFetchGitFinal true

e28bd42

fetchGitProvider: reduce enableUseFetchGitFinal RAM consumption with …

cc205a2

…fetchgitSpecialArgs

ShamrockLee force-pushed the fetchgitprovider-always-pass branch from 9ee20e6 to cc205a2 Compare December 4, 2025 12:57

nixpkgs-ci bot added the 6.topic: stdenv Standard environment label Dec 4, 2025

github-project-automation bot added this to Stdenv Dec 4, 2025

nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 23, 2025

github-project-automation bot added this to Nixpkgs Lib Dec 23, 2025

kimburgess mentioned this pull request Dec 24, 2025

helix: build tree-sitter grammars from source #452275

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fetchFromGitProvider: init (optional dynamically switchable after `<pkg>.overrideAttrs`)#462034

fetchFromGitProvider: init (optional dynamically switchable after `<pkg>.overrideAttrs`)#462034
ShamrockLee wants to merge 26 commits intoNixOS:masterfrom
ShamrockLee:fetchgitprovider-always-pass

ShamrockLee commented Nov 15, 2025 •

edited

Loading

Uh oh!

This comment was marked as resolved.

ShamrockLee commented Nov 17, 2025

Uh oh!

ShamrockLee commented Nov 17, 2025

Uh oh!

ShamrockLee commented Nov 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

ShamrockLee commented Nov 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Things done

Uh oh!

This comment was marked as resolved.

ShamrockLee commented Nov 17, 2025

nixpkgs-review result

x86_64-linux

aarch64-linux

x86_64-darwin (sandbox = relaxed)

aarch64-darwin (sandbox = relaxed)

Uh oh!

ShamrockLee commented Nov 17, 2025

nixpkgs-review result

aarch64-darwin (sandbox = relaxed)

Uh oh!

ShamrockLee commented Nov 17, 2025

Performance comparison

Unchanged values

Updated values

Footnotes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ShamrockLee commented Nov 15, 2025 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

`x86_64-darwin` (sandbox = relaxed)

`aarch64-darwin` (sandbox = relaxed)

`nixpkgs-review` result

`aarch64-darwin` (sandbox = relaxed)