helix: build tree-sitter grammars from source#452275
Merged
teto merged 7 commits intoNixOS:masterfrom Feb 17, 2026
Merged
Conversation
aciceri
force-pushed
the
helix-tree-sitter-grammars
branch
from
99f96db to
b3be124
Compare
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
nixpkgs-ci
bot
added
9.needs: reviewer
Member
Author
|
aciceri
force-pushed
the
helix-tree-sitter-grammars
branch
from
73b1653 to
e7e760b
Compare
Member
Author
Runtime closure now256 elements (253.8 MiB in total) Runtime closure before7 elements (254.2 MiB in total) DetailsThe total size is similar but obviously the amount of derivations in the closure increased. |
Member
Author
|
PS: the question about if and how to set |
Member
Author
|
Contributor
There is no rule against it. I mainly just want to ensure that settings them broken on pkgsStatic is ensured and that licenses are properly reported. |
RossSmyth
reviewed
Oct 16, 2025
Contributor
|
As an alternative you could mark helix{-evil} as broken on static since they unconditionally use the runtime files |
RossSmyth
reviewed
Oct 16, 2025
Contributor
|
Reviewed the Python code and overall looks good just a minor nit |
Contributor
|
oops wrong button |
aciceri
force-pushed
the
helix-tree-sitter-grammars
branch
from
e7e760b to
0b13a72
Compare
Member
Author
I've considered this but at the end I've preferred marking as broken only grammars, also because in theory
For what concerns licenses I didn't find a way at the end. I may change the the python script to try fetching them but honestly it looks flaky. |
Member
Author
|
By the way the tree-sitter grammars under Otherwise we may use the generic At the moment the Which means that by default it already sets |
Contributor
|
Alright I guess it's fine |
nixpkgs-ci
bot
added
the
12.approvals: 2
Member
Author
|
Member
Author
|
Member
Author
Member
|
if there is no comment in a week, feel free to ping me and I'll merge |
Member
Author
Great! Can't wait to see this merged, it has been a long ride. Meanwhile I've also sent it to the "Nixpkgs Review Requests" Matrix channel. |
This allows overriding grammars with overlays
aciceri
force-pushed
the
helix-tree-sitter-grammars
branch
from
fff5493 to
95dd21f
Compare
Member
Author
|
Member
Author
|
I've rebased onto |
Member
|
thank you for the huge work and patience :) |
Member
Author
|
Yay 🚀 |
Member
|
Member
Author
|
Damn, how is it possible? With |
Member
Member
Author
|
I've also just realized that this PR broke The issue is that We could solve the problem by adding a way to pass |
This was referenced Feb 18, 2026
This was referenced Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #451633,
depends on #408414.(now merged)At the moment the compiled helix grammars are taken from a release on GitHub, this PR instead builds them from source.
In particular this:
It also affects a few generic things related to tree-sitter grammars:
tree-sitter.grammarsScopewhich is a real package set (usinglib.makeScope) making easier overriding/adding grammars by using overlaysThings done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.