fetchgit: give leaveDotGit, nonConeMode, and sparseCheckout a default value null#462032
Merged
ShamrockLee merged 13 commits intoNixOS:masterfrom Dec 8, 2025
Merged
fetchgit: give leaveDotGit, nonConeMode, and sparseCheckout a default value null#462032ShamrockLee merged 13 commits intoNixOS:masterfrom
leaveDotGit, nonConeMode, and sparseCheckout a default value null#462032ShamrockLee merged 13 commits intoNixOS:masterfrom
Conversation
Draft
13 tasks
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
ShamrockLee
force-pushed
the
fetchgit-leavedotgit
branch
from
0d8b63e to
6c38877
Compare
13 tasks
MattSturgeon
approved these changes
Nov 16, 2025
Contributor
MattSturgeon
left a comment
MattSturgeon
left a comment
There was a problem hiding this comment.
Looks simpler, nice!
| # > from standard in as a newline-delimited list instead of from the arguments. | ||
| sparseCheckout = builtins.concatStringsSep "\n" sparseCheckout; | ||
| sparseCheckout = | ||
| assert nonConeMode -> (sparseCheckout != [ ]); |
Contributor
There was a problem hiding this comment.
Would it be better to use assertMsg or throwIfNot (my preference) to print a user-facing error? Or is it enough that this LoC will show up in the stacktrace?
Contributor
Author
Contributor
There was a problem hiding this comment.
To be clear: this isn't blocking. Error messages can be added by those in-the-know in a dedicated PR.
Contributor
Author
There was a problem hiding this comment.
I see. Thank you for reviewing and approval!
Contributor
Author
There was a problem hiding this comment.
@winterqt I'm merging this PR, but feel free to leave a comment here or add the implementation comment in a new PR.
nixpkgs-ci
bot
added
the
12.approvals: 1
ShamrockLee
force-pushed
the
fetchgit-leavedotgit
branch
2 times, most recently
from
31e0db2 to
ca991ad
Compare
ShamrockLee
changed the title
leaveDotGit a default value nullleaveDotGit, nonConeMode, and sparseCheckout a default value null
ShamrockLee
force-pushed
the
fetchgit-leavedotgit
branch
2 times, most recently
from
8ad0962 to
7ebb737
Compare
nixpkgs-ci
bot
added
10.rebuild-linux: 11-100
Contributor
Author
|
@MattSturgeon I applied similar changes to I also delegated the IIRC, the current supported way to override |
Contributor
Author
|
ShamrockLee
force-pushed
the
fetchgit-leavedotgit
branch
from
18206ab to
b7e1759
Compare
ShamrockLee
force-pushed
the
fetchgit-leavedotgit
branch
from
b7e1759 to
5c51547
Compare
MattSturgeon
approved these changes
Dec 8, 2025
Contributor
MattSturgeon
left a comment
MattSturgeon
left a comment
There was a problem hiding this comment.
LGTM, other than treefmt failing
Co-authored-by: Matt Sturgeon <matt@sturgeon.me.uk>
ShamrockLee
force-pushed
the
fetchgit-leavedotgit
branch
from
0f72e09 to
ea1e4d7
Compare
philiptaron
approved these changes
Dec 8, 2025
nixpkgs-ci
bot
added
12.approvals: 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of dynamically deciding on the default value of
leaveDotGitinfetchgit's set pattern, this PR assigns a defaultnulland decide on the actual default inside the function body.This allows dependent expressions to pass
leaveDotGit = nulldirectly, eliminating the need of conditional passing.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.