[24.11] electron: bump default version from 33 to 34#389203
Merged
yuyuyureka merged 1 commit intoNixOS:release-24.11from Mar 14, 2025
Merged
[24.11] electron: bump default version from 33 to 34#389203yuyuyureka merged 1 commit intoNixOS:release-24.11from
yuyuyureka merged 1 commit intoNixOS:release-24.11from
Conversation
github-actions
bot
added
10.rebuild-darwin: 11-100
Member
|
Contributor
|
Since we haven't backported my electron-bin wrapper PR yet, packages using electron-fuses will break if we merge this (which are probably what we're seeing fail) |
Contributor
|
Now that the source-build got backported, we don't have to be as quick with the backporting of my PR, and we can most likely merge this before it. |
electron_33 will be EOL before NixOS 24.11 goes EOL.
teutat3s
force-pushed
the
backport-electron-bump-to-34
branch
from
4f40095 to
fc146b8
Compare
Contributor
|
@TomaSajt do you know if the issue would also happen on darwin, because that still won't use the source-built? |
Contributor
|
The issue was only with having the original electron binary replaced with a wrapper. |
Contributor
|
Thanks for the explanation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
electron_33 will be EOL before NixOS 24.11 goes EOL.
Prior art:
#336018
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.