Skip to content

toml11: 3.7.1 -> 4.4.0#442682

Merged
K900 merged 4 commits intoNixOS:stagingfrom
Chaostheorie:cr-toml11
Sep 17, 2025
Merged

toml11: 3.7.1 -> 4.4.0#442682
K900 merged 4 commits intoNixOS:stagingfrom
Chaostheorie:cr-toml11

Conversation

@Chaostheorie
Copy link
Contributor

@Chaostheorie Chaostheorie commented Sep 13, 2025

Major bump, see https://github.com/ToruNiina/toml11/releases/tag/v4.4.0 for the current release notes. This also enables the upstream unit tests.

see #430607, #442668 and #434186 for related comments

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. labels Sep 13, 2025
@Chaostheorie Chaostheorie marked this pull request as ready for review September 13, 2025 18:27
@Chaostheorie
Copy link
Contributor Author

Note for reviewer(s): Review(s) would be appreciated, but please do not merge this until a member of the nix team approves it. There are dependent packages that require version bumps before this can be merged.

@Chaostheorie Chaostheorie requested review from a team and emilazy September 13, 2025 18:29
Major bump, see https://github.com/ToruNiina/toml11/releases/tag/v4.4.0
for the current release notes

This also enables the upstream unit tests.

Co-authored-by: dotlambda <github@dotlambda.de>
@emilazy
Copy link
Member

emilazy commented Sep 15, 2025

Should be ready after #443012.

@emilazy
Copy link
Member

emilazy commented Sep 15, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 442682
Commit: ad17bca8b763b9a649b502dfe2b40589589d42bf


aarch64-linux

⏩ 1 package marked as broken and skipped:
  • tests.pkg-config.defaultPkgConfigPackages.tests-combined
⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
❌ 32 packages failed to build:
  • foundationdb
  • foundationdb.debug
  • foundationdb.dev
  • foundationdb.lib
  • foundationdb.pythonsrc
  • lixPackageSets.git.colmena
  • lixPackageSets.git.lix
  • lixPackageSets.git.lix.debug
  • lixPackageSets.git.lix.dev
  • lixPackageSets.git.lix.devdoc
  • lixPackageSets.git.lix.doc
  • lixPackageSets.git.lix.man
  • lixPackageSets.git.nix-direnv
  • lixPackageSets.git.nix-eval-jobs
  • lixPackageSets.git.nix-fast-build
  • lixPackageSets.git.nix-fast-build.dist
  • lixPackageSets.git.nixpkgs-review
  • lixPackageSets.git.nixpkgs-review.dist
  • nanoboyadvance
  • nixStatic
  • nixStatic.dev
  • nixStatic.doc
  • nixStatic.man
  • nixVersions.git
  • nixVersions.git.dev
  • nixVersions.git.doc
  • nixVersions.git.man
  • python312Packages.foundationdb
  • python312Packages.foundationdb.dist
  • python313Packages.foundationdb
  • python313Packages.foundationdb.dist
  • tests.devShellTools.nixos
✅ 197 packages built:
  • appvm
  • attic-client
  • bower2nix
  • bundix
  • cabal2nix
  • cached-nix-shell
  • cachix (cachix.bin, cachix.doc)
  • chirpstack-concentratord
  • colmena
  • comma
  • common-updater-scripts
  • crate2nix
  • crush
  • devenv
  • disko
  • dnf5
  • dnf5.man
  • dub-to-nix
  • dydisnix
  • fusionInventory
  • gcalcli
  • gcalcli.dist
  • gclient2nix
  • glpi-agent
  • haskellPackages.cabal2nix-unstable
  • haskellPackages.cachix
  • haskellPackages.cachix.bin
  • haskellPackages.cachix.doc
  • haskellPackages.cli-nix
  • haskellPackages.cli-nix.doc
  • haskellPackages.hercules-ci-agent
  • haskellPackages.hercules-ci-agent.doc
  • haskellPackages.hercules-ci-cli
  • haskellPackages.hercules-ci-cli.doc
  • haskellPackages.hercules-ci-cnix-expr
  • haskellPackages.hercules-ci-cnix-expr.doc
  • haskellPackages.hercules-ci-cnix-store
  • haskellPackages.hercules-ci-cnix-store.doc
  • haskellPackages.niv
  • haskellPackages.niv.bin
  • haskellPackages.niv.data
  • haskellPackages.niv.doc
  • haskellPackages.nix-paths
  • haskellPackages.nix-paths.doc
  • haskellPackages.nix-serve-ng
  • haskellPackages.nix-serve-ng.doc
  • haskellPackages.nix-thunk
  • haskellPackages.nix-thunk.doc
  • haskellPackages.nvfetcher
  • haskellPackages.nvfetcher.doc
  • haskellPackages.update-nix-fetchgit
  • haskellPackages.update-nix-fetchgit.doc
  • hci
  • hercules-ci-agent
  • home-manager
  • hydra
  • hydra.doc
  • kcl
  • libnixxml
  • lix (lixPackageSets.latest.lix, lixPackageSets.lix_2_93.lix, lixPackageSets.stable.lix)
  • lix.debug (lixPackageSets.latest.lix.debug, lixPackageSets.lix_2_93.lix.debug, lixPackageSets.stable.lix.debug)
  • lix.dev (lixPackageSets.latest.lix.dev, lixPackageSets.lix_2_93.lix.dev, lixPackageSets.stable.lix.dev)
  • lix.devdoc (lixPackageSets.latest.lix.devdoc, lixPackageSets.lix_2_93.lix.devdoc, lixPackageSets.stable.lix.devdoc)
  • lix.doc (lixPackageSets.latest.lix.doc, lixPackageSets.lix_2_93.lix.doc, lixPackageSets.stable.lix.doc)
  • lix.man (lixPackageSets.latest.lix.man, lixPackageSets.lix_2_93.lix.man, lixPackageSets.stable.lix.man)
  • lixPackageSets.latest.colmena (lixPackageSets.lix_2_93.colmena, lixPackageSets.stable.colmena)
  • lixPackageSets.latest.nix-direnv (lixPackageSets.lix_2_93.nix-direnv, lixPackageSets.stable.nix-direnv)
  • lixPackageSets.latest.nix-eval-jobs (lixPackageSets.lix_2_93.nix-eval-jobs, lixPackageSets.stable.nix-eval-jobs)
  • lixPackageSets.latest.nix-fast-build (lixPackageSets.lix_2_93.nix-fast-build, lixPackageSets.stable.nix-fast-build)
  • lixPackageSets.latest.nix-fast-build.dist (lixPackageSets.lix_2_93.nix-fast-build.dist, lixPackageSets.stable.nix-fast-build.dist)
  • lixPackageSets.latest.nixpkgs-review (lixPackageSets.lix_2_93.nixpkgs-review, lixPackageSets.stable.nixpkgs-review)
  • lixPackageSets.latest.nixpkgs-review.dist (lixPackageSets.lix_2_93.nixpkgs-review.dist, lixPackageSets.stable.nixpkgs-review.dist)
  • lixStatic
  • lixStatic.dev
  • lua51Packages.luarocks-nix
  • luarocks-nix (luaPackages.luarocks-nix)
  • lua53Packages.luarocks-nix
  • lua54Packages.luarocks-nix
  • luajitPackages.luarocks-nix
  • luarocks-packages-updater
  • luarocks-packages-updater.dist
  • lux-cli
  • mdwatch
  • nil
  • nim_lk
  • niv (niv.bin, niv.data)
  • nix (nixVersions.nix_2_28, nixVersions.stable)
  • nix-bundle
  • nix-direnv
  • nix-du
  • nix-eval-jobs
  • nix-eval-jobs.dev
  • nix-fast-build
  • nix-fast-build.dist
  • nix-forecast
  • nix-heuristic-gc
  • nix-heuristic-gc.dist
  • nix-index
  • nix-init
  • nix-inspect
  • nix-pin
  • nix-plugins
  • nix-prefetch
  • nix-prefetch-docker
  • nix-prefetch-github (python313Packages.nix-prefetch-github)
  • nix-prefetch-github.dist (python313Packages.nix-prefetch-github.dist)
  • nix-prefetch-github.man (python313Packages.nix-prefetch-github.man)
  • nix-required-mounts
  • nix-required-mounts.dist
  • nix-serve
  • nix-serve-ng
  • nix-template
  • nix-unit
  • nix-update
  • nix-update.dist
  • nix-visualize
  • nix-visualize.dist
  • nix-web
  • nix.debug (nixVersions.nix_2_28.debug, nixVersions.stable.debug)
  • nix.dev (nixVersions.nix_2_28.dev, nixVersions.stable.dev)
  • nix.doc (nixVersions.nix_2_28.doc, nixVersions.stable.doc)
  • nix.man (nixVersions.nix_2_28.man, nixVersions.stable.man)
  • nixVersions.latest (nixVersions.nix_2_31)
  • nixVersions.latest.dev (nixVersions.nix_2_31.dev)
  • nixVersions.latest.doc (nixVersions.nix_2_31.doc)
  • nixVersions.latest.man (nixVersions.nix_2_31.man)
  • nixVersions.nix_2_29
  • nixVersions.nix_2_29.dev
  • nixVersions.nix_2_29.doc
  • nixVersions.nix_2_29.man
  • nixVersions.nix_2_30
  • nixVersions.nix_2_30.dev
  • nixVersions.nix_2_30.doc
  • nixVersions.nix_2_30.man
  • nixci
  • nixd
  • nixos-anywhere
  • nixos-generators
  • nixos-option
  • nixos-rebuild
  • nixos-rebuild-ng
  • nixos-rebuild-ng.dist
  • nixos-shell
  • nixpkgs-hammering
  • nixpkgs-manual
  • nixpkgs-review
  • nixpkgs-review.dist
  • nixpkgs-reviewFull
  • nixpkgs-reviewFull.dist
  • nixseparatedebuginfod2
  • nixt
  • nixt.dev
  • nixtract
  • node2nix (nodePackages.node2nix)
  • nodePackages_latest.node2nix
  • nps
  • nuget-to-json
  • nurl
  • nvfetcher
  • omnix
  • python312Packages.nix-kernel
  • python312Packages.nix-kernel.dist
  • python312Packages.nix-prefetch-github
  • python312Packages.nix-prefetch-github.dist
  • python312Packages.nix-prefetch-github.man
  • python313Packages.nix-kernel
  • python313Packages.nix-kernel.dist
  • python313Packages.nixpkgs-updaters-library
  • python313Packages.nixpkgs-updaters-library.dist
  • ragenix
  • sbomnix
  • sbomnix.dist
  • sus-compiler
  • swiftpm2nix (swiftPackages.swiftpm2nix)
  • terranix
  • tests.haskell.cabalSdist.hercules-ci-cnix-store
  • tests.haskell.cabalSdist.hercules-ci-cnix-store.doc
  • tests.pkg-config.defaultPkgConfigPackages.nix-cmd
  • tests.pkg-config.defaultPkgConfigPackages.nix-expr
  • tests.pkg-config.defaultPkgConfigPackages.nix-main
  • tests.pkg-config.defaultPkgConfigPackages.nix-store
  • tests.pkgs-lib
  • tests.testers.lycheeLinkCheck.network
  • tests.testers.nixosTest-example
  • tests.testers.runNixOSTest-example (tests.testers.runNixOSTest-extendNixOS)
  • tests.trivial-builders.references
  • toml11
  • update-nix-fetchgit
  • update-python-libraries
  • vimPluginsUpdater
  • vulnix
  • vulnix.dist
  • vulnix.doc
  • vulnix.man
  • wp4nix
  • xosd-xft
  • zon2nix

Error logs: `aarch64-linux`
foundationdb
                 from /build/source/fdbclient/include/fdbclient/BlobCipher.h:26:
/build/source/fdbrpc/include/fdbrpc/fdbrpc.h: At global scope:
/build/source/fdbrpc/include/fdbrpc/fdbrpc.h:187:34: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
  187 |         explicit ReplyPromise<T>(SAV<T>* ptr) : sav(static_cast<NetSAV<T>*>(ptr)) {}
      |                                  ^~~~~~
/build/source/fdbrpc/include/fdbrpc/fdbrpc.h:187:34: note: remove the '< >'
In file included from /build/source/fdbclient/include/fdbclient/KeyRangeMap.h:30,
                 from /build/source/fdbclient/include/fdbclient/NativeAPI.actor.h:40,
                 from /build/source/fdbclient/include/fdbclient/NativeAPI.actor.h:24,
                 from /build/source/fdbclient/include/fdbclient/BackupContainer.h:28,
                 from /build/source/fdbclient/include/fdbclient/BackupContainerFileSystem.h:26,
                 from /build/source/fdbclient/include/fdbclient/BlobConnectionProvider.h:24,
                 from /build/source/fdbserver/include/fdbserver/BlobGranuleServerCommon.actor.h:29,
                 from /build/source/fdbserver/include/fdbserver/BlobGranuleServerCommon.actor.h:23,
                 from /build/source/fdbserver/Status.actor.cpp:25:
/build/source/fdbrpc/include/fdbrpc/RangeMap.h:99:47: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
   99 |                 explicit IteratorImpl<isConst>(const value_type it) : it(it) {}
      |                                               ^
/build/source/fdbrpc/include/fdbrpc/RangeMap.h:99:47: note: remove the '< >'
ninja: build stopped: subcommand failed.
lixPackageSets.git.lix
[144-146/146] 🌗 lix:installcheck / functional-fetchMercurial                                       13/300s
144/146 lix:installcheck / functional-build-remote-input-addressed                  OK              13.81s
[145-146/146] 🌘 lix:installcheck / functional-fetchMercurial                                       14/300s
[145-146/146] 🌑 lix:installcheck / functional-flakes-mercurial                                     14/300s
[145-146/146] 🌒 lix:installcheck / functional-fetchMercurial                                       15/300s
[145-146/146] 🌓 lix:installcheck / functional-flakes-mercurial                                     16/300s
145/146 lix:installcheck / functional-flakes-mercurial                              OK              17.17s
[146/146] 🌔 lix:installcheck / functional-fetchMercurial                                           17/300s
[146/146] 🌕 lix:installcheck / functional-fetchMercurial                                           17/300s
[146/146] 🌖 lix:installcheck / functional-fetchMercurial                                           18/300s
[146/146] 🌗 lix:installcheck / functional-fetchMercurial                                           19/300s
[146/146] 🌘 lix:installcheck / functional-fetchMercurial                                           20/300s
[146/146] 🌑 lix:installcheck / functional-fetchMercurial                                           21/300s
146/146 lix:installcheck / functional-fetchMercurial                                OK              22.08s

Ok: 143
Fail: 1
Skipped: 2

Full log written to /build/source/build/meson-logs/testlog.txt

nanoboyadvance
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /nix/store/hf8w753nxqwkc5y5kjx33fx8fxw2dczp-gcc-wrapper-14.3.0/bin/g++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found OpenGL: /nix/store/wk994cq6kf682saqynadrkdbi8qa8vx1-libglvnd-1.7.0/lib/libOpenGL.so
-- Glad Library 'glad_gl_core_33'
-- Found Python: /nix/store/a65r9k46dxhyx2gn60bpx7j62anjdjr7-python3-3.13.7/bin/python3.13 (found version "3.13.7") found components: Interpreter
CMake Error at src/platform/core/CMakeLists.txt:31 (find_package):
  Could not find a configuration file for package "toml11" that is compatible
  with requested version "3.7".

The following configuration files were considered but not accepted:

/nix/store/h0gl6anjlfp9gq4hjxicgdaqyhmc82py-toml11-4.4.0/lib/cmake/toml11/toml11Config.cmake, version: 4.4.0

-- Configuring incomplete, errors occurred!

nixStatic
    p = subprocess.Popen(cmd_args, env=child_env, cwd=exe.workdir,
                         close_fds=False, stdin=stdin, stdout=pipe, stderr=pipe)
  File "/nix/store/a65r9k46dxhyx2gn60bpx7j62anjdjr7-python3-3.13.7/lib/python3.13/subprocess.py", line 1039, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                        pass_fds, cwd, env,
                        ^^^^^^^^^^^^^^^^^^^
    ...<5 lines>...
                        gid, gids, uid, umask,
                        ^^^^^^^^^^^^^^^^^^^^^^
                        start_new_session, process_group)
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/a65r9k46dxhyx2gn60bpx7j62anjdjr7-python3-3.13.7/lib/python3.13/subprocess.py", line 1972, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: '/build/source/build/src/nix/nix'
[302/563] Compiling C++ object src/libutil-test-support/libnix-util-test-support.a.p/hash.cc.o
[303/563] Compiling C++ object src/libstore-test-support/libnix-store-test-support.a.p/outputs-spec.cc.o
[304/563] Compiling C++ object src/libstore-test-support/libnix-store-test-support.a.p/derived-path.cc.o
[305/563] Compiling C++ object src/libstore-test-support/libnix-store-test-support.a.p/path.cc.o
ninja: build stopped: subcommand failed.
tests.devShellTools.nixos
docker # Creating layer 70 from paths: ['/nix/store/fp4bszjavnlf2v14j5asdyv2b8igc5cf-stdenv-linux']
docker # Creating layer 71 with customisation...
docker # Adding manifests...
docker # Done.
docker # [  276.405759] dockerd[856]: time="2025-09-15T16:54:56.551379600Z" level=info msg="Layer sha256:95f926e32b13c648999929c03f5def07f42002c07b32aa8665b80268eb5a96e2 cleaned up"
docker # [  276.418032] dockerd[856]: time="2025-09-15T16:54:56.562671440Z" level=info msg="Layer sha256:0c576ada2942a9cfdd12c02ea4b6ebab52ebe865b0efa679cf6ec1cb85ed50e1 cleaned up"
docker # [  276.421839] dockerd[856]: time="2025-09-15T16:54:56.567734720Z" level=info msg="Layer sha256:03e7f65f3b30c43f3c2e54404a455052df0f20cc41e552667be3e2c0c5a32e91 cleaned up"
docker # write /nix/store/49spybp2k23p892159fi937x1axk9gvz-gcc-14.3.0/libexec/gcc/aarch64-unknown-linux-gnu/14.3.0/lto1: no space left on device
docker: output: 
!!! Test "buildNixShellImage: home directory is writable by default" failed with error: "command `/nix/store/wa0af722v8fnm2d7fm9j3sxzyl4qsm36-stream-nix-shell-writable-home | docker load` failed (exit code 1)"
!!! Traceback (most recent call last):
!!!   File "<string>", line 46, in <module>
!!!     docker.succeed(
!!! 
!!! RequestedAssertionFailed: command `/nix/store/wa0af722v8fnm2d7fm9j3sxzyl4qsm36-stream-nix-shell-writable-home | docker load` failed (exit code 1)
cleanup
kill machine (pid 9)
qemu-system-aarch64: terminating on signal 15 from pid 6 (/nix/store/a65r9k46dxhyx2gn60bpx7j62anjdjr7-python3-3.13.7/bin/python3.13)
kill vlan (pid 7)
(finished: cleanup, in 0.01 seconds)

@emilazy
Copy link
Member

emilazy commented Sep 15, 2025

nixVersions.git would be fixed by a bump, as would lixPackageSets.git.nix (see #424775). Discussed with @xokdvium and breaking nixVersions.git for now seems okay. nixStatic failure is pre‐existing. tests.devShellTools.nixos looks obviously unrelated.

foundationdb and nanoboyadvance are real regressions. I will take a brief look at those, but don’t think we need to block long on them.

@Chaostheorie
Copy link
Contributor Author

Thank you a lot for evaluating/building the change. I will try to take a look at the regressions, maybe a split package for v3.x might still be a viable stopgab solution for those packages.

@emilazy
Copy link
Member

emilazy commented Sep 15, 2025

I can sort them (or declare them something we can punt on for now), since the old version will be broken by CMake 4 anyway :) Testing a nanoboyadvance patch already.

@emilazy
Copy link
Member

emilazy commented Sep 16, 2025

Hope you don’t mind me pushing to your branch. Regressions other than the Git versions of Nix/Lix should now be fixed; we’ll want to land this soon for CMake 4.

@nixpkgs-ci nixpkgs-ci bot added the 10.rebuild-nixos-tests This PR causes rebuilds for all NixOS tests and should normally target the staging branches. label Sep 16, 2025
@emilazy emilazy changed the base branch from master to staging September 17, 2025 03:21
@nixpkgs-ci nixpkgs-ci bot closed this Sep 17, 2025
@nixpkgs-ci nixpkgs-ci bot reopened this Sep 17, 2025
@K900 K900 merged commit 0f7e83d into NixOS:staging Sep 17, 2025
56 of 58 checks passed
@emilazy
Copy link
Member

emilazy commented Sep 17, 2025

Thanks for sticking with this :)

@Chaostheorie
Copy link
Contributor Author

@emilazy, Thank you for taking care of the transitive dependencies.

@Chaostheorie Chaostheorie deleted the cr-toml11 branch September 20, 2025 13:14
@emilazy
Copy link
Member

emilazy commented Sep 20, 2025

Just another day on staging 😆

getchoo added a commit to getchoo-contrib/nix that referenced this pull request Oct 9, 2025
v4.4.0 hit Nixpkgs in NixOS/nixpkgs#442682.
Ideally we'd just use that, but this keeps the fallback behavior until
it's more widespread
github-actions bot pushed a commit to NixOS/nix that referenced this pull request Oct 9, 2025
v4.4.0 hit Nixpkgs in NixOS/nixpkgs#442682.
Ideally we'd just use that, but this keeps the fallback behavior until
it's more widespread

(cherry picked from commit 0f016f9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 10.rebuild-nixos-tests This PR causes rebuilds for all NixOS tests and should normally target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants