Conversation
|
Note for reviewer(s): Review(s) would be appreciated, but please do not merge this until a member of the nix team approves it. There are dependent packages that require version bumps before this can be merged. |
Major bump, see https://github.com/ToruNiina/toml11/releases/tag/v4.4.0 for the current release notes This also enables the upstream unit tests. Co-authored-by: dotlambda <github@dotlambda.de>
5c6848e to
ad17bca
Compare
|
Should be ready after #443012. |
|
|
|
|
Thank you a lot for evaluating/building the change. I will try to take a look at the regressions, maybe a split package for v3.x might still be a viable stopgab solution for those packages. |
|
I can sort them (or declare them something we can punt on for now), since the old version will be broken by CMake 4 anyway :) Testing a |
|
Hope you don’t mind me pushing to your branch. Regressions other than the Git versions of Nix/Lix should now be fixed; we’ll want to land this soon for CMake 4. |
|
Thanks for sticking with this :) |
|
@emilazy, Thank you for taking care of the transitive dependencies. |
|
Just another day on |
v4.4.0 hit Nixpkgs in NixOS/nixpkgs#442682. Ideally we'd just use that, but this keeps the fallback behavior until it's more widespread
v4.4.0 hit Nixpkgs in NixOS/nixpkgs#442682. Ideally we'd just use that, but this keeps the fallback behavior until it's more widespread (cherry picked from commit 0f016f9)
Major bump, see https://github.com/ToruNiina/toml11/releases/tag/v4.4.0 for the current release notes. This also enables the upstream unit tests.
see #430607, #442668 and #434186 for related comments
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.