packaging: only override toml11 when necessary#14199
Merged
xokdvium merged 1 commit intoNixOS:masterfrom Oct 9, 2025
Merged
Conversation
v4.4.0 hit Nixpkgs in NixOS/nixpkgs#442682. Ideally we'd just use that, but this keeps the fallback behavior until it's more widespread
getchoo
force-pushed
the
getchoo/toml11-fix
branch
from
1d2f79f to
0f016f9
Compare
xokdvium
approved these changes
Oct 9, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
xokdvium
added
backport 2.31-maintenance
|
Successfully created backport PR for |
2 tasks
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
v4.4.0 hit Nixpkgs in NixOS/nixpkgs#442682.
Ideally we'd just use that, but this keeps the fallback behavior until
it's more widespread
This also fixes a build failure of this flake against a recent
nixos-unstable(NixOS/nixpkgs@c9b6fb7 for example), which is caused bytoml11now requiring submodules in its source after the above bump (which we overrideAttrs away here)Context
doctest/nlohmann_jsonnixpkgs#450200Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.