toml11_4: init

[Chaostheorie]

Init of toml11 with major version 4. This is a seperate package to keep toml11 (with version 3.x) for other dependent packages, like nix and lix.

The code is effectively the toml11 package however I have also made a minor adjustment to build & run the included unit tests.

It should be noted that the main reason for not replacing toml11, with toml11_3 and taking over with this derivation, is to avoid the mass rebuild from `nix.
I can't test those rebuilds locally and would like to avoid it unless necessary.

Successor of #430607

---

I noticed that cabinpkg contains an inlined build of toml11 4.2.0, it is likely possible to replace this with the toml11_4 from this PR.

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

---

Add a 👍 reaction to pull requests you find important.

[Chaostheorie]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 442668
Commit: f91e0e959d893a948f9613240c5b94157f48436c

---

x86_64-linux

✅ 1 package built:

• toml11_4

[Chaostheorie]

As a note to a reviewer or other (potential) maintainer, I did mark myself as the maintainer here however I'm at best a C++ beginner (can read/build code, can't meaningfully write it). This might be best handled by an actual user (like the lix or nix team) instead.

[Chaostheorie]

For reviewer(s), the basic test for binaries/libraries was replacing the inlined build of toml11 4.2.0 in Chaostheorie/nixpkgs@7dc8fc1.

[alois31]

This is indeed something that Lix could depend upon. However at the time of making the comment I underestimated the urgency of the toml11 bump, while overestimating the difficulty of preparing fixed Lix versions. If the nix team agrees it would probably be better to go ahead with #430607 and update Nix and Lix to fixed versions.

[Chaostheorie]

Okay, then I will rebase the code from #430607 and amend with the changes for the unit tests.

[alois31]

I would prefer to have input from the nix maintainers before additional changes are rushed, to prevent unnecessary back and forth.

[Chaostheorie]

I would prefer to have input from the nix maintainers before additional changes are rushed, to prevent unnecessary back and forth.

Sorry, I read that too late. There are now two open PRs, the other one is marked as a draft until the maintainers comment here.

[alois31]

No, you did not read it too late. I just didn't write it explicitly enough.

[emilazy]

Sorry about this…

We will most likely be bumping this soon for #394444, and I think the issues on the Lix and Nix end have been worked out – I have coordinated with @xokdvium on this and believe Nix already has fixed releases out, while Lix has merged patches – so a split version package is probably not the route we’ll take.

Enabling the tests does sound like a good idea, however, and it’d certainly be good to have a maintainer for this package if you feel like volunteering!

[Chaostheorie]

[..] - so a split version package is probably not the route we’ll take.

Thank you for the quick response, then I'll mark the other PR ready for review and close this one for now. This PR can be reopened, if the route does change in the future.