Conversation
Major bump, see https://github.com/ToruNiina/toml11/releases/tag/v4.4.0 for the current release notes The cmake flags were taken from the project readme, https://github.com/ToruNiina/toml11#precompile-library
|
It seems nix (and lix) itself uses this. Would a major upgrade be an issue? cc @nixos/nix-team Edit: From the logs of the build, e.g., line 6453, it appears that the build itself passes, but there is at least an observable change in deserialization of dates ( |
|
There are actually two changes in behaviour that can be observed from Lix (probably Nix is the same): the date deserialization thing, and overflowing integer deserialization now throwing instead of saturating. The former is fixed in the development version by removing the experimental feature entirely, and ports of the timestamp normalization patch (NixOS/nix#13741) to the stable branches are pending. On the other hand integer deserialization saturating is actually considered a bug that should be fixed, and the development version has started to require major version 4 for that reason. Maybe it would make sense to temporarily keep the old version around as |
Major bump, see https://github.com/ToruNiina/toml11/releases/tag/v4.4.0 for the current release notes
The cmake flags were taken from the project readme, https://github.com/ToruNiina/toml11#precompile-library
Also removed an empty
with maintainers;as minor style fix.nixpkgs-review is being run, it appears this causes a mass-rebuild due to being a dep of nix.
I don't intend to maintain this package, just tried to package havoc for #429930 and noticed that toml11 in nixpkgs was a bit out of date.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.