Skip to content

toml11: 3.7.1 -> 4.4.0#430607

Closed
Chaostheorie wants to merge 1 commit intoNixOS:masterfrom
Chaostheorie:cr-toml11
Closed

toml11: 3.7.1 -> 4.4.0#430607
Chaostheorie wants to merge 1 commit intoNixOS:masterfrom
Chaostheorie:cr-toml11

Conversation

@Chaostheorie
Copy link
Contributor

@Chaostheorie Chaostheorie commented Aug 3, 2025

Major bump, see https://github.com/ToruNiina/toml11/releases/tag/v4.4.0 for the current release notes

The cmake flags were taken from the project readme, https://github.com/ToruNiina/toml11#precompile-library

Also removed an empty with maintainers; as minor style fix.

nixpkgs-review is being run, it appears this causes a mass-rebuild due to being a dep of nix.


I don't intend to maintain this package, just tried to package havoc for #429930 and noticed that toml11 in nixpkgs was a bit out of date.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. labels Aug 3, 2025
@Chaostheorie
Copy link
Contributor Author

Chaostheorie commented Aug 3, 2025

It seems nix (and lix) itself uses this. Would a major upgrade be an issue? cc @nixos/nix-team

Edit: From the logs of the build, e.g., line 6453, it appears that the build itself passes, but there is at least an observable change in deserialization of dates ("1979-05-27 07:32:00Z"; vs "1979-05-27T07:32:00Z";), which becomes visible during snapshot testing.

@Chaostheorie Chaostheorie marked this pull request as ready for review August 5, 2025 01:08
@alois31
Copy link
Contributor

alois31 commented Aug 23, 2025

There are actually two changes in behaviour that can be observed from Lix (probably Nix is the same): the date deserialization thing, and overflowing integer deserialization now throwing instead of saturating. The former is fixed in the development version by removing the experimental feature entirely, and ports of the timestamp normalization patch (NixOS/nix#13741) to the stable branches are pending. On the other hand integer deserialization saturating is actually considered a bug that should be fixed, and the development version has started to require major version 4 for that reason. Maybe it would make sense to temporarily keep the old version around as toml11_3 or similar, and migrate Nix and Lix to them until they are fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants