ci/eval/compare: avoid CI failures on non-github maintainer records#437407
Closed
zeuner wants to merge 1 commit intoNixOS:masterfrom
Closed
ci/eval/compare: avoid CI failures on non-github maintainer records#437407zeuner wants to merge 1 commit intoNixOS:masterfrom
zeuner wants to merge 1 commit intoNixOS:masterfrom
Conversation
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
nix-owners
bot
requested review from
MattSturgeon,
Mic92,
philiptaron,
wolfgangwalther and
zowoq
13 tasks
This comment was marked as off-topic.
This comment was marked as off-topic.
wolfgangwalther
requested changes
Aug 27, 2025
This comment was marked as off-topic.
This comment was marked as off-topic.
2 tasks
zeuner
force-pushed
the
ci-maintainers-fix
branch
from
9050cba to
43d5f64
Compare
wolfgangwalther
requested changes
Aug 28, 2025
Comment on lines
+98
to
+99
| # TODO: create ping lists for other contacts once non-GitHub ping | ||
| # implementations get merged |
Contributor
There was a problem hiding this comment.
I won't accept this TODO.
Comment on lines
+109
to
+110
| # TODO: If community consensus (e.g. an RFC) makes `githubId` mandatory, | ||
| # simplify to `pkg.maintainers` |
Contributor
There was a problem hiding this comment.
Community consensus is already reached, this is just about getting the implementation merged, so I won't accept this TODO either.
Contributor
Contributor
|
I agree, this would only be a temporary fix for now less than a week. We can't merge any PRs touching the packages that the two remaining maintainers without |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filtering out maintainer records without a GitHub contact before computing the GitHub-specific ping list.
A well-formed maintainer records requires either an e-mail, a matrix or a GitHub contact. However, the current CI implementation fails to evaluate if there is no GitHub contact, no matter whether the other contacts are present. This can lead to misleading CI messages (e.g. https://github.com/NixOS/nixpkgs/actions/runs/17257678120/job/48972816114?pr=437389) on a perfectly valid PR pointing to perfectly valid maintainer records. Inexperienced contributers might think they did something wrong, and inexperienced reviewers might think the PR is not worth looking at due to the CI failure.
This was already fixed in
ofborgbefore (NixOS/ofborg#665), but apparently the fix wasn't merged before the code was moved tonixpkgs.Of course this does not replace the need to provide ping handlers for the other contact entry variants, which should be processed in separate PRs.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.